Remove unnecessary Node* closures in operator registration#27007
Closed
zdevito wants to merge 15 commits intogh/zdevito/119/basefrom
Closed
Remove unnecessary Node* closures in operator registration#27007zdevito wants to merge 15 commits intogh/zdevito/119/basefrom
zdevito wants to merge 15 commits intogh/zdevito/119/basefrom
Conversation
This was referenced Sep 27, 2019
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Contributor
|
Is there measurable code size impact from this? |
Contributor
Author
|
I didn't bother to measure it. The issue was we were missing a constructor that took a symbol, which was blocking people from using the easier overload. |
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Remove unnecessary Node* closures in operator registration gh-metadata: pytorch pytorch 27007 gh/zdevito/119/head
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#27007 Test Plan: Imported from OSS Differential Revision: D17696525 Pulled By: zdevito fbshipit-source-id: b329b77afa0e6dbe9cb920a98cf07bb329d01023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17696525