Remove preallocation of type ids#26509
Closed
smessmer wants to merge 28 commits intogh/smessmer/53/basefrom
Closed
Remove preallocation of type ids#26509smessmer wants to merge 28 commits intogh/smessmer/53/basefrom
smessmer wants to merge 28 commits intogh/smessmer/53/basefrom
Conversation
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
Closed
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 19, 2019
Pull Request resolved: #26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 90460072 Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/)
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 20, 2019
Pull Request resolved: #26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 90472976 Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/)
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
Closed
smessmer
added a commit
that referenced
this pull request
Sep 20, 2019
Pull Request resolved: #26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 90475626 Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/)
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 20, 2019
Pull Request resolved: #26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 90482872 Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/)
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 20, 2019
Pull Request resolved: #26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 90483411 Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/)
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 21, 2019
Pull Request resolved: #26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 90547627 Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/)
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 21, 2019
Pull Request resolved: #26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 90552745 Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/)
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
Closed
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
This was referenced Sep 22, 2019
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
dzhulgakov
approved these changes
Sep 25, 2019
Collaborator
dzhulgakov
left a comment
There was a problem hiding this comment.
Assuming that the previous diff doesn't cause compile time regression - this is good
ezyang
approved these changes
Sep 25, 2019
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. Differential Revision: [D17490109](https://our.internmc.facebook.com/intern/diff/D17490109/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in cf01f53. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26509 We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see pytorch#10139. However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning. caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType. I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned and remove the functionality for preallocated type ids. This simplifies our type ids. ghstack-source-id: 91896918 Test Plan: unit tests Differential Revision: D17490109 fbshipit-source-id: 800c340d9d3556a99f6e3ffc33af14ad68d7cc59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We preallocated type ids to align them with ScalarType. At that point, the maximum type id was 10 and we used 11 to specify undefined type id, see #10139.
However, since then, ScalarType got more additions, 11 isn't undefined anymore, and numbers 11-15 have meaning.
caffe2::TypeIdentifier also got its separate additions, 12 and upwards have meaning that differs from ScalarType.
I'm going with the (CI-tested) assumption that caffe2::TypeIdentifier and ScalarType actually don't need to be aligned
and remove the functionality for preallocated type ids. This simplifies our type ids.
Differential Revision: D17490109