Skip to content

Remove CAFFE_KNOWN_TYPE#26628

Closed
smessmer wants to merge 56 commits intogh/smessmer/61/basefrom
gh/smessmer/61/head
Closed

Remove CAFFE_KNOWN_TYPE#26628
smessmer wants to merge 56 commits intogh/smessmer/61/basefrom
gh/smessmer/61/head

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Sep 22, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D17520395

@smessmer
[wip] Remove CAFFE_KNOWN_TYPE
c868532 
Differential Revision: [D17520395](https://our.internmc.facebook.com/intern/diff/D17520395/)

[ghstack-poisoned]
@pytorchbot pytorchbot added the module: internals Related to internal abstractions in c10 and ATen label Sep 22, 2019
This was referenced Sep 22, 2019
Closed
Closed
Closed
Closed
Closed
Closed
smessmer added a commit that referenced this pull request Sep 22, 2019
@smessmer
[wip] Remove CAFFE_KNOWN_TYPE
c0006b2 
Pull Request resolved: #26628


ghstack-source-id: 90561687

Differential Revision: [D17520395](https://our.internmc.facebook.com/intern/diff/D17520395/)
smessmer added a commit that referenced this pull request Sep 22, 2019
@smessmer
[wip] Remove CAFFE_KNOWN_TYPE
894eaf9 
Pull Request resolved: #26628


ghstack-source-id: 90568813

Differential Revision: [D17520395](https://our.internmc.facebook.com/intern/diff/D17520395/)
@ezyang
Copy link
Contributor

ezyang commented Dec 12, 2019

@smessmer smessmer removed request for ezyang and dzhulgakov 42 minutes ago ?

@kostmo
Copy link
Member

kostmo commented Dec 12, 2019 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 61efde2:

  • 1/5 broken upstream at merge base d2fdf14 since Jan 08

    Please rebase on the viable/strict branch (expand for instructions)

    Since your merge base is older than viable/strict, run these commands:

    git fetch origin viable/strict
git rebase viable/strict

    Check out the recency history of this "viable master" tracking branch.

  • 4/5 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🕵️ 4 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakage:

See CircleCI build pytorch_xla_linux_xenial_py3_6_clang7_build (1/4)

Step: "Build" (full log | pattern match details)

Jan 11 04:02:07 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh'] 
Jan 11 04:02:07 323 function overrides in /var/lib/jenkins/workspace/xla/scripts/../torch_xla/csrc/aten_xla_type.h 
Jan 11 04:02:07 Generated 877 wrappers for /var/lib/jenkins/workspace/xla/scripts/../../torch/csrc/autograd/generated/RegistrationDeclarations.h 
Jan 11 04:02:07 AtenXlaType function missed override: Tensor& bitwise_or_out(Tensor& out, const Tensor& self, const Tensor& other); // bitwise_or_out(Tensor,Tensor,Tensor)->Tensor 
Jan 11 04:02:07 AtenXlaType function missed override: Tensor& bitwise_or_out(Tensor& out, const Tensor& self, Scalar other); // bitwise_or_out(Tensor,Tensor,Scalar)->Tensor 
Jan 11 04:02:07 Traceback (most recent call last): 
Jan 11 04:02:07   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1052, in <module> 
Jan 11 04:02:07     generate(args) 
Jan 11 04:02:07   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1022, in generate 
Jan 11 04:02:07     assert check_overrides(overrides, overridden) 
Jan 11 04:02:07 AssertionError 
Jan 11 04:02:07 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh'] 
Jan 11 04:02:07 Building torch_xla version: 0.8 
Jan 11 04:02:07 + cleanup 
Jan 11 04:02:07 + retcode=1 
Jan 11 04:02:07 + set +x 
Jan 11 04:02:07 =================== sccache compilation log =================== 
Jan 11 04:02:07 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jan 11 04:02:07 Compile requests               2526 
Jan 11 04:02:07 Compile requests executed      2269 
Jan 11 04:02:07 Cache hits                     1201 
Jan 11 04:02:07 Cache misses                   1056

See CircleCI build pytorch_windows_test1 (2/4)

Step: "Test" (full log | pattern match details)

RuntimeError: test_nn failed! 
C:\Jenkins\Miniconda3\lib\site-packages\numba\cuda\envvars.py:16: NumbaDeprecationWarning:  
Environment variables with the 'NUMBAPRO' prefix are deprecated, found use of NUMBAPRO_CUDALIB=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\bin. 
 
For more information visit http://numba.pydata.org/numba-doc/latest/reference/deprecation.html#deprecation-of-numbapro-environment-variables 
  warnings.warn(errors.NumbaDeprecationWarning(msg)) 
test_to (__main__.PackedSequenceTest) ... Traceback (most recent call last): 
  File "run_test.py", line 456, in <module> 
    main() 
  File "run_test.py", line 449, in main 
    raise RuntimeError(message) 
RuntimeError: test_nn failed! 
 
(base) circleci@PACKER-5DDC1B75 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

See CircleCI build pytorch_windows_test2 (3/4)

Step: "Test" (full log | pattern match details)

RuntimeError: test_autograd failed! 
test_symeig_no_eigenvectors (__main__.TestAutograd) ... ok 
test_thread_shutdown (__main__.TestAutograd) ... skipped "Skipping because doesn't work for windows" 
test_too_many_grads (__main__.TestAutograd) ... ok 
test_trapz (__main__.TestAutograd) ... ok 
test_triangular_solve (__main__.TestAutograd) ... ok 
test_type_conversions (__main__.TestAutograd) ... Traceback (most recent call last): 
  File "run_test.py", line 456, in <module> 
    main() 
  File "run_test.py", line 449, in main 
    raise RuntimeError(message) 
RuntimeError: test_autograd failed! 
 
(base) circleci@PACKER-5DDC1B75 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test (4/4)

Step: "Test" (full log | pattern match details)

Jan 11 05:36:26 RuntimeError: test_cpp_extensions failed! Received signal: SIGIOT 
Jan 11 05:36:26 frame #60: PyObject_Call + 0x3e (0x5599eb720a5e in /opt/conda/bin/python) 
Jan 11 05:36:26 frame #61: _PyEval_EvalFrameDefault + 0x19e7 (0x5599eb7cce37 in /opt/conda/bin/python) 
Jan 11 05:36:26 frame #62: <unknown function> + 0x192e66 (0x5599eb7a1e66 in /opt/conda/bin/python) 
Jan 11 05:36:26 frame #63: _PyFunction_FastCallDict + 0x1be (0x5599eb7a337e in /opt/conda/bin/python) 
Jan 11 05:36:26  
Jan 11 05:36:26 Traceback (most recent call last): 
Jan 11 05:36:26   File "test/run_test.py", line 456, in <module> 
Jan 11 05:36:26     main() 
Jan 11 05:36:26   File "test/run_test.py", line 449, in main 
Jan 11 05:36:26     raise RuntimeError(message) 
Jan 11 05:36:26 RuntimeError: test_cpp_extensions failed! Received signal: SIGIOT 
Jan 11 05:36:27 + cleanup 
Jan 11 05:36:27 + retcode=1 
Jan 11 05:36:27 + set +x 
Jan 11 05:36:27 =================== sccache compilation log =================== 
Jan 11 05:36:27 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jan 11 05:36:27 Compile requests                 6 
Jan 11 05:36:27 Compile requests executed        3 
Jan 11 05:36:27 Cache hits                       3 
Jan 11 05:36:27 Cache misses                     0 
Jan 11 05:36:27 Cache timeouts                   0

🚧 1 upstream failure recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 42 times.

@smessmer
Copy link
Contributor Author

smessmer commented Dec 12, 2019

@ezyang yeah. This fails CI and doesn't seem to be ready. I'll re-request review once it's in a better state.

This was referenced Dec 16, 2019
Closed
Closed
@smessmer smessmer mentioned this pull request Dec 16, 2019
Closed
@smessmer smessmer mentioned this pull request Dec 16, 2019
Closed
@smessmer smessmer mentioned this pull request Dec 17, 2019
Closed
This was referenced Jan 14, 2020
Closed
Closed
Closed
xxtEchjovs44 pushed a commit to xxtEchjovs44/pytorch that referenced this pull request Jan 29, 2020
@smessmer
Remove CAFFE_KNOWN_TYPE
fad36b8 
Pull Request resolved: pytorch/pytorch#26628


ghstack-source-id: 96548705

Differential Revision: [D17520395](https://our.internmc.facebook.com/intern/diff/D17520395/)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Apr 12, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
Stale pull requests will automatically be closed 30 days after being marked Stale

@github-actions github-actions bot closed this May 12, 2022
@facebook-github-bot facebook-github-bot deleted the gh/smessmer/61/head branch June 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed module: internals Related to internal abstractions in c10 and ATen Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smessmer @ezyang @kostmo @pytorchbot @facebook-github-bot