Closed
Conversation
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
This was referenced Sep 22, 2019
Closed
Closed
Closed
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
This was referenced Oct 22, 2019
Closed
Merged
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. Differential Revision: [D17519253](https://our.internmc.facebook.com/intern/diff/D17519253/) [ghstack-poisoned]
ezyang
reviewed
Dec 11, 2019
| string_view prefix, | ||
| string_view suffix, | ||
| string_view str) { | ||
| #if !defined(__CUDA_ARCH__) // CUDA doesn't like std::logic_error in device code |
Contributor
There was a problem hiding this comment.
Umm, and why should this ever be run on device?
Contributor
Author
There was a problem hiding this comment.
it shouldn't be but CUDA seems to want to compile it for device code just in case.
Contributor
There was a problem hiding this comment.
This is what __host__ is for
ezyang
approved these changes
Dec 11, 2019
Contributor
|
This pull request has been merged in 6e1e09f. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#26618 Implement a mechanism to get type names at compile time In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places. ghstack-source-id: 95337871 Test Plan: unit tests Differential Revision: D17519253 fbshipit-source-id: e14017f962fd181d147accb3f53fa8d6ee42a3f8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Implement a mechanism to get type names at compile time
In a future diff, I'm planning to introduce this to caffe2::TypeMeta and a few other places.
Differential Revision: D17519253