Better error messages thanks to compile time type names#30712
Better error messages thanks to compile time type names#30712smessmer wants to merge 24 commits intogh/smessmer/131/basefrom
Conversation
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) ghstack-source-id: 94904001 Pull Request resolved: #30712
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: #30712 ghstack-source-id: 94981527 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: #30712 ghstack-source-id: 95027404 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: #30712 ghstack-source-id: 95048454 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: #30712 ghstack-source-id: 95145672 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: #30712 ghstack-source-id: 95174844 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: #30712 ghstack-source-id: 95213510 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
…mes" Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: #30712 ghstack-source-id: 95339666 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
| static TypePtr call() { | ||
| if (!isCustomClassRegistered<T>()) { | ||
| throw c10::Error("Type could not be converted to any of the known types.", ""); | ||
| throw c10::Error( |
There was a problem hiding this comment.
Why aren't you using TORCH_CHECK(0, msg...) here?
💊 CircleCI build failures summary and remediationsAs of commit a868662:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🕵️ 12 new failures recognized by patternsThe following build failures do not appear to be due to upstream breakage:
|
| Job | Step | Status |
|---|---|---|
| Test | New in PR |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker.
This comment has been revised 90 times.
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/) [ghstack-poisoned]
Pull Request resolved: pytorch/pytorch#30712 ghstack-source-id: 96548701 Differential Revision: [D18805082](https://our.internmc.facebook.com/intern/diff/D18805082/)
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack:
Differential Revision: D18805082