caffe2::TypeMeta uses compile time type names#26619
Closed
smessmer wants to merge 47 commits intogh/smessmer/60/basefrom
Closed
caffe2::TypeMeta uses compile time type names#26619smessmer wants to merge 47 commits intogh/smessmer/60/basefrom
smessmer wants to merge 47 commits intogh/smessmer/60/basefrom
Conversation
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
This was referenced Sep 22, 2019
Closed
Closed
Closed
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 22, 2019
Pull Request resolved: #26619 ghstack-source-id: 90559058 Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/)
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
This was referenced Oct 22, 2019
Closed
Merged
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
Differential Revision: [D17519252](https://our.internmc.facebook.com/intern/diff/D17519252/) [ghstack-poisoned]
ezyang
reviewed
Dec 12, 2019
| nullptr, | ||
| nullptr, | ||
| nullptr, | ||
| nullptr, |
Contributor
There was a problem hiding this comment.
This is some serious nullptr blindness
ezyang
approved these changes
Dec 12, 2019
Contributor
|
This pull request has been merged in 2950530. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#26619 ghstack-source-id: 95348564 Test Plan: unit tests Differential Revision: D17519252 fbshipit-source-id: 337ec76d17172dd1af60a1676d69964a41dcb7a1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17519252