Closed
Conversation
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
This was referenced Sep 22, 2019
Closed
Closed
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
This was referenced Sep 22, 2019
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
This was referenced Oct 15, 2019
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
This was referenced Oct 15, 2019
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
Implement C++17 std::string_view for C++11. This is useful for compile time type name retrieval which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. Differential Revision: [D17518992](https://our.internmc.facebook.com/intern/diff/D17518992/) [ghstack-poisoned]
dzhulgakov
approved these changes
Oct 17, 2019
Collaborator
dzhulgakov
left a comment
There was a problem hiding this comment.
Ok, I read it diagonally and looks plausible. Given extensive testing and that it's mostly constexpr it should be good
Contributor
|
This pull request has been merged in 70e9ef5. |
gchanan
reviewed
Oct 22, 2019
| } | ||
|
|
||
| template <class T> | ||
| constexpr const T& min(const T& a, const T& b) { |
Contributor
There was a problem hiding this comment.
this is constexpr in C++14, right? Is there a reason we aren't tracking C++14 / C++17 separately so we can kill the C++14 stuff once we move to that?
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26616 Implement C++17 std::string_view for C++11. This is useful for compile time type name retrievaly which I'm going to stack on top of this. It is also useful to replace `const std::string&` with throughout our codebase. ghstack-source-id: 92100314 Test Plan: unit tests Differential Revision: D17518992 fbshipit-source-id: 48e31c677d51b0041f4b37e89a92bd176d4a0b08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Implement C++17 std::string_view for C++11.
This is useful for compile time type name retrieval which I'm going to stack on top of this.
It is also useful to replace
const std::string&with throughout our codebase.Differential Revision: D17518992