🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177047

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 7dc74f6 with merge base 52dd8fe ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorchbot merge -f 'This is a revert'

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchbot revert -m "Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable" -c autorevert

This PR is attributed to have caused regression in:

• Lint: lintrunner-noclang-all / linux-job (hud)

Please investigate and fix the issues.
@claude Can you please read this revert comment, follow the links and read the errors, to then give a brief diagnostics on the cause of the error? If you judge the error to be legitimate reason for a revert, please provide brief guidance on how the author could fix it.

Claude finished @pytorch-auto-revert[bot]'s task in 1m 24s —— View job

Diagnosis of Revert Cause

• Read the revert trigger and identify the failing job
• Investigate the lint failure
• Analyze root cause and provide guidance

Root Cause

The revert was caused by RUFF UP045 lint violations in torch/fx/node.py. The linter requires the modern X | None annotation style instead of Optional[X].

When this revert PR (#177047) restored the original Python implementation of torch.fx.Node, it reintroduced several Optional[...] type annotations that had been removed when the code was moved to C++. Meanwhile, PR #176308 had landed on main to modernize annotations (Optional[X] → X | None) across the codebase, and the RUFF UP045 rule now enforces this.

The PR description noted the merge conflict was resolved keeping the modern style, but a few Optional[...] annotations were missed in the restored code. Specifically, the violations are at these locations in torch/fx/node.py:

Is this a legitimate revert?

Yes, the revert is legitimate. Lint failures on trunk block the CI pipeline for all contributors. The fix is trivial, but since this was already merged, a revert is the standard procedure.

How to fix

The fix is straightforward — replace the remaining Optional[X] annotations with X | None in torch/fx/node.py. The linter output even provides the exact diff. The changes needed:

# Line 597-598: format_node params
-        placeholder_names: Optional[list[str]] = None,
-        maybe_return_typename: Optional[list[str]] = None,
+        placeholder_names: list[str] | None = None,
+        maybe_return_typename: list[str] | None = None,

# Line 601: format_node return type
-    ) -> Optional[str]:
+    ) -> str | None:

# Line 695: replace_all_uses_with param
-        delete_user_cb: Optional[Callable[["Node"], bool]] = None,
+        delete_user_cb: Callable[["Node"], bool] | None = None,

# Line 789-790: normalized_arguments params
-        arg_types: Optional[tuple[Any]] = None,
-        kwarg_types: Optional[dict[str, Any]] = None,
+        arg_types: tuple[Any] | None = None,
+        kwarg_types: dict[str, Any] | None = None,

# Line 792: normalized_arguments return type
-    ) -> Optional[ArgsKwargsPair]:
+    ) -> ArgsKwargsPair | None:

The author should apply these annotation fixes and re-land the revert. Running lintrunner -a would auto-fix these.

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@wdvr your PR has been successfully reverted.

@pytorchmergebot rebase -b main

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/22968090201