[fx] Move _Namespace to C++ by jansel · Pull Request #170962 · pytorch/pytorch

jansel · 2025-12-20T21:09:44Z

Stack from ghstack (oldest at bottom):

cc @ezyang @EikanWang @jgong5 @wenzhe-nrv

[ghstack-poisoned]

pytorch-bot · 2025-12-20T21:09:47Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170962

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit e639f5e with merge base e81980e ():

NEW FAILURE - The following job has failed:

pull / linux-jammy-py3.14t-clang15 / test (crossref, 1, 2, lf.linux.2xlarge) (gh)
'Test'

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx950.1) (gh) (disabled by #107893 but the issue was closed recently and a rebase is needed to make it pass)
test/inductor/test_inductor_freezing.py::FreezingCpuTests::test_conv_with_as_strided_cpu

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 0ebeac4 Pull-Request: #170962

[ghstack-poisoned]

ghstack-source-id: 5247aeb Pull-Request: #170962

[ghstack-poisoned]

pytorchmergebot · 2025-12-25T05:48:13Z

Rebased gh/jansel/588/orig onto refs/remotes/origin/viable/strict because #170973 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/170962)

jansel · 2025-12-25T16:35:41Z

@pytorchbot merge

pytorchmergebot · 2025-12-25T16:37:45Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

This reverts commit a50d65a. Reverted #170962 on behalf of https://github.com/clee2000 due to sorry but I think this broke a test on inductor test/inductor/test_max_autotune.py::TestMaxAutotuneAsyncPipelined::test_empty_conv_input_search_space_EXHAUSTIVE_kernel_size_1 [GH job link](https://github.com/pytorch/pytorch/actions/runs/20510247600/job/58931365661) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/a50d65ad2f8c39a19be6ee3d7e0b37b0f3f47189)? it might be a landrace since I see that it did succeed on this PR. Also its failing some tests internally D89800849 ([comment](#170946 (comment)))

ghstack-source-id: 60f7782 Pull-Request: pytorch/pytorch#170962

[ghstack-poisoned]

pytorchmergebot · 2026-02-26T17:47:15Z

Starting merge as part of PR stack under #170973

Cumulative Changes (PR 170946 → PR 170973) | Benchmark | PR 170946 | PR 170973 | Delta | |---------------------------------------|-----------|-----------|-------| | add_loop_eager | 3,308M | 3,206M | -3.1% | | aotdispatcher_partitioner_cpu2 | 1,944M | 1,865M | -4.1% | | aotdispatcher_partitioner_cpu | 8,340M | 8,062M | -3.3% | | sum_floordiv_regression | 3,700M | 3,591M | -3.0% | | aotdispatcher_training_nosubclass_cpu | 3,242M | 3,168M | -2.3% | | update_hint_regression | 1,674M | 1,641M | -2.0% | | symint_sum_loop | 4,682M | 4,590M | -2.0% | | add_loop_inductor_gpu | 26,418M | 26,031M | -1.5% | | basic_NestedModule_eager | 6,171M | 6,084M | -1.4% | | add_loop_inductor | 29,736M | 29,342M | -1.3% | Pull Request resolved: #170973 Approved by: https://github.com/oulgen ghstack dependencies: #170946, #170962

jansel · 2026-03-07T23:54:21Z

@pytorchbot revert -m "reverted in fbcode"

pytorch-bot · 2026-03-07T23:54:23Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst,autorevert}

Try @pytorchbot --help for more info.

jansel · 2026-03-07T23:55:07Z

@pytorchbot revert -m "reverted in fbcode" -c nosignal

pytorchmergebot · 2026-03-07T23:56:56Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2026-03-07T23:57:02Z

Reverting PR 170962 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 5c68844a2a8d9eea64e58976dd6415fb60dca3ea returned non-zero exit code 1

Auto-merging build_variables.bzl
Auto-merging torch/_C/__init__.pyi.in
Auto-merging torch/csrc/Module.cpp
CONFLICT (modify/delete): torch/csrc/fx/graph.cpp deleted in parent of 5c68844a2a8 ([fx] Move _Namespace to C++ (#170962)) and modified in HEAD.  Version HEAD of torch/csrc/fx/graph.cpp left in tree.
Auto-merging torch/fx/graph.py
error: could not revert 5c68844a2a8... [fx] Move _Namespace to C++ (#170962)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

…ame (#176515)" (#176948) ## Summary Reverts #176515. This is a prerequisite for reverting the full `[fx] Move _Namespace to C++` series (#170962), which was reverted internally due to S627920 but the revert was never exported to GitHub. The quadratic fix patches `torch/csrc/fx/graph.cpp` which was introduced by #170962. This revert must land first so that #170962 can be cleanly reverted afterwards. ## Test plan CI — this revert removes a bugfix from C++ code that will itself be reverted in a follow-up PR. Pull Request resolved: #176948 Approved by: https://github.com/izaitsevfb, https://github.com/huydhn

wdvr · 2026-03-09T23:58:41Z

@pytorchbot revert -m "reverted in fbcode" -c nosignal

retrying revert after #176948 landed

pytorchmergebot · 2026-03-10T00:00:51Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit 5c68844. Reverted #170962 on behalf of https://github.com/wdvr due to reverted in fbcode ([comment](#170962 (comment)))

pytorchmergebot · 2026-03-10T00:01:00Z

@jansel your PR has been successfully reverted.

## Summary Reverts #170946 This reverts commit fa27d4f. The two stacked PRs (#170962 and #170973) have already been reverted on main: - `0a06050b` Revert "[fx] Move _FindNodesLookupTable and _node_list to C++ (#170973)" - `2ee3377b` Revert "[fx] Move _Namespace to C++ (#170962)" - `fb60dd58` Revert "[fx] Fix quadratic name generation in _NamespaceBase.create_name (#176515)" The only merge conflict was in `torch/fx/node.py` due to a type annotation modernization PR (#176308, `Optional[X]` → `X | None`). The conflict was resolved by keeping the modern annotation style while restoring the original Python implementation. ## Test plan CI Pull Request resolved: #177047 Approved by: https://github.com/huydhn

ghstack-source-id: e346919 Pull-Request: pytorch/pytorch#170962

Pull Request resolved: pytorch#170962 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170946

Cumulative Changes (PR 170946 → PR 170973) | Benchmark | PR 170946 | PR 170973 | Delta | |---------------------------------------|-----------|-----------|-------| | add_loop_eager | 3,308M | 3,206M | -3.1% | | aotdispatcher_partitioner_cpu2 | 1,944M | 1,865M | -4.1% | | aotdispatcher_partitioner_cpu | 8,340M | 8,062M | -3.3% | | sum_floordiv_regression | 3,700M | 3,591M | -3.0% | | aotdispatcher_training_nosubclass_cpu | 3,242M | 3,168M | -2.3% | | update_hint_regression | 1,674M | 1,641M | -2.0% | | symint_sum_loop | 4,682M | 4,590M | -2.0% | | add_loop_inductor_gpu | 26,418M | 26,031M | -1.5% | | basic_NestedModule_eager | 6,171M | 6,084M | -1.4% | | add_loop_inductor | 29,736M | 29,342M | -1.3% | Pull Request resolved: pytorch#170973 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170946, pytorch#170962

…ame (pytorch#176515)" (pytorch#176948) ## Summary Reverts pytorch#176515. This is a prerequisite for reverting the full `[fx] Move _Namespace to C++` series (pytorch#170962), which was reverted internally due to S627920 but the revert was never exported to GitHub. The quadratic fix patches `torch/csrc/fx/graph.cpp` which was introduced by pytorch#170962. This revert must land first so that pytorch#170962 can be cleanly reverted afterwards. ## Test plan CI — this revert removes a bugfix from C++ code that will itself be reverted in a follow-up PR. Pull Request resolved: pytorch#176948 Approved by: https://github.com/izaitsevfb, https://github.com/huydhn

This reverts commit 5c68844. Reverted pytorch#170962 on behalf of https://github.com/wdvr due to reverted in fbcode ([comment](pytorch#170962 (comment)))

…ytorch#177047) ## Summary Reverts pytorch#170946 This reverts commit fa27d4f. The two stacked PRs (pytorch#170962 and pytorch#170973) have already been reverted on main: - `0a06050b` Revert "[fx] Move _FindNodesLookupTable and _node_list to C++ (pytorch#170973)" - `2ee3377b` Revert "[fx] Move _Namespace to C++ (pytorch#170962)" - `fb60dd58` Revert "[fx] Fix quadratic name generation in _NamespaceBase.create_name (pytorch#176515)" The only merge conflict was in `torch/fx/node.py` due to a type annotation modernization PR (pytorch#176308, `Optional[X]` → `X | None`). The conflict was resolved by keeping the modern annotation style while restoring the original Python implementation. ## Test plan CI Pull Request resolved: pytorch#177047 Approved by: https://github.com/huydhn

Update

3e16b8e

[ghstack-poisoned]

pytorch-bot Bot added the release notes: fx release notes category label Dec 20, 2025

facebook-github-bot added the fx label Dec 20, 2025

jansel added a commit that referenced this pull request Dec 20, 2025

[fx] Move _Namespace to C++

2a7367f

ghstack-source-id: 0ebeac4 Pull-Request: #170962

This was referenced Dec 20, 2025

Fix local lint error #170945

Closed

[fx] Move the rest of torch.fx.Node to C++ #170946

Closed

jansel marked this pull request as draft December 20, 2025 21:10

Update

24b4dae

[ghstack-poisoned]

jansel added a commit that referenced this pull request Dec 20, 2025

[fx] Move _Namespace to C++

34160b0

ghstack-source-id: 5247aeb Pull-Request: #170962

Update

ffc02ee

[ghstack-poisoned]

jansel mentioned this pull request Dec 21, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++ #170973

Open

Update

8bdc6ad

[ghstack-poisoned]

jansel marked this pull request as ready for review December 24, 2025 19:25

jansel requested review from anijain2305 and williamwen42 December 24, 2025 19:26

Update

9e635ee

[ghstack-poisoned]

oulgen approved these changes Dec 24, 2025

View reviewed changes

Update

4e0d355

[ghstack-poisoned]

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 25, 2025

pytorchmergebot added the merging label Dec 25, 2025

pytorchmergebot added the Merged label Dec 25, 2025

pytorchmergebot closed this in a50d65a Dec 25, 2025

pytorchmergebot removed the merging label Dec 25, 2025

github-actions Bot mentioned this pull request Dec 26, 2025

[Digest] 2025-12-26 e1134171019/agrnt#8

Open

SergeyTyshkevich pushed a commit to SergeyTyshkevich/chart2 that referenced this pull request Jan 19, 2026

[fx] Move _Namespace to C++

3cfabac

ghstack-source-id: 60f7782 Pull-Request: pytorch/pytorch#170962

jansel added 4 commits February 24, 2026 14:32

Update

d4cd14c

[ghstack-poisoned]

Update

ea8925d

[ghstack-poisoned]

Update

556153e

[ghstack-poisoned]

Update

e639f5e

[ghstack-poisoned]

pytorchmergebot closed this in 5c68844 Feb 26, 2026

Lucaskabela mentioned this pull request Feb 27, 2026

Fix type errors on main #176012

Closed

wdvr mentioned this pull request Mar 9, 2026

Revert "[fx] Fix quadratic name generation in _NamespaceBase.create_name (#176515)" #176948

Closed

pytorchmergebot added a commit that referenced this pull request Mar 10, 2026

Revert "[fx] Move _Namespace to C++ (#170962)"

2ee3377

This reverts commit 5c68844. Reverted #170962 on behalf of https://github.com/wdvr due to reverted in fbcode ([comment](#170962 (comment)))

pytorchmergebot reopened this Mar 10, 2026

wdvr mentioned this pull request Mar 10, 2026

Revert "[fx] Move the rest of torch.fx.Node to C++ (#170946)" #177047

Closed

sandy-gags pushed a commit to sandy-gags/pytorch that referenced this pull request Mar 12, 2026

[fx] Move _Namespace to C++

ae99d40

ghstack-source-id: e346919 Pull-Request: pytorch/pytorch#170962

EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026

[fx] Move _Namespace to C++ (pytorch#170962)

e5a9d5e

Pull Request resolved: pytorch#170962 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170946

Conversation

jansel commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170962

❌ 1 New Failure, 1 Unrelated Failure

Uh oh!

pytorchmergebot commented Dec 25, 2025

Uh oh!

jansel commented Dec 25, 2025

Uh oh!

pytorchmergebot commented Dec 25, 2025

Merge started

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

jansel commented Mar 7, 2026

Uh oh!

pytorch-bot Bot commented Mar 7, 2026

Uh oh!

jansel commented Mar 7, 2026

Uh oh!

pytorchmergebot commented Mar 7, 2026

Uh oh!

pytorchmergebot commented Mar 7, 2026

Reverting PR 170962 failed

Uh oh!

wdvr commented Mar 9, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jansel commented Dec 20, 2025 •

edited

Loading

pytorch-bot Bot commented Dec 20, 2025 •

edited

Loading