Skip to content

Revert "[fx] Fix quadratic name generation in _NamespaceBase.create_name (#176515)"#176948

Closed
wdvr wants to merge 1 commit intopytorch:mainfrom
wdvr:revert-fx-cpp-migration
Closed

Revert "[fx] Fix quadratic name generation in _NamespaceBase.create_name (#176515)"#176948
wdvr wants to merge 1 commit intopytorch:mainfrom
wdvr:revert-fx-cpp-migration

Conversation

@wdvr
Copy link
Contributor

@wdvr wdvr commented Mar 9, 2026

Summary

Reverts #176515.

This is a prerequisite for reverting the full [fx] Move _Namespace to C++ series (#170962), which was reverted internally due to S627920 but the revert was never exported to GitHub.

The quadratic fix patches torch/csrc/fx/graph.cpp which was introduced by #170962. This revert must land first so that #170962 can be cleanly reverted afterwards.

cc @jansel @anijain2305

Test plan

CI — this revert removes a bugfix from C++ code that will itself be reverted in a follow-up PR.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 9, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176948

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 54 Pending

As of commit 6836a62 with merge base 5f68a4a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ci-no-td Do not run TD on this PR label Mar 9, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 9, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@wdvr wdvr requested a review from anijain2305 March 9, 2026 23:48
@wdvr
Copy link
Contributor Author

wdvr commented Mar 9, 2026

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 9, 2026
@wdvr
Copy link
Contributor Author

wdvr commented Mar 9, 2026

@pytorchmergebot merge -f "lint passed- this is a revert, not waiting for full signal"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 9, 2026

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@wdvr wdvr mentioned this pull request Mar 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@izaitsevfb izaitsevfb izaitsevfb approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wdvr @pytorchmergebot @huydhn @izaitsevfb