[fx] Move the rest of torch.fx.Node to C++ by jansel · Pull Request #170946 · pytorch/pytorch

jansel · 2025-12-20T06:12:43Z

Stack from ghstack (oldest at bottom):

cc @ezyang @EikanWang @jgong5 @wenzhe-nrv @albanD @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo

[ghstack-poisoned]

pytorch-bot · 2025-12-20T06:12:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170946

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit feb6b74 with merge base e81980e ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-jammy-py3.14t-clang15 / test (crossref, 1, 2, lf.linux.2xlarge) (gh) (similar failure)
test/test_serialization.py::TestSerialization::test_serialization_4gb_file

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 27ec22f Pull-Request: #170946

[ghstack-poisoned]

ghstack-source-id: b137425 Pull-Request: #170946

[ghstack-poisoned]

oulgen

i remember the last time you did this, there was a memory leak. Is there anything we can do preemptively to make sure there's no leak? I stared through the memory allocation logic but its hard to be sure

jansel · 2025-12-24T19:41:42Z

i remember the last time you did this, there was a memory leak. Is there anything we can do preemptively to make sure there's no leak? I stared through the memory allocation logic but its hard to be sure

That one was fixed and landed already.

I asked both Claude and Codex to check for leaks and semantics changes.

[ghstack-poisoned]

pytorchmergebot · 2025-12-25T05:48:12Z

Rebased gh/jansel/588/orig onto refs/remotes/origin/viable/strict because #170973 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/170946)

pytorchmergebot · 2025-12-25T16:37:48Z

Starting merge as part of PR stack under #170962

Pull Request resolved: #170962 Approved by: https://github.com/oulgen ghstack dependencies: #170945, #170946

Pull Request resolved: pytorch#170946 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170945

Pull Request resolved: pytorch#170962 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170945, pytorch#170946

This reverts commit a50d65a. Reverted pytorch#170962 on behalf of https://github.com/clee2000 due to sorry but I think this broke a test on inductor test/inductor/test_max_autotune.py::TestMaxAutotuneAsyncPipelined::test_empty_conv_input_search_space_EXHAUSTIVE_kernel_size_1 [GH job link](https://github.com/pytorch/pytorch/actions/runs/20510247600/job/58931365661) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/a50d65ad2f8c39a19be6ee3d7e0b37b0f3f47189)? it might be a landrace since I see that it did succeed on this PR. Also its failing some tests internally D89800849 ([comment](pytorch#170946 (comment)))

This reverts commit 84db132. Reverted pytorch#170946 on behalf of https://github.com/clee2000 due to sorry but I think this broke a test on inductor test/inductor/test_max_autotune.py::TestMaxAutotuneAsyncPipelined::test_empty_conv_input_search_space_EXHAUSTIVE_kernel_size_1 [GH job link](https://github.com/pytorch/pytorch/actions/runs/20510247600/job/58931365661) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/a50d65ad2f8c39a19be6ee3d7e0b37b0f3f47189)? it might be a landrace since I see that it did succeed on this PR. Also its failing some tests internally D89800849 ([comment](pytorch#170946 (comment)))

ghstack-source-id: 7e65678 Pull-Request: pytorch/pytorch#170946

github-actions · 2026-02-24T21:45:46Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[ghstack-poisoned]

pytorchmergebot · 2026-02-26T17:47:14Z

Starting merge as part of PR stack under #170973

Pull Request resolved: #170962 Approved by: https://github.com/oulgen ghstack dependencies: #170946

Cumulative Changes (PR 170946 → PR 170973) | Benchmark | PR 170946 | PR 170973 | Delta | |---------------------------------------|-----------|-----------|-------| | add_loop_eager | 3,308M | 3,206M | -3.1% | | aotdispatcher_partitioner_cpu2 | 1,944M | 1,865M | -4.1% | | aotdispatcher_partitioner_cpu | 8,340M | 8,062M | -3.3% | | sum_floordiv_regression | 3,700M | 3,591M | -3.0% | | aotdispatcher_training_nosubclass_cpu | 3,242M | 3,168M | -2.3% | | update_hint_regression | 1,674M | 1,641M | -2.0% | | symint_sum_loop | 4,682M | 4,590M | -2.0% | | add_loop_inductor_gpu | 26,418M | 26,031M | -1.5% | | basic_NestedModule_eager | 6,171M | 6,084M | -1.4% | | add_loop_inductor | 29,736M | 29,342M | -1.3% | Pull Request resolved: #170973 Approved by: https://github.com/oulgen ghstack dependencies: #170946, #170962

wdvr · 2026-03-10T00:13:45Z

@pytorchmergebot revert -m "reverting as part of the #170962 stack" -c ghfirst

pytorchmergebot · 2026-03-10T00:16:39Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2026-03-10T00:16:45Z

Reverting PR 170946 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit fa27d4f89f4d52bceabdfb18a3acbff4c96362b1 returned non-zero exit code 1

Auto-merging test/fx/test_graph_pickler.py
Auto-merging torch/_C/__init__.pyi.in
Auto-merging torch/_inductor/fx_passes/joint_graph.py
Auto-merging torch/fx/node.py
CONFLICT (content): Merge conflict in torch/fx/node.py
error: could not revert fa27d4f89f4... [fx] Move the rest of torch.fx.Node to C++ (#170946)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

This reverts commit fa27d4f.

## Summary Reverts #170946 This reverts commit fa27d4f. The two stacked PRs (#170962 and #170973) have already been reverted on main: - `0a06050b` Revert "[fx] Move _FindNodesLookupTable and _node_list to C++ (#170973)" - `2ee3377b` Revert "[fx] Move _Namespace to C++ (#170962)" - `fb60dd58` Revert "[fx] Fix quadratic name generation in _NamespaceBase.create_name (#176515)" The only merge conflict was in `torch/fx/node.py` due to a type annotation modernization PR (#176308, `Optional[X]` → `X | None`). The conflict was resolved by keeping the modern annotation style while restoring the original Python implementation. ## Test plan CI Pull Request resolved: #177047 Approved by: https://github.com/huydhn

This reverts commit 68bcdcb. Reverted #177047 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](#177047 (comment)))

…170946)" (pytorch#177047)" This reverts commit 4bc9d7f.

Reland of #177047 which was auto-reverted due to lint failures. This reverts commit 4bc9d7f ("Reapply "[fx] Move the rest of torch.fx.Node to C++ (#170946)" (#177047)"). Authored with Claude. Pull Request resolved: #177183 Approved by: https://github.com/huydhn

ghstack-source-id: 10cdf12 Pull-Request: pytorch/pytorch#170946

Update

b8f7387

[ghstack-poisoned]

pytorch-bot bot added the release notes: fx release notes category label Dec 20, 2025

jansel added a commit that referenced this pull request Dec 20, 2025

[fx] Move the rest of torch.fx.Node to C++

5b76eec

ghstack-source-id: 27ec22f Pull-Request: #170946

jansel mentioned this pull request Dec 20, 2025

Fix local lint error #170945

Closed

facebook-github-bot added the fx label Dec 20, 2025

Update

d34afad

[ghstack-poisoned]

jansel added a commit that referenced this pull request Dec 20, 2025

[fx] Move the rest of torch.fx.Node to C++

ce8a6f5

ghstack-source-id: b137425 Pull-Request: #170946

jansel added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Dec 20, 2025

Update

c7276a5

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels Dec 20, 2025

jansel mentioned this pull request Dec 20, 2025

[fx] Move _Namespace to C++ #170962

Open

jansel added the skip-pr-sanity-checks label Dec 20, 2025

Update

f8fa63c

[ghstack-poisoned]

jansel mentioned this pull request Dec 21, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++ #170973

Open

Update

68defec

[ghstack-poisoned]

jansel requested a review from williamwen42 December 24, 2025 19:26

jansel marked this pull request as ready for review December 24, 2025 19:27

jansel requested a review from anijain2305 December 24, 2025 19:27

Update

fc88316

[ghstack-poisoned]

oulgen approved these changes Dec 24, 2025

View reviewed changes

Update

7c07fcd

[ghstack-poisoned]

pytorchmergebot closed this in 84db132 Dec 25, 2025

pytorchmergebot added the Merged label Dec 25, 2025

pytorchmergebot pushed a commit that referenced this pull request Dec 25, 2025

[fx] Move _Namespace to C++ (#170962)

a50d65a

Pull Request resolved: #170962 Approved by: https://github.com/oulgen ghstack dependencies: #170945, #170946

pytorchmergebot reopened this Dec 26, 2025

krastogi-in pushed a commit to krastogi-in/pytorch that referenced this pull request Jan 9, 2026

[fx] Move the rest of torch.fx.Node to C++ (pytorch#170946)

477f27c

Pull Request resolved: pytorch#170946 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170945

krastogi-in pushed a commit to krastogi-in/pytorch that referenced this pull request Jan 9, 2026

[fx] Move _Namespace to C++ (pytorch#170962)

7f6a00e

Pull Request resolved: pytorch#170962 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170945, pytorch#170946

SergeyTyshkevich pushed a commit to SergeyTyshkevich/chart2 that referenced this pull request Jan 19, 2026

[fx] Move the rest of torch.fx.Node to C++

5dbc873

ghstack-source-id: 7e65678 Pull-Request: pytorch/pytorch#170946

github-actions bot added the Stale label Feb 24, 2026

Update

255ac56

[ghstack-poisoned]

jansel removed the Stale label Feb 24, 2026

jansel added 3 commits February 24, 2026 15:34

Update

9de8a29

[ghstack-poisoned]

Update

c95c4c6

[ghstack-poisoned]

Update

feb6b74

[ghstack-poisoned]

pytorchmergebot closed this in fa27d4f Feb 26, 2026

pytorchmergebot pushed a commit that referenced this pull request Feb 26, 2026

[fx] Move _Namespace to C++ (#170962)

5c68844

Pull Request resolved: #170962 Approved by: https://github.com/oulgen ghstack dependencies: #170946

Lucaskabela mentioned this pull request Feb 27, 2026

Fix type errors on main #176012

Closed

wdvr added a commit to wdvr/pytorch that referenced this pull request Mar 10, 2026

Revert "[fx] Move the rest of torch.fx.Node to C++ (pytorch#170946)"

7dc74f6

This reverts commit fa27d4f.

wdvr mentioned this pull request Mar 10, 2026

Revert "[fx] Move the rest of torch.fx.Node to C++ (#170946)" #177047

Closed

wdvr mentioned this pull request Mar 11, 2026

Revert "[fx] Move the rest of torch.fx.Node to C++ (#170946)" #177183

Closed

wdvr added a commit to wdvr/pytorch that referenced this pull request Mar 11, 2026

Revert "Reapply "[fx] Move the rest of torch.fx.Node to C++ (pytorch#…

6fcaf74

…170946)" (pytorch#177047)" This reverts commit 4bc9d7f.

sandy-gags pushed a commit to sandy-gags/pytorch that referenced this pull request Mar 12, 2026

[fx] Move the rest of torch.fx.Node to C++

e5512de

ghstack-source-id: 10cdf12 Pull-Request: pytorch/pytorch#170946

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fx] Move the rest of torch.fx.Node to C++#170946

[fx] Move the rest of torch.fx.Node to C++#170946
jansel wants to merge 11 commits intogh/jansel/586/basefrom
gh/jansel/586/head

jansel commented Dec 20, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

oulgen left a comment

Uh oh!

jansel commented Dec 24, 2025

Uh oh!

pytorchmergebot commented Dec 25, 2025

Uh oh!

pytorchmergebot commented Dec 25, 2025

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

wdvr commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jansel commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170946

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

oulgen left a comment

Choose a reason for hiding this comment

Uh oh!

jansel commented Dec 24, 2025

Uh oh!

pytorchmergebot commented Dec 25, 2025

Uh oh!

pytorchmergebot commented Dec 25, 2025

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

wdvr commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Reverting PR 170946 failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jansel commented Dec 20, 2025 •

edited

Loading

pytorch-bot bot commented Dec 20, 2025 •

edited

Loading