Skip to content

Revert "[fx] Move the rest of torch.fx.Node to C++ (#170946)"#177183

Closed
wdvr wants to merge 2 commits intopytorch:mainfrom
wdvr:revert-170946-v2
Closed

Revert "[fx] Move the rest of torch.fx.Node to C++ (#170946)"#177183
wdvr wants to merge 2 commits intopytorch:mainfrom
wdvr:revert-170946-v2

Conversation

@wdvr
Copy link
Contributor

@wdvr wdvr commented Mar 11, 2026 •
edited by pytorch-bot bot
Loading

Reland of #177047 which was auto-reverted due to lint failures.

This reverts commit 4bc9d7f ("Reapply "[fx] Move the rest of torch.fx.Node to C++ (#170946)" (#177047)").

cc @albanD @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @wdvr

Authored with Claude.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 11, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177183

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 80 Pending, 4 Unrelated Failures

As of commit d4a8e61 with merge base a162f2a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests module: inductor release notes: fx release notes category labels Mar 11, 2026
huydhn
huydhn approved these changes Mar 11, 2026
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped!

@huydhn huydhn added skip-pr-sanity-checks suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Mar 11, 2026
@huydhn
Copy link
Contributor

huydhn commented Mar 11, 2026

Please check that lint jobs have passed before landing this revert

@wdvr
Fix RUFF UP045 lint violations in torch/fx/node.py
d4a8e61 
Use `X | None` instead of `Optional[X]` for type annotations to
satisfy the UP045 lint rule that was added after the original code
was written.
@wdvr wdvr marked this pull request as ready for review March 12, 2026 18:07
@wdvr
Copy link
Contributor Author

wdvr commented Mar 12, 2026

@pytorchmergebot -f "lint passing after rebase"

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 12, 2026

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'lint passing after rebase' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'lint', 'fix-lint', 'apply-lint', 'cherry-pick')

usage: @pytorchbot [-h]
                   
                   {merge,revert,rebase,label,drci,lint,fix-lint,apply-lint,cherry-pick}
                   ...

Try @pytorchbot --help for more info.

@wdvr
Copy link
Contributor Author

wdvr commented Mar 12, 2026

@pytorchmergebot merge -f "lint passing after rebase"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 12, 2026

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests Merged module: inductor release notes: fx release notes category skip-pr-sanity-checks suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wdvr @huydhn @pytorchmergebot