[fx] Move _FindNodesLookupTable and _node_list to C++ by jansel · Pull Request #170973 · pytorch/pytorch

jansel · 2025-12-21T06:34:21Z

Stack from ghstack (oldest at bottom):

Cumulative Changes (PR 170946 → PR 170973)

Benchmark	PR 170946	PR 170973	Delta
add_loop_eager	3,308M	3,206M	-3.1%
aotdispatcher_partitioner_cpu2	1,944M	1,865M	-4.1%
aotdispatcher_partitioner_cpu	8,340M	8,062M	-3.3%
sum_floordiv_regression	3,700M	3,591M	-3.0%
aotdispatcher_training_nosubclass_cpu	3,242M	3,168M	-2.3%
update_hint_regression	1,674M	1,641M	-2.0%
symint_sum_loop	4,682M	4,590M	-2.0%
add_loop_inductor_gpu	26,418M	26,031M	-1.5%
basic_NestedModule_eager	6,171M	6,084M	-1.4%
add_loop_inductor	29,736M	29,342M	-1.3%

cc @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

[ghstack-poisoned]

pytorch-bot · 2025-12-21T06:34:26Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170973

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 62ce137 with merge base e81980e ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
sam
pull / linux-jammy-py3.14t-clang15 / test (crossref, 1, 2, lf.linux.2xlarge) (gh) (similar failure)
test/test_serialization.py::TestSerialization::test_serialization_4gb_file

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: a0ff7de Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 815ad4c Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 03152e0 Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: dcf1d45 Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 65a0082 Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 03baec2 Pull-Request: #170973

jansel · 2025-12-25T05:46:25Z

@pytorchbot rebase

github-actions · 2026-02-23T10:48:21Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[ghstack-poisoned]

ghstack-source-id: 5159bcc Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 63afd45 Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 0e0ebff Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 6a60266 Pull-Request: #170973

[ghstack-poisoned]

ghstack-source-id: 5c2cd8a Pull-Request: #170973

jansel · 2026-02-26T17:44:48Z

@pytorchbot merge

pytorchmergebot · 2026-02-26T17:47:10Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

facebook-github-bot · 2026-03-01T19:18:33Z

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

pytorchmergebot · 2026-03-01T19:20:39Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit 6a78d3d. Reverted #170973 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#170973 (comment)))

pytorchmergebot · 2026-03-01T19:20:47Z

@jansel your PR has been successfully reverted.

## Summary Reverts #170946 This reverts commit fa27d4f. The two stacked PRs (#170962 and #170973) have already been reverted on main: - `0a06050b` Revert "[fx] Move _FindNodesLookupTable and _node_list to C++ (#170973)" - `2ee3377b` Revert "[fx] Move _Namespace to C++ (#170962)" - `fb60dd58` Revert "[fx] Fix quadratic name generation in _NamespaceBase.create_name (#176515)" The only merge conflict was in `torch/fx/node.py` due to a type annotation modernization PR (#176308, `Optional[X]` → `X | None`). The conflict was resolved by keeping the modern annotation style while restoring the original Python implementation. ## Test plan CI Pull Request resolved: #177047 Approved by: https://github.com/huydhn

Update

87c69d3

[ghstack-poisoned]

pytorch-bot bot added the release notes: fx release notes category label Dec 21, 2025

facebook-github-bot added the fx label Dec 21, 2025

jansel added a commit that referenced this pull request Dec 21, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++

252d269

ghstack-source-id: a0ff7de Pull-Request: #170973

This was referenced Dec 20, 2025

Fix local lint error #170945

Closed

[fx] Move the rest of torch.fx.Node to C++ #170946

Closed

[fx] Move _Namespace to C++ #170962

Open

jansel marked this pull request as draft December 21, 2025 06:34

jansel added a commit that referenced this pull request Dec 21, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++

b0315cf

ghstack-source-id: a0ff7de Pull-Request: #170973

jansel added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Dec 21, 2025

Update

fb034f9

[ghstack-poisoned]

jansel added a commit that referenced this pull request Dec 21, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++

7ecd6f6

ghstack-source-id: 815ad4c Pull-Request: #170973

Update

a93938c

[ghstack-poisoned]

jansel added a commit that referenced this pull request Dec 21, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++

4cafbe7

ghstack-source-id: 03152e0 Pull-Request: #170973

Update

a16dd92

[ghstack-poisoned]

jansel added a commit that referenced this pull request Dec 21, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++

1b25bd2

ghstack-source-id: dcf1d45 Pull-Request: #170973

jansel added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Dec 22, 2025

Update

3880166

[ghstack-poisoned]

jansel added a commit that referenced this pull request Dec 22, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++

c44f1a2

ghstack-source-id: 65a0082 Pull-Request: #170973

jansel requested review from anijain2305 and williamwen42 December 24, 2025 19:24

jansel marked this pull request as ready for review December 24, 2025 19:25

jansel requested a review from oulgen December 24, 2025 19:29

Update

de8a020

[ghstack-poisoned]

jansel added a commit that referenced this pull request Dec 24, 2025

[fx] Move _FindNodesLookupTable and _node_list to C++

d29f13b

ghstack-source-id: 03baec2 Pull-Request: #170973

pytorch-bot bot added the module: dynamo label Dec 24, 2025

oulgen approved these changes Dec 24, 2025

View reviewed changes

github-actions bot added the Stale label Feb 23, 2026

Update

098bd80

[ghstack-poisoned]

jansel added a commit that referenced this pull request Feb 24, 2026

[fx] Move _FindNodesLookupTable and _node_list to C++

d9cde49

ghstack-source-id: 5159bcc Pull-Request: #170973

Update

244e880

[ghstack-poisoned]

jansel added a commit that referenced this pull request Feb 24, 2026

[fx] Move _FindNodesLookupTable and _node_list to C++

71695b8

ghstack-source-id: 63afd45 Pull-Request: #170973

jansel removed the Stale label Feb 25, 2026

Update

91ec550

[ghstack-poisoned]

jansel added a commit that referenced this pull request Feb 25, 2026

[fx] Move _FindNodesLookupTable and _node_list to C++

0e5ac72

ghstack-source-id: 0e0ebff Pull-Request: #170973

Update

1cdf5c4

[ghstack-poisoned]

jansel added a commit that referenced this pull request Feb 26, 2026

[fx] Move _FindNodesLookupTable and _node_list to C++

6377870

ghstack-source-id: 6a60266 Pull-Request: #170973

Update

62ce137

[ghstack-poisoned]

jansel added a commit that referenced this pull request Feb 26, 2026

[fx] Move _FindNodesLookupTable and _node_list to C++

675f4a0

ghstack-source-id: 5c2cd8a Pull-Request: #170973

pytorchmergebot added the merging label Feb 26, 2026

pytorchmergebot added the Merged label Feb 26, 2026

pytorchmergebot closed this in 6a78d3d Feb 26, 2026

pytorchmergebot removed the merging label Feb 26, 2026

Lucaskabela mentioned this pull request Feb 27, 2026

Fix type errors on main #176012

Closed

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Mar 1, 2026

pytorchmergebot reopened this Mar 1, 2026

wdvr mentioned this pull request Mar 10, 2026

Revert "[fx] Move the rest of torch.fx.Node to C++ (#170946)" #177047

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fx] Move _FindNodesLookupTable and _node_list to C++#170973

[fx] Move _FindNodesLookupTable and _node_list to C++#170973
jansel wants to merge 12 commits intogh/jansel/588/basefrom
gh/jansel/588/head

jansel commented Dec 21, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Dec 21, 2025 •

edited

Loading

Uh oh!

jansel commented Dec 25, 2025

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

jansel commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

facebook-github-bot commented Mar 1, 2026

Uh oh!

pytorchmergebot commented Mar 1, 2026

Uh oh!

pytorchmergebot commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jansel commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170973

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

jansel commented Dec 25, 2025

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

jansel commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Merge started

Uh oh!

facebook-github-bot commented Mar 1, 2026

Uh oh!

pytorchmergebot commented Mar 1, 2026

Uh oh!

pytorchmergebot commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jansel commented Dec 21, 2025 •

edited

Loading

pytorch-bot bot commented Dec 21, 2025 •

edited

Loading