[BE] Apply pep604 to `torch/_dynamo` by Lucaskabela · Pull Request #175555 · pytorch/pytorch

Lucaskabela · 2026-02-23T19:18:44Z

Since python>=3.10 is defined in the pyproject.toml, we can enable pep604 (in python >=3.10)

Why?

Fewer imports making code simpler
Standardization - prior to this change, we could have Optional or the | None intermixed in the codebase
Future proof for direction of python type system

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @jataylo @xmfan @aditvenk

pytorch-bot · 2026-02-23T19:18:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175555

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 80d7f51 with merge base 85cf583 ():

NEW FAILURES - The following jobs have failed:

trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx950.1) (gh)
test/test_binary_ufuncs.py::TestBinaryUfuncsCUDA::test_fmod_remainder_by_zero_integral_cuda_uint8
trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx950.4) (gh)
'Test'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Lucaskabela · 2026-02-24T21:53:32Z

@pytorchmergebot merge

pytorchmergebot · 2026-02-24T21:56:56Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Since python>=3.10 is defined in the pyproject.toml, we can enable [pep604](https://peps.python.org/pep-0604/) (in python >=3.10) Why? * Fewer imports making code simpler * Standardization - prior to this change, we could have Optional or the | None intermixed in the codebase * Future proof for direction of python type system We apply this to `torch/_functorch` in this PR See #175555 for another application Pull Request resolved: #175659 Approved by: https://github.com/aorenste

Lucaskabela · 2026-02-25T17:32:15Z

@pytorchbot merge

pytorchmergebot · 2026-02-25T17:34:24Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-25T19:41:53Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch rebase origin/main returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/_dynamo/debug_utils.py
Auto-merging torch/_dynamo/decorators.py
Auto-merging torch/_dynamo/exc.py
Auto-merging torch/_dynamo/functional_export.py
CONFLICT (content): Merge conflict in torch/_dynamo/functional_export.py
Auto-merging torch/_dynamo/guards.py
Auto-merging torch/_dynamo/variables/builder.py
Auto-merging torch/_dynamo/variables/script_object.py
Auto-merging torch/_dynamo/variables/tensor.py
Auto-merging torch/_dynamo/variables/torch.py
error: could not apply 95e5dd52950... [BE] Apply pep604 to `torch/_dynamo` (#175555)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 95e5dd52950... # [BE] Apply pep604 to `torch/_dynamo` (#175555)

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-02-25T20:47:20Z

@pytorchmergebot merge

pytorchmergebot · 2026-02-25T20:50:15Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Lucaskabela · 2026-02-28T00:44:39Z

@pytorchmergebot merge

pytorchmergebot · 2026-02-28T00:46:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-28T03:00:42Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx950.1)

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-02-28T03:19:41Z

@pytorchmergebot merge -I

pytorch-bot · 2026-02-28T03:19:44Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -I

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

Lucaskabela · 2026-02-28T03:19:55Z

@pytorchmergebot merge -i

pytorchmergebot · 2026-02-28T03:22:14Z

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx950.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-28T06:51:39Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx950.4)

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-03-01T03:14:10Z

@pytorchmergebot merge -i

pytorchmergebot · 2026-03-01T03:16:28Z

Merge started

Your change will be merged while ignoring the following 2 checks: trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx950.1), trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx950.4)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: Since python>=3.10 is defined in the pyproject.toml, we can enable [pep604](https://peps.python.org/pep-0604/) (in python >=3.10) Why? 1) Fewer imports making code simpler 2) Standardization - prior to this change, we could have `Optional` or the `| None` intermixed in the codebase 3) Future proof for direction of python type system X-link: pytorch/pytorch#175555 Approved by: https://github.com/aorenste, https://github.com/zou3519 Reviewed By: jeanschmidt Differential Revision: D94811748 fbshipit-source-id: ca8ca84d7872b78f3d27e60d7fb8402eeb5c6c54

Since python>=3.10 is defined in the pyproject.toml, we can enable [pep604](https://peps.python.org/pep-0604/) (in python >=3.10) Why? * Fewer imports making code simpler * Standardization - prior to this change, we could have Optional or the | None intermixed in the codebase * Future proof for direction of python type system We apply this to `torch/_functorch` in this PR See pytorch#175555 for another application Pull Request resolved: pytorch#175659 Approved by: https://github.com/aorenste

Since python>=3.10 is defined in the pyproject.toml, we can enable [pep604](https://peps.python.org/pep-0604/) (in python >=3.10) Why? 1) Fewer imports making code simpler 2) Standardization - prior to this change, we could have `Optional` or the `| None` intermixed in the codebase 3) Future proof for direction of python type system Pull Request resolved: pytorch#175555 Approved by: https://github.com/aorenste, https://github.com/zou3519

…orch#175676)" This reverts commit fa1ac62. Reverted pytorch#175676 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see [D94699653](https://www.internalfb.com/diff/D94699653) ([comment](pytorch#175676 (comment)))

This reverts commit 2958025. Reverted pytorch#175765 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94699609 ([comment](pytorch#175765 (comment)))

pytorch#174751)" This reverts commit 1b9046a. Reverted pytorch#174751 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94699526 ([comment](pytorch#174933 (comment)))

)" This reverts commit ba59c42. Reverted pytorch#174933 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94699526 ([comment](pytorch#174933 (comment)))

…h/_* (pytorch#175870)" This reverts commit 4802e2a. Reverted pytorch#175870 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94699362 ([comment](pytorch#175870 (comment)))

This reverts commit 45c625b. Reverted pytorch#175510 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94598146 ([comment](pytorch#175510 (comment)))

This reverts commit 205e399. Reverted pytorch#175555 on behalf of https://github.com/jeanschmidt due to see D94598146 ([comment](pytorch#175555 (comment)))

Since python>=3.10 is defined in the pyproject.toml, we can enable [pep604](https://peps.python.org/pep-0604/) (in python >=3.10) Why? 1) Fewer imports making code simpler 2) Standardization - prior to this change, we could have `Optional` or the `| None` intermixed in the codebase 3) Future proof for direction of python type system Pull Request resolved: pytorch#175555 Approved by: https://github.com/aorenste, https://github.com/zou3519

pytorch-bot Bot added ciflow/inductor module: compiled autograd compiled_autograd module: dynamo release notes: inductor (aoti) labels Feb 23, 2026

Lucaskabela marked this pull request as ready for review February 23, 2026 19:23

Lucaskabela requested review from aorenste and zou3519 as code owners February 23, 2026 19:23

Lucaskabela requested a review from anijain2305 February 23, 2026 19:24

Lucaskabela force-pushed the lucaskabela/pep_604_for_dynamo branch from 20eb655 to 37a3d65 Compare February 23, 2026 19:49

Lucaskabela mentioned this pull request Feb 24, 2026

[BE] Apply pep604 to torch/_functorch #175659

Closed

aorenste approved these changes Feb 24, 2026

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 24, 2026

pytorchmergebot added the merging label Feb 24, 2026

zou3519 approved these changes Feb 25, 2026

View reviewed changes

pytorchmergebot removed the merging label Feb 25, 2026

Lucaskabela added 2 commits February 25, 2026 12:45

Add all torch/_dynamo files with pep604 applied

269f81b

Update after rebase

80d7f51

Lucaskabela force-pushed the lucaskabela/pep_604_for_dynamo branch from 508a03a to 80d7f51 Compare February 25, 2026 20:46

pytorchmergebot added the merging label Feb 25, 2026

pytorchmergebot added the Merged label Feb 26, 2026

pytorchmergebot added the merging label Feb 28, 2026

pytorchmergebot removed the merging label Feb 28, 2026

pytorchmergebot added the merging label Feb 28, 2026

pytorchmergebot removed the merging label Feb 28, 2026

pytorchmergebot added the merging label Mar 1, 2026

pytorchmergebot closed this in 7185258 Mar 1, 2026

pytorchmergebot removed the merging label Mar 1, 2026

github-actions Bot deleted the lucaskabela/pep_604_for_dynamo branch April 1, 2026 02:23

Conversation

Lucaskabela commented Feb 23, 2026 • edited by pytorch-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175555

❌ 2 New Failures

Uh oh!

Lucaskabela commented Feb 24, 2026

Uh oh!

pytorchmergebot commented Feb 24, 2026

Merge started

Uh oh!

Lucaskabela commented Feb 25, 2026

Uh oh!

pytorchmergebot commented Feb 25, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 25, 2026

Merge failed

Uh oh!

Lucaskabela commented Feb 25, 2026

Uh oh!

pytorchmergebot commented Feb 25, 2026

Merge started

Uh oh!

Lucaskabela commented Feb 28, 2026

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge failed

Uh oh!

Lucaskabela commented Feb 28, 2026

Uh oh!

pytorch-bot Bot commented Feb 28, 2026

Uh oh!

Lucaskabela commented Feb 28, 2026

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge failed

Uh oh!

Lucaskabela commented Mar 1, 2026

Uh oh!

pytorchmergebot commented Mar 1, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Lucaskabela commented Feb 23, 2026 •

edited by pytorch-bot Bot

Loading

pytorch-bot Bot commented Feb 23, 2026 •

edited

Loading