[BE][inductor] Apply PEP 604 type annotations (part 2/3) by Lucaskabela · Pull Request #175676 · pytorch/pytorch

Lucaskabela · 2026-02-24T23:05:36Z

Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from codegen/nv_universal_gemm/ through fx_passes/joint_graph.

Split branch with Claude.

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175676

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Unrelated Failures

As of commit 95d982f with merge base 319af8c ():

NEW FAILURES - The following jobs have failed:

trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
test/distributed/_composable/fsdp/test_fully_shard_extensions.py::TestFullyShardAllGatherExtensionsMultiThread::test_all_gather_extensions_end_to_end
trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx950.4) (gh)
test/distributed/_composable/fsdp/test_fully_shard_extensions.py::TestFullyShardAllGatherExtensionsMultiThread::test_all_gather_extensions_end_to_end

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (similar failure)
test/dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_assume_32_bit_indexing_dynamic_shapes
trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (similar failure)
test/dynamo/test_misc.py::MiscTests::test_assume_32_bit_indexing

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx950.1) (gh) (trunk failure)
test/dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_assume_32_bit_indexing_dynamic_shapes
trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx950.1) (gh) (trunk failure)
test/dynamo/test_misc.py::MiscTests::test_assume_32_bit_indexing

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot · 2026-02-24T23:05:43Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Lucaskabela · 2026-02-24T23:06:16Z

Quick note for reviewers:

Usages of "Optional" and "Union" may still exist in some files after this change - we need to import future annotaiton to remove those. That will be handled in a later PR as this PR is already quite large
We used ruff for this PR - claude was used to split a branch with all inductor changes into these 3 PRs which are more manageable

Lucaskabela · 2026-02-24T23:06:24Z

@pytorchbot label "topic: not user facing"

Lucaskabela · 2026-02-26T18:16:27Z

@pytorchbot merge

pytorchmergebot · 2026-02-26T18:19:46Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from fx_passes/misc_patterns through wrapper_benchmark. Split with Claude. See also #175675 and #175676 Pull Request resolved: #175677 Approved by: https://github.com/v0i0

albanD · 2026-02-26T22:08:30Z

@pytorchbot revert -m "Breaks lint in trunk" -c nosignal

pytorchmergebot · 2026-02-26T22:10:42Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

…5676)" This reverts commit 282eca2. Reverted #175676 on behalf of https://github.com/albanD due to Breaks lint in trunk ([comment](#175676 (comment)))

pytorchmergebot · 2026-02-26T22:10:48Z

@Lucaskabela your PR has been successfully reverted.

pytorchmergebot · 2026-02-27T23:13:01Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

…5676)" This reverts commit fa1ac62. Reverted #175676 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert #175555 - see [D94699653](https://www.internalfb.com/diff/D94699653) ([comment](#175676 (comment)))

pytorchmergebot · 2026-02-27T23:13:07Z

@Lucaskabela your PR has been successfully reverted.

Lucaskabela · 2026-02-28T00:44:52Z

@pytorchmergebot merge

pytorchmergebot · 2026-02-28T00:48:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-28T00:48:55Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-02-28T01:01:05Z

@pytorchmergebot merge -i

pytorchmergebot · 2026-02-28T01:03:21Z

Merge started

Your change will be merged while ignoring the following 5 checks: trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx950.1), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx950.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-28T01:53:38Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx950.4)

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-02-28T03:20:17Z

@pytorchmergebot merge -i

pytorchmergebot · 2026-02-28T03:22:49Z

Merge started

Your change will be merged while ignoring the following 6 checks: trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx950.4), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx950.1), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx950.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from fx_passes/misc_patterns through wrapper_benchmark. Split with Claude. See also #175675 and #175676 Pull Request resolved: #175677 Approved by: https://github.com/v0i0

) Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from fx_passes/misc_patterns through wrapper_benchmark. Split with Claude. See also pytorch#175675 and pytorch#175676 Pull Request resolved: pytorch#175677 Approved by: https://github.com/v0i0

) Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from codegen/nv_universal_gemm/ through fx_passes/joint_graph. Split branch with Claude. See also pytorch#175675 Pull Request resolved: pytorch#175676 Approved by: https://github.com/v0i0

…orch#175676)" This reverts commit 282eca2. Reverted pytorch#175676 on behalf of https://github.com/albanD due to Breaks lint in trunk ([comment](pytorch#175676 (comment)))

) Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from codegen/nv_universal_gemm/ through fx_passes/joint_graph. Split branch with Claude. See also pytorch#175675 Pull Request resolved: pytorch#175676 Approved by: https://github.com/v0i0, https://github.com/fxdawnn

…orch#175676)" This reverts commit fa1ac62. Reverted pytorch#175676 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see [D94699653](https://www.internalfb.com/diff/D94699653) ([comment](pytorch#175676 (comment)))

) Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from codegen/nv_universal_gemm/ through fx_passes/joint_graph. Split branch with Claude. See also pytorch#175675 Pull Request resolved: pytorch#175676 Approved by: https://github.com/v0i0, https://github.com/fxdawnn

) Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from fx_passes/misc_patterns through wrapper_benchmark. Split with Claude. See also pytorch#175675 and pytorch#175676 Pull Request resolved: pytorch#175677 Approved by: https://github.com/v0i0

pytorch-bot Bot added ciflow/inductor ciflow/inductor-pallas module: inductor labels Feb 24, 2026

Lucaskabela requested review from drisspg, eellison and karthickai February 24, 2026 23:05

pytorch-bot Bot added the topic: not user facing topic category label Feb 24, 2026

Lucaskabela mentioned this pull request Feb 24, 2026

[BE][inductor] Apply PEP 604 type annotations (part 3/3) #175677

Closed

Lucaskabela force-pushed the pep604-inductor-part2 branch from 92c856a to eae4ec1 Compare February 25, 2026 17:55

v0i0 approved these changes Feb 26, 2026

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 26, 2026

pytorchmergebot added the merging label Feb 26, 2026

pytorchmergebot added the Merged label Feb 26, 2026

pytorchmergebot closed this in 282eca2 Feb 26, 2026

pytorchmergebot removed the merging label Feb 26, 2026

claude Bot mentioned this pull request Feb 26, 2026

[Dynamo] Fix not compiling child modules after forward pre hook graph break #174435

Closed

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Feb 26, 2026

pytorchmergebot reopened this Feb 27, 2026

pytorchmergebot added the merging label Feb 28, 2026

pytorchmergebot removed the merging label Feb 28, 2026

pytorchmergebot added the merging label Feb 28, 2026

pytorchmergebot removed the merging label Feb 28, 2026

pytorchmergebot added the merging label Feb 28, 2026

pytorchmergebot closed this in 08358b8 Feb 28, 2026

pytorchmergebot removed the merging label Feb 28, 2026

github-actions Bot deleted the pep604-inductor-part2 branch March 31, 2026 02:23

Conversation

Lucaskabela commented Feb 24, 2026 • edited by pytorch-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175676

❌ 2 New Failures, 4 Unrelated Failures

Uh oh!

pytorch-bot Bot commented Feb 24, 2026

This PR needs a release notes: label

Uh oh!

Lucaskabela commented Feb 24, 2026

Uh oh!

Lucaskabela commented Feb 24, 2026

Uh oh!

Lucaskabela commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Merge started

Uh oh!

albanD commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 27, 2026

Uh oh!

pytorchmergebot commented Feb 27, 2026

Uh oh!

Lucaskabela commented Feb 28, 2026

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge failed

Uh oh!

Lucaskabela commented Feb 28, 2026

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge failed

Uh oh!

Lucaskabela commented Feb 28, 2026

Uh oh!

pytorchmergebot commented Feb 28, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Lucaskabela commented Feb 24, 2026 •

edited by pytorch-bot Bot

Loading

pytorch-bot Bot commented Feb 24, 2026 •

edited

Loading

This PR needs a `release notes:` label