[BE][inductor] Apply PEP 604 type annotations (part 3/3) by Lucaskabela · Pull Request #175677 · pytorch/pytorch

Lucaskabela · 2026-02-24T23:07:20Z

Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from fx_passes/misc_patterns through wrapper_benchmark.

Split with Claude.

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175677

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 4 Unrelated Failures

As of commit d924e21 with merge base 4416f11 ():

CANCELLED JOB - The following job was cancelled. Please retry:

Limited CI on H100 / linux-jammy-cuda12_8-py3_10-gcc11-sm90-FA3-ABI-stable-test / test (gh)
##[error]The operation was canceled.

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

rocm-mi300 / linux-noble-rocm-py3.12-mi300 / test (default, 1, 6, linux.rocm.gpu.gfx942.1) (gh) (similar failure)
test/profiler/test_profiler.py::TestProfilerCUDA::test_mem_leak
rocm-mi300 / linux-noble-rocm-py3.12-mi300 / test (default, 5, 6, linux.rocm.gpu.gfx942.1) (gh) (similar failure)
test/dynamo/test_structured_trace.py::StructuredTraceTest::test_ddp_graphs

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / inductor-test / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
drq

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable) (gh) (#174929)
detectron2_maskrcnn_r_50_fpn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot · 2026-02-24T23:07:27Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Lucaskabela · 2026-02-24T23:07:34Z

Quick note for reviewers:

Usages of "Optional" and "Union" may still exist in some files after this change - we need to import future annotaiton to remove those. That will be handled in a later PR as this PR is already quite large
We used ruff for this PR - claude was used to split a branch with all inductor changes into these 3 PRs which are more manageable

Lucaskabela · 2026-02-24T23:07:39Z

@pytorchbot label "topic: not user facing"

Lucaskabela · 2026-02-26T18:16:43Z

@pytorchbot merge -i

pytorchmergebot · 2026-02-26T18:19:57Z

Merge started

Your change will be merged while ignoring the following 2 checks: Limited CI on H100 / linux-jammy-cuda12_8-py3_10-gcc11-sm90-FA3-ABI-stable-test / test, rocm-mi300 / linux-noble-rocm-py3.12-mi300 / test (default, 2, 6, linux.rocm.gpu.gfx942.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-auto-revert · 2026-02-26T21:05:35Z

@pytorchbot revert -m "Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable" -c autorevert

This PR is attributed to have caused regression in:

Lint: lintrunner-pyrefly-all / linux-job (hud)

Please investigate and fix the issues.
@claude Can you please read this revert comment, follow the links and read the errors, to then give a brief diagnostics on the cause of the error? If you judge the error to be legitimate reason for a revert, please provide brief guidance on how the author could fix it.

claude · 2026-02-26T21:06:10Z

Claude finished @pytorch-auto-revert[bot]'s task in 52s —— View job

Revert Analysis

Fetch and analyze the lintrunner-pyrefly-all error from the CI link
Diagnose the root cause
Provide guidance on how to fix the issue

Root Cause

The pyrefly linter found an unresolved Optional reference at torch/_inductor/output_code.py:473:

_original_gm: Optional[torch.fx.GraphModule] = None

The issue is that the PR converted most Optional[X] → X | None annotations but missed this one instance. The file imports from __future__ import annotations (line 23) but does not import Optional from typing (line 29 only imports Any, TYPE_CHECKING, TypeAlias).

Since the file already uses from __future__ import annotations, string annotations are deferred and not evaluated at runtime, but the pyrefly static type checker still requires all names used in type annotations to be defined in the module scope.

Verdict

✅ This is a legitimate reason for revert. The PR introduced a bug where Optional is used but not imported.

Fix

The author should change line 473 from:

_original_gm: Optional[torch.fx.GraphModule] = None

to:

_original_gm: torch.fx.GraphModule | None = None

This follows the PEP 604 style that the rest of the file (and the rest of the PR) uses, and removes the need for the Optional import entirely.

pytorchmergebot · 2026-02-26T21:07:29Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

…5677)" This reverts commit dbf26c1. Reverted #175677 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](#175677 (comment)))

Lucaskabela · 2026-02-27T00:32:30Z

@pytorchmergebot merge -i

Lucaskabela · 2026-02-27T00:33:04Z

Failures are 32bit indexing, unrelated to this PR

pytorchmergebot · 2026-02-27T00:34:49Z

Merge started

Your change will be merged while ignoring the following 6 checks: trunk / linux-jammy-rocm-py3.10 / test (default, 3, 6, linux.rocm.gpu.gfx950.1), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx950.1), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), rocm-mi300 / linux-noble-rocm-py3.12-mi300 / test (default, 5, 6, linux.rocm.gpu.gfx942.1), rocm-mi300 / linux-noble-rocm-py3.12-mi300 / test (default, 3, 6, linux.rocm.gpu.gfx942.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-27T01:37:18Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 2, 3, lf.linux.g4dn.12xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-02-27T05:11:08Z

@pytorchmergebot merge

Lucaskabela · 2026-02-27T05:11:21Z

This test also fails on #175676

pytorchmergebot · 2026-02-27T05:13:50Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-27T05:14:41Z

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (distributed, 2, 3, linux.rocm.gpu.gfx950.4), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 2, 3, lf.linux.g4dn.12xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-03-02T16:40:53Z

@pytorchmergebot merge

pytorchmergebot · 2026-03-02T16:43:59Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-03-02T17:42:09Z

Merge failed

Reason: 1 jobs have failed, first few of them are: Limited CI on H100 / linux-jammy-cuda12_8-py3_10-gcc11-sm90-FA3-ABI-stable-test / test

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2026-03-02T18:07:15Z

@pytorchmergebot merge -i

pytorchmergebot · 2026-03-02T18:09:27Z

Merge started

Your change will be merged while ignoring the following 3 checks: Limited CI on H100 / linux-jammy-cuda12_8-py3_10-gcc11-sm90-FA3-ABI-stable-test / test, inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable), inductor / inductor-test / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

) Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from fx_passes/misc_patterns through wrapper_benchmark. Split with Claude. See also pytorch#175675 and pytorch#175676 Pull Request resolved: pytorch#175677 Approved by: https://github.com/v0i0

…orch#175677)" This reverts commit dbf26c1. Reverted pytorch#175677 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](pytorch#175677 (comment)))

) Convert Union[X, Y] to X | Y and Optional[X] to X | None using ruff rules UP007 and UP045 in torch/_inductor. This covers files from fx_passes/misc_patterns through wrapper_benchmark. Split with Claude. See also pytorch#175675 and pytorch#175676 Pull Request resolved: pytorch#175677 Approved by: https://github.com/v0i0

Lucaskabela requested review from eellison, karthickai and laithsakka February 24, 2026 23:07

Lucaskabela requested a review from drisspg as a code owner February 24, 2026 23:07

pytorch-bot Bot added ciflow/b200 ciflow/h100 ciflow/inductor ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 module: inductor labels Feb 24, 2026

pytorch-bot Bot added the topic: not user facing topic category label Feb 24, 2026

Lucaskabela force-pushed the pep604-inductor-part3 branch 2 times, most recently from a0f7fec to c4cfd5b Compare February 25, 2026 21:02

v0i0 approved these changes Feb 26, 2026

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 26, 2026

pytorchmergebot added the merging label Feb 26, 2026

pytorchmergebot added the Merged label Feb 26, 2026

pytorchmergebot closed this in dbf26c1 Feb 26, 2026

pytorchmergebot removed the merging label Feb 26, 2026

albanD mentioned this pull request Feb 26, 2026

Forward fix lint #175887

Closed

pytorchmergebot added the merging label Feb 27, 2026

pytorchmergebot removed the merging label Feb 27, 2026

Lucaskabela mentioned this pull request Feb 27, 2026

[BE][inductor] Apply PEP 604 type annotations (part 2/3) #175676

Closed

pytorchmergebot added the merging label Feb 27, 2026

pytorchmergebot removed the merging label Feb 27, 2026

Merge branch 'main' into pep604-inductor-part3

d924e21

pytorchmergebot added the merging label Mar 2, 2026

pytorchmergebot removed the merging label Mar 2, 2026

pytorchmergebot added the merging label Mar 2, 2026

pytorchmergebot closed this in 9a8fa4d Mar 2, 2026

pytorchmergebot removed the merging label Mar 2, 2026

github-actions Bot deleted the pep604-inductor-part3 branch April 2, 2026 02:24

Conversation

Lucaskabela commented Feb 24, 2026 • edited by pytorch-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175677

❌ 1 Cancelled Job, 4 Unrelated Failures

Uh oh!

pytorch-bot Bot commented Feb 24, 2026

This PR needs a release notes: label

Uh oh!

Lucaskabela commented Feb 24, 2026

Uh oh!

Lucaskabela commented Feb 24, 2026

Uh oh!

Lucaskabela commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Merge started

Uh oh!

pytorch-auto-revert Bot commented Feb 26, 2026

Uh oh!

claude Bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Revert Analysis

Root Cause

Verdict

Fix

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

Lucaskabela commented Feb 27, 2026

Uh oh!

Lucaskabela commented Feb 27, 2026

Uh oh!

pytorchmergebot commented Feb 27, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 27, 2026

Merge failed

Uh oh!

Lucaskabela commented Feb 27, 2026

Uh oh!

Lucaskabela commented Feb 27, 2026

Uh oh!

pytorchmergebot commented Feb 27, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 27, 2026

Merge failed

Uh oh!

Lucaskabela commented Mar 2, 2026

Uh oh!

pytorchmergebot commented Mar 2, 2026

Merge started

Uh oh!

pytorchmergebot commented Mar 2, 2026

Merge failed

Uh oh!

Lucaskabela commented Mar 2, 2026

Uh oh!

pytorchmergebot commented Mar 2, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lucaskabela commented Feb 24, 2026 •

edited by pytorch-bot Bot

Loading

pytorch-bot Bot commented Feb 24, 2026 •

edited

Loading

This PR needs a `release notes:` label

claude Bot commented Feb 26, 2026 •

edited

Loading