Skip to content

[BE] Apply pep604 to torch/_functorch#175659

Closed
Lucaskabela wants to merge 1 commit intomainfrom
lucaskabela/pep604_torch_functorch
Closed

[BE] Apply pep604 to torch/_functorch#175659
Lucaskabela wants to merge 1 commit intomainfrom
lucaskabela/pep604_torch_functorch

Conversation

@Lucaskabela
Copy link
Copy Markdown
Contributor

@Lucaskabela Lucaskabela commented Feb 24, 2026 •
edited
Loading

Since python>=3.10 is defined in the pyproject.toml, we can enable pep604 (in python >=3.10)

Why?

  • Fewer imports making code simpler
  • Standardization - prior to this change, we could have Optional or the | None intermixed in the codebase
  • Future proof for direction of python type system

We apply this to torch/_functorch in this PR

See #175555 for another application

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 24, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175659

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 3fed6f5 with merge base 045af41 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 24, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Lucaskabela
Copy link
Copy Markdown
Contributor Author

Lucaskabela commented Feb 24, 2026

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 24, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 24, 2026

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 24, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Lucaskabela
Copy link
Copy Markdown
Contributor Author

Lucaskabela commented Feb 24, 2026

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Feb 24, 2026
@Lucaskabela
Copy link
Copy Markdown
Contributor Author

Lucaskabela commented Feb 24, 2026

@pytorchmergebot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 24, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions Bot deleted the lucaskabela/pep604_torch_functorch branch March 27, 2026 02:23
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
@Lucaskabela @EmanueleCoradin
[BE] Apply pep604 to torch/_functorch (pytorch#175659)
e3b43c0 
Since python>=3.10 is defined in the pyproject.toml, we can enable [pep604](https://peps.python.org/pep-0604/) (in python >=3.10)

Why?

* Fewer imports making code simpler
* Standardization - prior to this change, we could have Optional or the | None intermixed in the codebase
* Future proof for direction of python type system

We apply this to `torch/_functorch` in this PR

See pytorch#175555 for another application
Pull Request resolved: pytorch#175659
Approved by: https://github.com/aorenste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aorenste aorenste aorenste approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh bdhirsh is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lucaskabela @pytorchmergebot @aorenste