Skip to content

Mark DeviceMesh.__init__ as skip#175510

Closed
angelayi wants to merge 1 commit intomainfrom
angelayi/dtensor_init
Closed

Mark DeviceMesh.__init__ as skip#175510
angelayi wants to merge 1 commit intomainfrom
angelayi/dtensor_init

Conversation

@angelayi
Copy link
Copy Markdown
Contributor

@angelayi angelayi commented Feb 23, 2026

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175510

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit f6e27f2 with merge base 36bc2bf (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 23, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@angelayi angelayi force-pushed the angelayi/dtensor_init branch from 4d73f1d to cf5997a Compare February 23, 2026 17:13
@angelayi angelayi marked this pull request as ready for review February 24, 2026 23:10
@angelayi angelayi changed the title test dtensor init Mark DTensor.__init__ as skip Feb 24, 2026
Copy link
Copy Markdown
Contributor

@azahed98 azahed98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think the PR name should change to DeviceMesh instead of DTensor

Funnily enough I'm working on a related PR but for init on tensor subclasses #175397. What was the original error?

@angelayi angelayi changed the title Mark DTensor.__init__ as skip Mark DeviceMesh.__init__ as skip Feb 25, 2026
@angelayi
Copy link
Copy Markdown
Contributor Author

The repro is in the test case, but the original error was, 'DeviceMesh' object has no attribute '_mesh_dim_names'

@angelayi
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 25, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 25, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@angelayi angelayi added the topic: not user facing topic category label Feb 25, 2026
@angelayi
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Feb 26, 2026

@pytorchbot revert -m "It broke init_device_mesh_init_skip_after_graphbreak (whatever that means), see https://hud.pytorch.org/hud/pytorch/pytorch/d63f6584d251be2c9b9532f462e09399d9a29f03/1?per_page=50&name_filter=asan&mergeEphemeralLF=true for example" -c nosignal

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Feb 26, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@angelayi your PR has been successfully reverted.

@jeanschmidt
Copy link
Copy Markdown
Contributor

@pytorchbot revert -m "Need to revert in order to revert #175555 - see D94598146" -c ghfirst

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Feb 27, 2026
This reverts commit 45c625b.

Reverted #175510 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert #175555 - see D94598146 ([comment](#175510 (comment)))
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@angelayi your PR has been successfully reverted.

@angelayi
Copy link
Copy Markdown
Contributor Author

angelayi commented Mar 2, 2026

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

postmath pushed a commit to postmath/pytorch that referenced this pull request Mar 3, 2026
Unsure whats the best way to fix things but this seems to work!

Pull Request resolved: pytorch#175510
Approved by: https://github.com/azahed98
@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Mar 4, 2026

@pytorchbot revert -m 'Per our discussion with @angelayi, revert this so that #169867 can be reverted, it is breaking a bunch of internal tests' -c ghfirst

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Mar 4, 2026
This reverts commit 4416f11.

Reverted #175510 on behalf of https://github.com/huydhn due to Per our discussion with @angelayi, revert this so that #169867 can be reverted, it is breaking a bunch of internal tests ([comment](#175510 (comment)))
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@angelayi your PR has been successfully reverted.

pytorchmergebot added a commit to anatoliylitv/pytorch that referenced this pull request Mar 4, 2026
This reverts commit 4416f11.

Reverted pytorch#175510 on behalf of https://github.com/huydhn due to Per our discussion with @angelayi, revert this so that pytorch#169867 can be reverted, it is breaking a bunch of internal tests ([comment](pytorch#175510 (comment)))
@angelayi
Copy link
Copy Markdown
Contributor Author

relanded with #176661

@angelayi angelayi closed this Mar 11, 2026
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
Unsure whats the best way to fix things but this seems to work!

Pull Request resolved: pytorch#175510
Approved by: https://github.com/azahed98
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
Unsure whats the best way to fix things but this seems to work!

Pull Request resolved: pytorch#175510
Approved by: https://github.com/azahed98
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
This reverts commit 45c625b.

Reverted pytorch#175510 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94598146 ([comment](pytorch#175510 (comment)))
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
Unsure whats the best way to fix things but this seems to work!

Pull Request resolved: pytorch#175510
Approved by: https://github.com/azahed98
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
This reverts commit 4416f11.

Reverted pytorch#175510 on behalf of https://github.com/huydhn due to Per our discussion with @angelayi, revert this so that pytorch#169867 can be reverted, it is breaking a bunch of internal tests ([comment](pytorch#175510 (comment)))
@github-actions github-actions Bot deleted the angelayi/dtensor_init branch April 11, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants