Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175510
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit f6e27f2 with merge base 36bc2bf ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
4d73f1d to
cf5997a
Compare
|
The repro is in the test case, but the original error was, |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
This PR needs a
|
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "It broke init_device_mesh_init_skip_after_graphbreak (whatever that means), see https://hud.pytorch.org/hud/pytorch/pytorch/d63f6584d251be2c9b9532f462e09399d9a29f03/1?per_page=50&name_filter=asan&mergeEphemeralLF=true for example" -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 3918989. Reverted #175510 on behalf of https://github.com/malfet due to It broke init_device_mesh_init_skip_after_graphbreak (whatever that means), see https://hud.pytorch.org/hud/pytorch/pytorch/d63f6584d251be2c9b9532f462e09399d9a29f03/1?per_page=50&name_filter=asan&mergeEphemeralLF=true for example ([comment](#175510 (comment)))
|
@angelayi your PR has been successfully reverted. |
|
@pytorchbot revert -m "Need to revert in order to revert #175555 - see D94598146" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 45c625b. Reverted #175510 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert #175555 - see D94598146 ([comment](#175510 (comment)))
|
@angelayi your PR has been successfully reverted. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Unsure whats the best way to fix things but this seems to work! Pull Request resolved: pytorch#175510 Approved by: https://github.com/azahed98
|
@pytorchbot revert -m 'Per our discussion with @angelayi, revert this so that #169867 can be reverted, it is breaking a bunch of internal tests' -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 4416f11. Reverted #175510 on behalf of https://github.com/huydhn due to Per our discussion with @angelayi, revert this so that #169867 can be reverted, it is breaking a bunch of internal tests ([comment](#175510 (comment)))
|
@angelayi your PR has been successfully reverted. |
This reverts commit 4416f11. Reverted pytorch#175510 on behalf of https://github.com/huydhn due to Per our discussion with @angelayi, revert this so that pytorch#169867 can be reverted, it is breaking a bunch of internal tests ([comment](pytorch#175510 (comment)))
|
relanded with #176661 |
Unsure whats the best way to fix things but this seems to work! Pull Request resolved: pytorch#175510 Approved by: https://github.com/azahed98
This reverts commit 3918989. Reverted pytorch#175510 on behalf of https://github.com/malfet due to It broke init_device_mesh_init_skip_after_graphbreak (whatever that means), see https://hud.pytorch.org/hud/pytorch/pytorch/d63f6584d251be2c9b9532f462e09399d9a29f03/1?per_page=50&name_filter=asan&mergeEphemeralLF=true for example ([comment](pytorch#175510 (comment)))
Unsure whats the best way to fix things but this seems to work! Pull Request resolved: pytorch#175510 Approved by: https://github.com/azahed98
This reverts commit 45c625b. Reverted pytorch#175510 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94598146 ([comment](pytorch#175510 (comment)))
Unsure whats the best way to fix things but this seems to work! Pull Request resolved: pytorch#175510 Approved by: https://github.com/azahed98
This reverts commit 4416f11. Reverted pytorch#175510 on behalf of https://github.com/huydhn due to Per our discussion with @angelayi, revert this so that pytorch#169867 can be reverted, it is breaking a bunch of internal tests ([comment](pytorch#175510 (comment)))
Unsure whats the best way to fix things but this seems to work!
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo