Skip to content

Reland "Make DeviceMesh Opaque"#176661

Closed
angelayi wants to merge 2 commits intomainfrom
angelayi/device_mesh_revert_revert
Closed

Reland "Make DeviceMesh Opaque"#176661
angelayi wants to merge 2 commits intomainfrom
angelayi/device_mesh_revert_revert

Conversation

@angelayi
Copy link
Copy Markdown
Contributor

@angelayi angelayi commented Mar 5, 2026 •
edited by pytorch-bot Bot
Loading

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 5, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176661

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit cfdc4fa with merge base bc22e50 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 5, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@angelayi angelayi changed the title Angelayi/device mesh revert revert Reland "Make DeviceMesh Opaque" Mar 5, 2026
@angelayi angelayi added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Mar 5, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 5, 2026

@angelayi has imported this pull request. If you are a Meta employee, you can view this in D95461452.

aorenste
aorenste approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@aorenste aorenste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved w/ comments

Comment thread torch/_dynamo/trace_rules.py Outdated
Comment thread torch/_library/fake_class_registry.py
Comment thread test/distributed/tensor/test_dtensor_compile.py
meta-codesync Bot pushed a commit that referenced this pull request Mar 6, 2026
@angelayi @facebook-github-bot
Angelayi/device mesh revert revert (#176661)
d4c9a1b 
Summary: Pull Request resolved: #176661

Differential Revision: D95461452

Pulled By: angelayi
@meta-codesync meta-codesync Bot force-pushed the angelayi/device_mesh_revert_revert branch from 742c3ea to d4c9a1b Compare March 6, 2026 22:45
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 6, 2026

@angelayi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95461452.

@angelayi angelayi force-pushed the angelayi/device_mesh_revert_revert branch from d4c9a1b to f1f681f Compare March 9, 2026 23:16
@angelayi angelayi force-pushed the angelayi/device_mesh_revert_revert branch from f1f681f to cfdc4fa Compare March 10, 2026 07:18
@pytorch-bot pytorch-bot Bot added the ciflow/torchtitan Run TorchTitan integration tests label Mar 10, 2026
@angelayi
Copy link
Copy Markdown
Contributor Author

angelayi commented Mar 10, 2026

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 10, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@angelayi angelayi mentioned this pull request Mar 11, 2026
Closed
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
@angelayi @EmanueleCoradin
Reland "Make DeviceMesh Opaque" (pytorch#176661)
8414651 
Pull Request resolved: pytorch#176661
Approved by: https://github.com/aorenste
@aditvenk aditvenk mentioned this pull request Apr 7, 2026
Closed
@github-actions github-actions Bot deleted the angelayi/device_mesh_revert_revert branch April 10, 2026 02:27
@guangyey guangyey mentioned this pull request Apr 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aorenste aorenste aorenste approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged meta-exported module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angelayi @pytorchmergebot @aorenste