Handle FakeScriptObject in save_graph_repro by aorenste · Pull Request #175765 · pytorch/pytorch

aorenste · 2026-02-25T18:38:21Z

Stack from ghstack (oldest at bottom):

-> Handle FakeScriptObject in save_graph_repro #175765

Previously, FakeScriptObject inputs to AOT graphs fell through to
writer.unsupported(), making the generated repro scripts incomplete.
Add an opaque() method to the reader/writer protocols that records
the script class name, so repro scripts can at least reference
opaque objects instead of silently dropping them.

Authored with Claude.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

Previously, FakeScriptObject inputs to AOT graphs fell through to writer.unsupported(), making the generated repro scripts incomplete. Add an opaque() method to the reader/writer protocols that records the script class name, so repro scripts can at least reference opaque objects instead of silently dropping them. Authored with Claude. [ghstack-poisoned]

pytorch-bot · 2026-02-25T18:38:25Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175765

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit f76fb3f with merge base e69df34 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-jammy-py3.14t-clang15 / test (crossref, 1, 2, lf.linux.2xlarge) (gh) (similar failure)
test/test_serialization.py::TestSerialization::test_serialization_4gb_file
trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) (gh) (similar failure)
test/test_indexing.py::TestIndexingMPS::test_index_reduce_reduce_amax_mps_float32

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / inductor-test / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
drq

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable) (gh) (#174929)
detectron2_maskrcnn_r_50_fpn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot · 2026-02-25T18:38:28Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

aorenste · 2026-02-26T02:45:01Z

@pytorchbot merge

pytorchmergebot · 2026-02-26T02:47:19Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-26T08:45:26Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

aorenste · 2026-02-26T18:11:23Z

@pytorchbot merge

pytorchmergebot · 2026-02-26T18:13:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-02-26T18:14:04Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x ed5dc94bd8e54ce46ec45fefed7765109deebe1d returned non-zero exit code 1

Auto-merging torch/_dynamo/debug_utils.py
CONFLICT (content): Merge conflict in torch/_dynamo/debug_utils.py
Auto-merging torch/_dynamo/repro/after_aot.py
error: could not apply ed5dc94bd8e... Handle FakeScriptObject in save_graph_repro
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

Previously, FakeScriptObject inputs to AOT graphs fell through to writer.unsupported(), making the generated repro scripts incomplete. Add an opaque() method to the reader/writer protocols that records the script class name, so repro scripts can at least reference opaque objects instead of silently dropping them. Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]

aorenste · 2026-02-26T22:07:27Z

@pytorchbot drci

aorenste · 2026-02-27T04:11:34Z

Mac failure is a trunk flaky
@pytorchbot merge -i

pytorchmergebot · 2026-02-27T04:13:57Z

Merge started

Your change will be merged while ignoring the following 3 checks: trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx950.1), trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m1-14), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 1, 5, linux.g6.4xlarge.experimental.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

jeanschmidt · 2026-02-27T23:15:39Z

@pytorchbot revert -m "Need to revert in order to revert #175555 - see D94699609" -c ghfirst

pytorchmergebot · 2026-02-27T23:17:43Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit 2958025. Reverted #175765 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert #175555 - see D94699609 ([comment](#175765 (comment)))

pytorchmergebot · 2026-02-27T23:17:53Z

@aorenste your PR has been successfully reverted.

Previously, FakeScriptObject inputs to AOT graphs fell through to writer.unsupported(), making the generated repro scripts incomplete. Add an opaque() method to the reader/writer protocols that records the script class name, so repro scripts can at least reference opaque objects instead of silently dropping them. Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]

Previously, FakeScriptObject inputs to AOT graphs fell through to writer.unsupported(), making the generated repro scripts incomplete. Add an opaque() method to the reader/writer protocols that records the script class name, so repro scripts can at least reference opaque objects instead of silently dropping them. Authored with Claude. ghstack-source-id: cbbd720 Pull Request resolved: #175765

aorenste · 2026-03-01T22:49:23Z

@pytorchbot merge

pytorchmergebot · 2026-03-01T22:51:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Previously, FakeScriptObject inputs to AOT graphs fell through to writer.unsupported(), making the generated repro scripts incomplete. Add an opaque() method to the reader/writer protocols that records the script class name, so repro scripts can at least reference opaque objects instead of silently dropping them. Authored with Claude. ghstack-source-id: 929d3d0 Pull Request resolved: pytorch/pytorch#175765

Previously, FakeScriptObject inputs to AOT graphs fell through to writer.unsupported(), making the generated repro scripts incomplete. Add an opaque() method to the reader/writer protocols that records the script class name, so repro scripts can at least reference opaque objects instead of silently dropping them. Authored with Claude. Pull Request resolved: pytorch#175765 Approved by: https://github.com/angelayi

This reverts commit 2958025. Reverted pytorch#175765 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert pytorch#175555 - see D94699609 ([comment](pytorch#175765 (comment)))

Previously, FakeScriptObject inputs to AOT graphs fell through to writer.unsupported(), making the generated repro scripts incomplete. Add an opaque() method to the reader/writer protocols that records the script class name, so repro scripts can at least reference opaque objects instead of silently dropping them. Authored with Claude. Pull Request resolved: pytorch#175765 Approved by: https://github.com/angelayi

pytorch-bot Bot added ciflow/inductor module: dynamo labels Feb 25, 2026

This was referenced Feb 25, 2026

Remap opaque objects from inputs to outputs at runtime in AOTAutograd #175667

Closed

Add identity guards for shared opaque objects in subclass metadata #175668

Closed

aorenste added the topic: not user facing topic category label Feb 25, 2026

aorenste requested a review from angelayi February 25, 2026 18:39

angelayi approved these changes Feb 25, 2026

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 26, 2026

pytorchmergebot added the merging label Feb 26, 2026

pytorchmergebot removed the merging label Feb 26, 2026

pytorchmergebot added the merging label Feb 27, 2026

pytorchmergebot closed this in 2958025 Feb 27, 2026

pytorchmergebot added Merged and removed merging labels Feb 27, 2026

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Feb 27, 2026

pytorchmergebot reopened this Feb 27, 2026

pytorchmergebot added the merging label Mar 1, 2026

pytorchmergebot closed this in ebd456c Mar 1, 2026

pytorchmergebot removed the merging label Mar 1, 2026

github-actions Bot deleted the gh/aorenste/194/head branch April 1, 2026 02:23

Conversation

aorenste commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175765

✅ You can merge normally! (4 Unrelated Failures)

Uh oh!

pytorch-bot Bot commented Feb 25, 2026

This PR needs a release notes: label

Uh oh!

aorenste commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 26, 2026

Uh oh!

aorenste commented Feb 26, 2026

Uh oh!

pytorchmergebot commented Feb 26, 2026

Merge started

Uh oh!

pytorchmergebot commented Feb 26, 2026

Merge failed

Uh oh!

aorenste commented Feb 26, 2026

Uh oh!

aorenste commented Feb 27, 2026

Uh oh!

pytorchmergebot commented Feb 27, 2026

Merge started

Uh oh!

jeanschmidt commented Feb 27, 2026

Uh oh!

pytorchmergebot commented Feb 27, 2026

Uh oh!

pytorchmergebot commented Feb 27, 2026

Uh oh!

aorenste commented Mar 1, 2026

Uh oh!

pytorchmergebot commented Mar 1, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aorenste commented Feb 25, 2026 •

edited

Loading

pytorch-bot Bot commented Feb 25, 2026 •

edited

Loading

This PR needs a `release notes:` label