use bundled prettier if local prettier does not resolve#561
use bundled prettier if local prettier does not resolve#561anisjonischkeit wants to merge 7 commits intoprettier:masterfrom
Conversation
|
Thanks for your contribution. IMHO: If a user specifies a prettier version, they would expect their code be formatted by that given version. |
|
I didn’t realise you could even specify what version of prettier you want to use. How do you set it? |
|
package.json's (dev)dependencies |
|
The problem we are having is that our node_modules folder is not in the default location. With the current version of prettier-vscode, it fails silently in this scenario. With the PR, it passes silently. What if we let it pass but display a message saying "Could not find locally installed prettier, maybe try running npm install. Defaulting to bundled prettier." |
|
Ah! There's already a PR for this! :) |
1a8a20d to
144cae9
Compare
* Use the schema for package.json "prettier" key * Add changelog entry
* feat: update prettier to 1.15.1 * fix: add new prettier options * fix: move prettier settings to correct place
Peer dep of prettier-tslint
|
What can we do to move this PR forward? I'm using yarn |
|
Closing in favor of #811 |
* Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * Support Prettier <1.8.0 for getSupportInfo (#707) * feat: hide statusBarItem for disabled languages (#733) * Resolve prettier to bundled if findPkg can't find it (#811) Fixes #522 Slightly different implementation of #561 * Update .vscodeignore Add .github folder * Create bare-bones pull request template (#708) * Create bare-bones pull request template This template almost certainly needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog. * Create separate .github folder for issue/pr templates * add support for quoteProps * Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * add support for quoteProps
This PR is a fix for this issue: #522.