Create bare-bones pull request template#708
Merged
CiGit merged 2 commits intoprettier:masterfrom Apr 25, 2019
Merged
Conversation
This template almost certainly needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog.
|
For organization's sake you may want to move this (and other GitHub-specific templates) into a |
JHilker
reviewed
Feb 1, 2019
Contributor
JHilker
left a comment
There was a problem hiding this comment.
Thanks for adding this. 🙇
Didn't even think of updating the changelog in my earlier PR
PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -0,0 +1,4 @@ | |||
| - [ ] Run tests | |||
| - [ ] Update the [`Changelog.md`][1] with a summary of your changes | |||
Contributor
There was a problem hiding this comment.
Nit: Might as well reference it as CHANGELOG.md to prevent any file case confusion?
Contributor
Author
|
@JHilker you may also want to think about issue templates: https://help.github.com/articles/creating-issue-templates-for-your-repository/ |
Member
|
Thanks, we should add that folder to https://github.com/prettier/prettier-vscode/blob/master/.vscodeignore I'll do it |
CiGit
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * Support Prettier <1.8.0 for getSupportInfo (#707) * feat: hide statusBarItem for disabled languages (#733) * Resolve prettier to bundled if findPkg can't find it (#811) Fixes #522 Slightly different implementation of #561 * Update .vscodeignore Add .github folder * Create bare-bones pull request template (#708) * Create bare-bones pull request template This template almost certainly needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog. * Create separate .github folder for issue/pr templates * add support for quoteProps * Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * add support for quoteProps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This template needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog.
Here's some background on Issue Templates and Pull Request Templates.