Skip to content

Support prettier 1.17#797

Merged
CiGit merged 12 commits intoprettier:masterfrom
obvioussean:prettier1.17
Apr 25, 2019
Merged

Support prettier 1.17#797
CiGit merged 12 commits intoprettier:masterfrom
obvioussean:prettier1.17

Conversation

@obvioussean
Copy link
Copy Markdown

@obvioussean obvioussean commented Apr 15, 2019

Typescript 3.4 added support for the readonly modifer, which prettier 1.17 was released to support. Without this prettier crashes on files using the readonly modifer.

@obvioussean
Copy link
Copy Markdown
Author

obvioussean commented Apr 17, 2019 •
edited
Loading

@CiGit I've been using the readonly feature and prettier-vscode is completely busted for me. Any chance you could merge this PR?

@David-Else
Copy link
Copy Markdown

David-Else commented Apr 21, 2019

@CiGit Please update to prettier 1.17.

@ghost
Copy link
Copy Markdown

ghost commented Apr 21, 2019 •
edited by ghost
Loading

Hey, I had also opened an issue concerning prettier and the readonly [] tuple modifier #803 and would really appreciate an update - Closing in favor of this one.

@ffaubert
Copy link
Copy Markdown

ffaubert commented Apr 24, 2019

Can we please get this updated? Having it behind like this is causing issues for my team.

@studiojms
Copy link
Copy Markdown

studiojms commented Apr 24, 2019 •
edited
Loading

Regarding the support of prettier 1.17, I'm also having problemas with the dynamic import syntax, that now breaks when the line is too long:

1.16:

const MyPage = React.lazy(() =>
  import('./pages/name/other/long/name/Index')
);

1.17:

const MyPage = React.lazy(() =>
  import(
    './pages/name/other/long/name/Index'
  ));

Will this situation be fixed in this issue?

@CiGit
Copy link
Copy Markdown
Member

CiGit commented Apr 25, 2019

Thanks,
Can you add quote-props to our options ?

visnup and others added 3 commits April 25, 2019 15:19
@visnup @CiGit
Resolve prettier to bundled if findPkg can't find it (prettier#811)
373fc3b 
Fixes prettier#522
Slightly different implementation of prettier#561
@CiGit
Update .vscodeignore
bfdb6c6 
Add .github folder
@briandk @CiGit
Create bare-bones pull request template (prettier#708)
f7bff32 
* Create bare-bones pull request template

This template almost certainly needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog.

* Create separate .github folder for issue/pr templates
@ghost
Copy link
Copy Markdown

ghost commented Apr 25, 2019

Installing newest prettier 1.17.0 as local dev dependency solved this for me as a workaround.

@obvioussean
Copy link
Copy Markdown
Author

obvioussean commented Apr 25, 2019

@CiGit Updated!

@CiGit
Copy link
Copy Markdown
Member

CiGit commented Apr 25, 2019

Thank you !

@CiGit CiGit merged commit f677893 into prettier:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@obvioussean @David-Else @ffaubert @studiojms @CiGit @JHilker @sibiraj-s @visnup @briandk