Use the schema for package.json "prettier" key#600
Merged
CiGit merged 2 commits intoprettier:masterfrom Nov 7, 2018
Merged
Conversation
Contributor
|
You shouldn't add yourseld to the contributor's list, @prettier decides not you, just saying. |
1e43260 to
3d673e9
Compare
Contributor
Author
|
Fixed! Thanks and sorry @svipben. |
Member
|
Great idea. Thank you! |
Contributor
Author
|
No problem. One of my biggest pain points with prettier was using the package.json settings, which I think will be better now |
anisjonischkeit
pushed a commit
to anisjonischkeit/prettier-vscode
that referenced
this pull request
Nov 9, 2018
* Use the schema for package.json "prettier" key * Add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the schema located at http://json.schemastore.org/prettierrc for the
package.json"prettier"key, so that it can be autocompleted and validated.The only unresolved question I have is whether the schema file should be in a different folder or have a different name. I think that the new file will be included in the built extension, as the
.vscodeignorefile does not include it, although I'm not certain.