Skip to content

feat: update prettier to 1.15.1 and add html test#619

Merged
CiGit merged 3 commits intoprettier:masterfrom
n1ru4l:upgrade-prettier-1.15.1
Nov 7, 2018
Merged

feat: update prettier to 1.15.1 and add html test#619
CiGit merged 3 commits intoprettier:masterfrom
n1ru4l:upgrade-prettier-1.15.1

Conversation

@n1ru4l
Copy link
Copy Markdown
Contributor

@n1ru4l n1ru4l commented Nov 7, 2018

No description provided.

@CiGit
Copy link
Copy Markdown
Member

CiGit commented Nov 7, 2018

Thanks for your PR.
1.15 also brings in more settings 😞

Except EndOfLine -- which is already in VSCode files.eol -- I think we should add them.

@n1ru4l
Copy link
Copy Markdown
Contributor Author

n1ru4l commented Nov 7, 2018

@CiGit I am on it!

@n1ru4l
Copy link
Copy Markdown
Contributor Author

n1ru4l commented Nov 7, 2018

@n1ru4l n1ru4l force-pushed the upgrade-prettier-1.15.1 branch from 4a3ef8c to 2542e3c Compare November 7, 2018 10:43
@n1ru4l
Copy link
Copy Markdown
Contributor Author

n1ru4l commented Nov 7, 2018

Also rebased master, this should be ready to merge!

@CiGit
Copy link
Copy Markdown
Member

CiGit commented Nov 7, 2018

So \r is the only difference from what I see. What I meant was not using file.eol to pass it to prettier but allow VSCode to change it with it's own tools if needed. Prettier will then work in auto mode.
And if a project really needs something special, we still read it from config files.

Just sharing my thought. I've no strong preference.

@n1ru4l
Copy link
Copy Markdown
Contributor Author

n1ru4l commented Nov 7, 2018

Makes sense to me, should I remove the prettier.endOfLine setting?

@CiGit
Copy link
Copy Markdown
Member

CiGit commented Nov 7, 2018

It doesn't cost us to keep it. In auto mode it does nothing. Let's keep it

Can you add those new settings to the readme ?

And we are good!

@svipas
Copy link
Copy Markdown
Contributor

svipas commented Nov 7, 2018

Also, don't forget about changelog 😄

@n1ru4l n1ru4l force-pushed the upgrade-prettier-1.15.1 branch from 2542e3c to 4bb8ec4 Compare November 7, 2018 11:51
@n1ru4l n1ru4l force-pushed the upgrade-prettier-1.15.1 branch from 4bb8ec4 to 29a7b8e Compare November 7, 2018 11:54
@n1ru4l
Copy link
Copy Markdown
Contributor Author

n1ru4l commented Nov 7, 2018

@CiGit @svipben Done.

@CiGit
Copy link
Copy Markdown
Member

CiGit commented Nov 7, 2018

Great! Thank you!

@CiGit CiGit merged commit 642066a into prettier:master Nov 7, 2018
@philipithomas
Copy link
Copy Markdown

philipithomas commented Nov 7, 2018

Thanks @CiGit and @n1ru4l for working quickly, testing the code, and cutting a new release!

@n1ru4l n1ru4l deleted the upgrade-prettier-1.15.1 branch November 7, 2018 13:51
anisjonischkeit pushed a commit to anisjonischkeit/prettier-vscode that referenced this pull request Nov 9, 2018
* feat: update prettier to 1.15.1

* fix: add new prettier options

* fix: move prettier settings to correct place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants