feat: update prettier to 1.15.1 and add html test#619
Conversation
|
Thanks for your PR.
Except |
|
@CiGit I am on it! |
|
@CiGit "files.eol" differs from prettier endOfLine (https://github.com/Microsoft/vscode/blob/409e61c5cadcbd0347b23e3102ae3ebb5258b8f9/src/vs/workbench/parts/files/electron-browser/files.contribution.ts#L239) vs https://prettier.io/docs/en/options.html#end-of-line So I added it as a prettier option instead of using the vscode option. |
4a3ef8c to
2542e3c
Compare
|
Also rebased master, this should be ready to merge! |
|
So Just sharing my thought. I've no strong preference. |
|
Makes sense to me, should I remove the |
|
It doesn't cost us to keep it. In auto mode it does nothing. Let's keep it Can you add those new settings to the readme ? And we are good! |
|
Also, don't forget about changelog 😄 |
2542e3c to
4bb8ec4
Compare
4bb8ec4 to
29a7b8e
Compare
|
@CiGit @svipben Done. |
|
Great! Thank you! |
* feat: update prettier to 1.15.1 * fix: add new prettier options * fix: move prettier settings to correct place
No description provided.