Skip to content

Clean up redundant code for TiFlash #2019

@JaySon-Huang

Description

@JaySon-Huang

TiFlash fork from Clickhouse around late 2018. There are lots of useless codes for TiFlash.

Something not sure:

  • Remove redundant data types so that we don't need to instantiate some template class for these data types, which may greatly reduce our compile time
    • "DataTypeDate"/"DateTypeDateTime"
      We use "DataTypeMyDate"/"DataTypeMyDatetime" for MySQL/TiDB-compatibility, these original data types ported from Clickhouse are useless for TiFlash
    • "DataTypeTuple"/"DataTypeArray"/"DataTypeSet"
      We don't use these data type

Possible it is good for speeding up our CI building step #1390.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.type/code-quality-improvementPR that can improve the code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions