Skip to content

Remove ClickHouse DDL worker#2253

Merged
ti-srebot merged 9 commits intopingcap:masterfrom
JaySon-Huang:remove_ddl_worker
Jul 23, 2021
Merged

Remove ClickHouse DDL worker#2253
ti-srebot merged 9 commits intopingcap:masterfrom
JaySon-Huang:remove_ddl_worker

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jun 25, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: a part of #2019

Problem Summary:
ClickHouse use Distributed DDL Queries to apply DDL on ClickHouse cluster. While TiFlash sync schema by SchemaSyncerService.
Remove ClickHouse DDL worker. It is a pre-step for removing ZooKeeper from the TiFlash code base.

What is changed and how it works?

  • Remove DDL worker
  • Throw exception if run into Distributed DDL Queries

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • No code

Side effects

Release note

  • No release note

@JaySon-Huang
Remove executeDDLQueryOnCluster
bf7ec46 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Cleanup cpptoml includes
0d7b94f 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove DDL worker
d706df1 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Reduce include header dependency
23281f6 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang self-assigned this Jun 25, 2021
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 25, 2021
Open
18 tasks
@JaySon-Huang
Fix test
9d48c41 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 25, 2021

/run-all-tests

@JaySon-Huang JaySon-Huang mentioned this pull request Jun 26, 2021
Merged
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jul 2, 2021

Could somebody help me to get this PR merged? @flowbehappy @JinheLin

@flowbehappy flowbehappy self-requested a review July 23, 2021 06:35
flowbehappy
flowbehappy approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
JaySon-Huang
JaySon-Huang commented Jul 23, 2021
View reviewed changes
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jul 23, 2021

/merge

@ti-srebot
Copy link
Collaborator

ti-srebot commented Jul 23, 2021

Your auto merge job has been accepted, waiting for:

  • 2298

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-srebot
Copy link
Collaborator

ti-srebot commented Jul 23, 2021

/run-all-tests

@ti-srebot ti-srebot merged commit a0b8dfd into pingcap:master Jul 23, 2021
@JaySon-Huang JaySon-Huang deleted the remove_ddl_worker branch July 23, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees

@JaySon-Huang JaySon-Huang

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaySon-Huang @ti-srebot @flowbehappy