Skip to content

Remove ZooKeeper#2255

Merged
ti-srebot merged 9 commits intopingcap:masterfrom
JaySon-Huang:remove_zk
Jul 23, 2021
Merged

Remove ZooKeeper#2255
ti-srebot merged 9 commits intopingcap:masterfrom
JaySon-Huang:remove_zk

Conversation

@JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: a part of #2019

Problem Summary: Clickhouse use ZooKeeper for replication, but TiFlash rely on PD and TiKV's Raft layer

What is changed and how it works?

Should merge #2253 first.
ClickHouse uses ZooKeeper for replication, but TiFlash relies on PD and TiKV's Raft layer. Remove codes with ZooKeeper.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • No code

Release note

  • No release note

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang self-assigned this Jun 26, 2021
@flowbehappy flowbehappy self-requested a review July 23, 2021 06:43
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@JaySon-Huang JaySon-Huang changed the title [DNM] Remove ZooKeeper Remove ZooKeeper Jul 23, 2021
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 73e4fd6 into pingcap:master Jul 23, 2021
@JaySon-Huang JaySon-Huang deleted the remove_zk branch July 23, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants