Reduction of extraneous compoents #2022
Merged
JaySon-Huang merged 9 commits intopingcap:masterfrom Jun 2, 2021
Merged
Conversation
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Contributor
|
/run-all-tests |
Contributor
Contributor
|
@JaySon-Huang at least it is not yet to be implemented. I have no objection on this change. |
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Contributor
Author
|
/run-all-tests |
2 similar comments
Contributor
Author
|
/run-all-tests |
Contributor
|
/run-all-tests |
JaySon-Huang
approved these changes
Jun 1, 2021
Contributor
JaySon-Huang
left a comment
There was a problem hiding this comment.
LGTM
I think we can keep the release note to be "No release note" since it doesn't matter for endpoint users. We mainly write the release note for endpoint users but not developers.
Contributor
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
Contributor
|
/rebuild |
Contributor
Author
|
/run-all-tests |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
address the problem in #2019
What is changed and how it works?
What's Changed:
Related changes
None
Check List
Tests
Release note
No release note