Merged
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
ti-srebot
approved these changes
Dec 15, 2020
Contributor
Author
|
/merge |
Collaborator
|
/run-all-tests |
Collaborator
|
/run-all-tests |
Collaborator
|
@JaySon-Huang merge failed. |
Contributor
|
/merge |
Collaborator
|
/run-all-tests |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
This PR #249 brought some methods for RegionTable for DT engine learner read. After we refactor the process of learner read, these methods are no longer need.
We kept a legacy version of code after greatly refactor the code of class PageStorage.
Remove these useless codes to reduce code complexity.
What is changed and how it works?
Remove useless codes to reduce code complexity.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note