Remove useless Analyzers#2497
Closed
leiysky wants to merge 2 commits intopingcap:masterfrom
leiysky:enhancement/cleanup-analyzers
Closed
Remove useless Analyzers#2497leiysky wants to merge 2 commits intopingcap:masterfrom leiysky:enhancement/cleanup-analyzers
leiysky wants to merge 2 commits intopingcap:masterfrom
leiysky:enhancement/cleanup-analyzers
Conversation
Contributor
Author
|
/run-all-tests |
Contributor
|
LGTM, prefer to leave the decision to bosses. |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/rebuild |
Contributor
|
LGTM, but I'd like to invite those experts on the computing layer to do the last decision. |
18 tasks
Contributor
Author
|
/rebuild |
Contributor
Author
|
/run-all-tests |
hanfei1991
approved these changes
Jul 30, 2021
Contributor
|
/merge |
Contributor
|
/merge |
ti-srebot
approved these changes
Jul 31, 2021
Contributor
|
/run-all-tests |
Contributor
|
/merge |
fuzhe1989
approved these changes
Aug 3, 2021
Collaborator
|
@fuzhe1989, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
related to #2019
Analyzersare useless for us, I think it's ok to just remove them to make the codebase more clean.What is changed and how it works?
Proposal: xxx
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note