br: fix insert gc failed due to slow schema reload#57742
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom Dec 3, 2024
Merged
br: fix insert gc failed due to slow schema reload#57742ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8b47d90 to
94f9230
Compare
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Contributor
Author
|
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57742 +/- ##
================================================
+ Coverage 72.8732% 75.3716% +2.4984%
================================================
Files 1677 1731 +54
Lines 464202 481515 +17313
================================================
+ Hits 338279 362926 +24647
+ Misses 105016 96406 -8610
- Partials 20907 22183 +1276
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
/assign @Leavrth |
Contributor
Author
|
/assign @lance6716 |
3pointer
reviewed
Nov 28, 2024
3pointer
approved these changes
Nov 29, 2024
| }) | ||
|
|
||
| // make sure schema reload finishes before proceeding | ||
| if err = waitUntilSchemaReload(ctx, client); err != nil { |
Contributor
There was a problem hiding this comment.
how about put waitUntilSchemaReload after CleanUpKVFiles?
Leavrth
approved these changes
Dec 3, 2024
Contributor
|
/check-issue-triage-complete |
Member
|
In response to a cherrypick label: new pull request created to branch |
13 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Dec 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Dec 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
Tristan1900
added a commit
to Tristan1900/tidb
that referenced
this pull request
Dec 12, 2024
close pingcap#57743 (cherry picked from commit 8fe0618)
Tristan1900
added a commit
to Tristan1900/tidb
that referenced
this pull request
Dec 12, 2024
close pingcap#57743 (cherry picked from commit 8fe0618)
Tristan1900
added a commit
to Tristan1900/tidb
that referenced
this pull request
Dec 12, 2024
close pingcap#57743 (cherry picked from commit 8fe0618)
Tristan1900
added a commit
to Tristan1900/tidb
that referenced
this pull request
Dec 12, 2024
close pingcap#57743 (cherry picked from commit 8fe0618)
Tristan1900
added a commit
to Tristan1900/tidb
that referenced
this pull request
Dec 12, 2024
close pingcap#57743 (cherry picked from commit 8fe0618)
Tristan1900
added a commit
to Tristan1900/tidb
that referenced
this pull request
Dec 12, 2024
close pingcap#57743 (cherry picked from commit 8fe0618)
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Dec 17, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
13 tasks
crazycs520
pushed a commit
to crazycs520/tidb
that referenced
this pull request
Jun 4, 2025
* skip TestIndexJoin31494 * fix * global sort: add boundaries to split keys when generating plan (pingcap#58323) (pingcap#58356) * statistics: get right max table id when to init stats (pingcap#58280) (pingcap#58298) * executor: Fix the parse problematic slow log panic issue due to empty … * statstics: trigger evict by the timer (pingcap#58027) (pingcap#58268) * br: make table existence check unified on different br client (pingcap#58211) (pingcap#58262) * log backup: use global checkpoint ts as source of truth (pingcap#58135) (pingcap#58265) * executor: skip execution when build query for VIEW in I_S (pingcap#58203) (pingcap#58236) * statistics: copy stats when to update it for avoiding data race (pingcap#5810… * domain,infoschema: make infoschema activity block GC safepoint advanci… * planner: handle panic when loading bindings at startup (pingcap#58017) (pingcap#58035) * statistics: right deal with error for reading stats from storage (pingcap#58… * statistics: lite init used wrong value to build table stats ver (pingcap#5802… * lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS (pingcap#5… * *: avoid unlock of unlocked mutex panic on TableDeltaMap (pingcap#57799) (pingcap#57997) * ddl: handle context done after sending DDL jobs (pingcap#57945) (pingcap#57989) * *: activate txn for query on infoschema tables (pingcap#57937) (pingcap#57951) * lightning: add PK to internal tables (pingcap#57480) (pingcap#57932) * statistics: correct behavior of non-lite InitStats and stats sync load… * statistics: avoid stats meta full load after table analysis (pingcap#57756) (pingcap#57911) * dumpling: use I_S to get table list for TiDB and add database to WHERE… * br: fix insert gc failed due to slow schema reload (pingcap#57742) (pingcap#57907) * statistics: do not record historical stats meta if the table is locked… * metrics: remove the filled colors (pingcap#57838) (pingcap#57866) * planner: use TableInfo.DBID to locate schema (pingcap#57785) (pingcap#57870) * *: support cancel query like 'select * from information_schema.tables'… * session: make `TxnInfo()` return even if process info is empty (pingcap#57044) (pingcap#57161) * ddl: Fixed partitioning a non-partitioned table with placement rules (… * *: Reorg partition fix delete ranges and handling non-clustered tables… * executor: fix query infoschema.tables table_schema/table_name with fil… * ddl: check context done in isReorgRunnable function (pingcap#57813) (pingcap#57820) * ddl: fix ExistsTableRow and add tests for skip reorg checks (pingcap#57778) (pingcap#57801) * *: Fix for TRUNCATE PARTITION and Global Index (pingcap#57724) * br: prompt k8s.io/api version (pingcap#57791) (pingcap#57802) * statistics: fix some problem related to stats async load (pingcap#57723) (pingcap#57775) * expression: fix wrong calculation order of `radians` (pingcap#57672) (pingcap#57688) * statistics: rightly deal with timout when to send sync load (pingcap#57712) (pingcap#57751) * ddl: `tidb_scatter_region` variable supports setting value in both upp… * planner: fix that vector index output empty result when pk is non-int … * ddl: dynamically adjusting the max write speed of reorganization job (… * executor: fix hang in hash agg when exceeding memory limit leads to pa… * statistics: use infoschema api to get table info (pingcap#57574) (pingcap#57614) * planner: Use realtimeRowCount when all topN collected (pingcap#56848) (pingcap#57689) * statistics: handle deleted tables correctly in the PQ (pingcap#57649) (pingcap#57674) * backup: reset timeout on store level (pingcap#55526) (pingcap#57667) * planner/core: fix a wrong privilege check for CTE & UPDATE statement (…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #57743
Problem Summary:
What changed and how does it work?
Wait until schema info finished reloading before proceeding to the rest of the restore process,
Added test to first to reproduce the issue and then add the fix to verify the issue has been fixed (TDD)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.