Skip to content

global sort: add boundaries to split keys when generating plan (#58323)#58356

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
lance6716:pick8.5-58323
Dec 18, 2024
Merged

global sort: add boundaries to split keys when generating plan (#58323)#58356
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
lance6716:pick8.5-58323

Conversation

@lance6716
Copy link
Contributor

This is a manual cherry-pick of #58323


What problem does this PR solve?

Issue Number: close #58267

Problem Summary:

What changed and how does it work?

The data flow of region split keys are long. The requirement of later usage is it must contain the region start/end keys, to correctly pause the PD scheduling of given ranges.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Dec 17, 2024
@tiprow
Copy link

tiprow bot commented Dec 17, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@678b713). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58356   +/-   ##
================================================
  Coverage               ?   56.8687%           
================================================
  Files                  ?       1773           
  Lines                  ?     627067           
  Branches               ?          0           
================================================
  Hits                   ?     356605           
  Misses                 ?     246357           
  Partials               ?      24105           
Flag Coverage Δ
integration 36.8070% <75.6756%> (?)
unit 72.5508% <64.8648%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2571% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 11:16:53.383408365 +0000 UTC m=+955603.472210900: ☑️ agreed by D3Hunter.
  • 2024-12-18 02:15:14.901693754 +0000 UTC m=+1009504.990496297: ☑️ agreed by Benjamin2037.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit d13e52e into pingcap:release-8.5 Dec 18, 2024
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Jun 4, 2025
* skip TestIndexJoin31494
* fix
* global sort: add boundaries to split keys when generating plan (pingcap#58323) (pingcap#58356)
* statistics: get right max table id when to init stats (pingcap#58280) (pingcap#58298)
* executor: Fix the parse problematic slow log panic issue due to empty …
* statstics: trigger evict by the timer (pingcap#58027) (pingcap#58268)
* br: make table existence check unified on different br client (pingcap#58211) (pingcap#58262)
* log backup: use global checkpoint ts as source of truth (pingcap#58135) (pingcap#58265)
* executor: skip execution when build query for VIEW in I_S (pingcap#58203) (pingcap#58236)
* statistics: copy stats when to update it for avoiding data race (pingcap#5810…
* domain,infoschema: make infoschema activity block GC safepoint advanci…
* planner: handle panic when loading bindings at startup (pingcap#58017) (pingcap#58035)
* statistics: right deal with error for reading stats from storage  (pingcap#58…
* statistics: lite init used wrong value to build table stats ver (pingcap#5802…
* lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS  (pingcap#5…
* *: avoid unlock of unlocked mutex panic on TableDeltaMap (pingcap#57799) (pingcap#57997)
* ddl: handle context done after sending DDL jobs (pingcap#57945) (pingcap#57989)
* *: activate txn for query on infoschema tables (pingcap#57937) (pingcap#57951)
* lightning: add PK to internal tables (pingcap#57480) (pingcap#57932)
* statistics: correct behavior of non-lite InitStats and stats sync load…
* statistics: avoid stats meta full load after table analysis (pingcap#57756) (pingcap#57911)
* dumpling: use I_S to get table list for TiDB and add database to WHERE…
* br: fix insert gc failed due to slow schema reload (pingcap#57742) (pingcap#57907)
* statistics: do not record historical stats meta if the table is locked…
* metrics: remove the filled colors (pingcap#57838) (pingcap#57866)
* planner: use TableInfo.DBID to locate schema (pingcap#57785) (pingcap#57870)
* *: support cancel query like 'select * from information_schema.tables'…
* session: make `TxnInfo()` return even if process info is empty (pingcap#57044) (pingcap#57161)
* ddl: Fixed partitioning a non-partitioned table with placement rules (…
* *: Reorg partition fix delete ranges and handling non-clustered tables…
* executor: fix query infoschema.tables table_schema/table_name with fil…
* ddl: check context done in isReorgRunnable function (pingcap#57813) (pingcap#57820)
* ddl: fix ExistsTableRow and add tests for skip reorg checks (pingcap#57778) (pingcap#57801)
* *: Fix for TRUNCATE PARTITION and Global Index (pingcap#57724)
* br: prompt k8s.io/api version (pingcap#57791) (pingcap#57802)
* statistics: fix some problem related to stats async load (pingcap#57723) (pingcap#57775)
* expression: fix wrong calculation order of `radians` (pingcap#57672) (pingcap#57688)
* statistics: rightly deal with timout when to send sync load  (pingcap#57712) (pingcap#57751)
* ddl: `tidb_scatter_region` variable supports setting value in both upp…
* planner: fix that vector index output empty result when pk is non-int …
* ddl: dynamically adjusting the max write speed of reorganization job (…
* executor: fix hang in hash agg when exceeding memory limit leads to pa…
* statistics: use infoschema api to get table info (pingcap#57574) (pingcap#57614)
* planner: Use realtimeRowCount when all topN collected (pingcap#56848) (pingcap#57689)
* statistics: handle deleted tables correctly in the PQ (pingcap#57649) (pingcap#57674)
* backup: reset timeout on store level (pingcap#55526) (pingcap#57667)
* planner/core: fix a wrong privilege check for CTE & UPDATE statement (…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants