Skip to content

br: prompt k8s.io/api version#57791

Merged
ti-chi-bot[bot] merged 2 commits intomasterfrom
prompt_k8s_version
Nov 28, 2024
Merged

br: prompt k8s.io/api version#57791
ti-chi-bot[bot] merged 2 commits intomasterfrom
prompt_k8s_version

Conversation

@BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Nov 28, 2024

What problem does this PR solve?

Issue Number: close #57790

Problem Summary:

k8s.io/api has risks of some security issue at current v0.28.x version.

What changed and how does it work?

prompt the version to v0.29

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Prompt k8s.io/api library to 0.29.11 to mitigate possible security risks.

Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2024
@tiprow
Copy link

tiprow bot commented Nov 28, 2024

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2024

@xiabee: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2024
@BornChanger
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Nov 28, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4784%. Comparing base (924784a) to head (ad152a4).
Report is 127 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57791        +/-   ##
================================================
+ Coverage   72.8642%   73.4784%   +0.6141%     
================================================
  Files          1677       1677                
  Lines        464210     465594      +1384     
================================================
+ Hits         338243     342111      +3868     
+ Misses       105090     102674      -2416     
+ Partials      20877      20809        -68     
Flag Coverage Δ
integration 43.5854% <ø> (?)
unit 72.2212% <ø> (-0.0389%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7186% <ø> (+0.0330%) ⬆️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, xiabee, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-28 08:49:06.347594832 +0000 UTC m=+712733.967249346: ☑️ agreed by YuJuncen.
  • 2024-11-28 09:35:39.982277371 +0000 UTC m=+715527.601931887: ☑️ agreed by lance6716.

@lance6716
Copy link
Contributor

Need to update the bazel package cache

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7518a29 into master Nov 28, 2024
@ti-chi-bot ti-chi-bot bot deleted the prompt_k8s_version branch November 28, 2024 11:34
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57802.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 2, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57886.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 2, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Dec 4, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #57988.

@BornChanger BornChanger mentioned this pull request Dec 12, 2024
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 17, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 17, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #58333.

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 22, 2025
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Jun 4, 2025
* skip TestIndexJoin31494
* fix
* global sort: add boundaries to split keys when generating plan (pingcap#58323) (pingcap#58356)
* statistics: get right max table id when to init stats (pingcap#58280) (pingcap#58298)
* executor: Fix the parse problematic slow log panic issue due to empty …
* statstics: trigger evict by the timer (pingcap#58027) (pingcap#58268)
* br: make table existence check unified on different br client (pingcap#58211) (pingcap#58262)
* log backup: use global checkpoint ts as source of truth (pingcap#58135) (pingcap#58265)
* executor: skip execution when build query for VIEW in I_S (pingcap#58203) (pingcap#58236)
* statistics: copy stats when to update it for avoiding data race (pingcap#5810…
* domain,infoschema: make infoschema activity block GC safepoint advanci…
* planner: handle panic when loading bindings at startup (pingcap#58017) (pingcap#58035)
* statistics: right deal with error for reading stats from storage  (pingcap#58…
* statistics: lite init used wrong value to build table stats ver (pingcap#5802…
* lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS  (pingcap#5…
* *: avoid unlock of unlocked mutex panic on TableDeltaMap (pingcap#57799) (pingcap#57997)
* ddl: handle context done after sending DDL jobs (pingcap#57945) (pingcap#57989)
* *: activate txn for query on infoschema tables (pingcap#57937) (pingcap#57951)
* lightning: add PK to internal tables (pingcap#57480) (pingcap#57932)
* statistics: correct behavior of non-lite InitStats and stats sync load…
* statistics: avoid stats meta full load after table analysis (pingcap#57756) (pingcap#57911)
* dumpling: use I_S to get table list for TiDB and add database to WHERE…
* br: fix insert gc failed due to slow schema reload (pingcap#57742) (pingcap#57907)
* statistics: do not record historical stats meta if the table is locked…
* metrics: remove the filled colors (pingcap#57838) (pingcap#57866)
* planner: use TableInfo.DBID to locate schema (pingcap#57785) (pingcap#57870)
* *: support cancel query like 'select * from information_schema.tables'…
* session: make `TxnInfo()` return even if process info is empty (pingcap#57044) (pingcap#57161)
* ddl: Fixed partitioning a non-partitioned table with placement rules (…
* *: Reorg partition fix delete ranges and handling non-clustered tables…
* executor: fix query infoschema.tables table_schema/table_name with fil…
* ddl: check context done in isReorgRunnable function (pingcap#57813) (pingcap#57820)
* ddl: fix ExistsTableRow and add tests for skip reorg checks (pingcap#57778) (pingcap#57801)
* *: Fix for TRUNCATE PARTITION and Global Index (pingcap#57724)
* br: prompt k8s.io/api version (pingcap#57791) (pingcap#57802)
* statistics: fix some problem related to stats async load (pingcap#57723) (pingcap#57775)
* expression: fix wrong calculation order of `radians` (pingcap#57672) (pingcap#57688)
* statistics: rightly deal with timout when to send sync load  (pingcap#57712) (pingcap#57751)
* ddl: `tidb_scatter_region` variable supports setting value in both upp…
* planner: fix that vector index output empty result when pk is non-int …
* ddl: dynamically adjusting the max write speed of reorganization job (…
* executor: fix hang in hash agg when exceeding memory limit leads to pa…
* statistics: use infoschema api to get table info (pingcap#57574) (pingcap#57614)
* planner: Use realtimeRowCount when all topN collected (pingcap#56848) (pingcap#57689)
* statistics: handle deleted tables correctly in the PQ (pingcap#57649) (pingcap#57674)
* backup: reset timeout on store level (pingcap#55526) (pingcap#57667)
* planner/core: fix a wrong privilege check for CTE & UPDATE statement (…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade k8s version to resolve some security issues

6 participants