Skip to content

br: prompt k8s.io/api version (#57791)#58333

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-57791-to-release-6.5
Closed

br: prompt k8s.io/api version (#57791)#58333
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-57791-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 17, 2024

This is an automated cherry-pick of #57791

What problem does this PR solve?

Issue Number: close #57790

Problem Summary:

k8s.io/api has risks of some security issue at current v0.28.x version.

What changed and how does it work?

prompt the version to v0.29

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Prompt k8s.io/api library to 0.29.11 to mitigate possible security risks.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 17, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ichn-hu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2024
@BornChanger
br: prompt k8s.io/api version
bdeb491 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger BornChanger force-pushed the cherry-pick-57791-to-release-6.5 branch from e0cb546 to a3cc774 Compare January 22, 2025 07:26
@BornChanger BornChanger requested a review from a team as a code owner January 22, 2025 07:26
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
@BornChanger BornChanger force-pushed the cherry-pick-57791-to-release-6.5 branch from a3cc774 to bdeb491 Compare January 22, 2025 07:28
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 22, 2025
@BornChanger
Copy link
Contributor

BornChanger commented Jan 22, 2025

/cc @hawkingrei

@ti-chi-bot ti-chi-bot bot requested a review from hawkingrei January 22, 2025 07:30
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev bdeb491 link true /test check-dev
idc-jenkins-ci-tidb/build bdeb491 link true /test build
idc-jenkins-ci-tidb/check_dev_2 bdeb491 link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test bdeb491 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test bdeb491 link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jan 22, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot closed this Dec 30, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 30, 2025

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees

@BornChanger BornChanger

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @BornChanger