Skip to content

cherry-pick-8.1: br: fix insert gc failed due to slow schema reload (#57742)#58219

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-8.1from
Tristan1900:release-8.1-fork
Dec 13, 2024
Merged

cherry-pick-8.1: br: fix insert gc failed due to slow schema reload (#57742)#58219
ti-chi-bot[bot] merged 1 commit intopingcap:release-8.1from
Tristan1900:release-8.1-fork

Conversation

@Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Dec 12, 2024

close #57743

(cherry picked from commit 8fe0618)

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2024
@tiprow
Copy link

tiprow bot commented Dec 12, 2024

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Dec 12, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 12, 2024
@Tristan1900 Tristan1900 mentioned this pull request Dec 12, 2024
Closed
13 tasks
@Tristan1900 Tristan1900 changed the title cherry-pick br: fix insert gc failed due to slow schema reload (#57742) cherry-pick-8.1: br: fix insert gc failed due to slow schema reload (#57742) Dec 12, 2024
@codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@65fd2ad). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #58219   +/-   ##
================================================
  Coverage               ?   71.3070%           
================================================
  Files                  ?       1468           
  Lines                  ?     424602           
  Branches               ?          0           
================================================
  Hits                   ?     302771           
  Misses                 ?     101344           
  Partials               ?      20487
Flag Coverage Δ
unit 71.3070% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2113% <0.0000%> (?)

@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Dec 12, 2024

/ok-to-test

@BornChanger
Copy link
Contributor

BornChanger commented Dec 13, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 13, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-13 02:15:41.23328939 +0000 UTC m=+577531.322091934: ☑️ agreed by BornChanger.
  • 2024-12-13 02:16:43.952432592 +0000 UTC m=+577594.041235135: ☑️ agreed by YuJuncen.

lance6716
lance6716 reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

for domain part

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 13, 2024
@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Dec 13, 2024

/retest

@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Dec 13, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Dec 13, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/cherry-pick-not-approved labels Dec 13, 2024
@BornChanger
Copy link
Contributor

BornChanger commented Dec 13, 2024

/retest

@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Dec 13, 2024

same tests failing on 8.1 already for some reason, not introduced in this PR

@ti-chi-bot ti-chi-bot bot merged commit 20e7389 into pingcap:release-8.1 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance6716 lance6716 lance6716 left review comments

@YuJuncen YuJuncen YuJuncen approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tristan1900 @BornChanger @lance6716 @YuJuncen