Skip to content

br: fix insert gc failed due to slow schema reload (#57742)#58215

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-8.1from
ti-chi-bot:cherry-pick-57742-to-release-8.1
Closed

br: fix insert gc failed due to slow schema reload (#57742)#58215
ti-chi-bot wants to merge 1 commit intopingcap:release-8.1from
ti-chi-bot:cherry-pick-57742-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 12, 2024

This is an automated cherry-pick of #57742

What problem does this PR solve?

Issue Number: close #57743

Problem Summary:

What changed and how does it work?

Wait until schema info finished reloading before proceeding to the rest of the restore process,
Added test to first to reproduce the issue and then add the fix to verify the issue has been fixed (TDD)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed loading schema taking long time during restore causing insertGc row and other operations to fail

@Tristan1900 @ti-chi-bot
This is an automated cherry-pick of pingcap#57742
3019570 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 12, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 12, 2024
Merged
13 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yujuncen, zimulala for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tristan1900
Copy link
Contributor

Tristan1900 commented Dec 12, 2024 •
edited
Loading

superseded by #58219 as this automated cherry pick has conflicts

need help to close this one

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 13, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 3019570 link true /test unit-test
idc-jenkins-ci-tidb/build 3019570 link true /test build
idc-jenkins-ci-tidb/check_dev_2 3019570 link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test 3019570 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev 3019570 link true /test check-dev

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @Tristan1900 @BornChanger