Skip to content

flashback: support to flashback to tso syntax#48493

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
BornChanger:flashback_to_tso
Nov 17, 2023
Merged

flashback: support to flashback to tso syntax#48493
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
BornChanger:flashback_to_tso

Conversation

@BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Nov 9, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #48372

Problem Summary:

What is changed and how it works?

This PR provide the flashback cluster to tso support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

This feature provides the new syntax of `flashback` of `flashback cluster to tso xxx_int`. An example is `flashback cluster to tso 445494955052105728`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 9, 2023
@tiprow
Copy link

tiprow bot commented Nov 9, 2023

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-linked-issue labels Nov 9, 2023
@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 9, 2023

/cc @Defined2014 @cfzjywxk

@ti-chi-bot ti-chi-bot bot requested review from Defined2014 and cfzjywxk November 9, 2023 11:43
@codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #48493 (8881508) into master (07057bd) will increase coverage by 1.8247%.
Report is 10 commits behind head on master.
The diff coverage is 76.9230%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48493        +/-   ##
================================================
+ Coverage   71.2181%   73.0429%   +1.8247%     
================================================
  Files          1360       1389        +29     
  Lines        403880     413836      +9956     
================================================
+ Hits         287636     302278     +14642     
+ Misses        96316      92748      -3568     
+ Partials      19928      18810      -1118
Flag Coverage Δ
integration 43.7787% <0.0000%> (?)
unit 71.6115% <76.9230%> (+0.3933%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8745% <ø> (-4.2348%) ⬇️

@BornChanger BornChanger force-pushed the flashback_to_tso branch 2 times, most recently from df8fcc7 to 43e2d35 Compare November 11, 2023 02:32
@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 11, 2023

/retest

@tiprow
Copy link

tiprow bot commented Nov 11, 2023

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Defined2014
Defined2014 reviewed Nov 13, 2023
View reviewed changes
Defined2014
Defined2014 reviewed Nov 16, 2023
View reviewed changes
Defined2014
Defined2014 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Defined2014 Defined2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the parser.y, other LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 16, 2023
@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 16, 2023

/cc @CbcWestwolf

@ti-chi-bot ti-chi-bot bot requested a review from CbcWestwolf November 16, 2023 08:13
CbcWestwolf
CbcWestwolf approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@CbcWestwolf CbcWestwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the indentation in parser.y

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-16 07:38:51.794976495 +0000 UTC m=+4321129.382086639: ☑️ agreed by Defined2014.
  • 2023-11-16 08:59:02.087420388 +0000 UTC m=+4325939.674530532: ☑️ agreed by CbcWestwolf.

@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 16, 2023

/retest

@tiprow
Copy link

tiprow bot commented Nov 16, 2023

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
*: code format
8881508 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 16, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2023
@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 17, 2023

/retest

@tiprow
Copy link

tiprow bot commented Nov 17, 2023

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@easonn7
Copy link

easonn7 commented Nov 17, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, Defined2014, easonn7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6b3df66 into pingcap:master Nov 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 17, 2023
Closed
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #48684.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 17, 2023
@BornChanger @ti-chi-bot
This is an automated cherry-pick of pingcap#48493
33ac0fc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 17, 2023
Closed
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #48685.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 17, 2023
@BornChanger @ti-chi-bot
This is an automated cherry-pick of pingcap#48493
739f673 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 17, 2023
Closed
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2023

In response to a cherrypick label: new pull request created to branch release-7.5: #48686.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 17, 2023
@BornChanger @ti-chi-bot
This is an automated cherry-pick of pingcap#48493
edeb613 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@BornChanger BornChanger mentioned this pull request Nov 24, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 24, 2023
@BornChanger
flashback: support to flashback to tso syntax (#48493) (#48889)
451638a 
close #48372
BornChanger added a commit to BornChanger/tidb that referenced this pull request Dec 11, 2023
@BornChanger
flashback: support to flashback to tso syntax (pingcap#48493) (pingca…
1a6137f 
…p#48889)

close pingcap#48372
@BornChanger BornChanger mentioned this pull request Dec 11, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
@BornChanger
flashback: support to flashback to tso syntax (#48493) (#48889) (#49332)
575a4e6 
close #48372
BornChanger added a commit to BornChanger/tidb that referenced this pull request Feb 18, 2024
@BornChanger
flashback: support to flashback to tso syntax (pingcap#48493)
5c44c2b 
close pingcap#48372
@BornChanger BornChanger mentioned this pull request Feb 18, 2024
Merged
13 tasks
BornChanger added a commit to BornChanger/tidb that referenced this pull request Feb 19, 2024
@BornChanger
flashback: support to flashback to tso syntax (pingcap#48493)
e5bc069 
close pingcap#48372
ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2024
@BornChanger
flashback: support to flashback to tso syntax (#48493) (#51125)
dbc2581 
close #48372
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 19, 2024
budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025
@BornChanger
flashback: support to flashback to tso syntax (pingcap#48493)
506795c 
close pingcap#48372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flashback: add the support to use TSO for the asof expression

5 participants

@BornChanger @easonn7 @ti-chi-bot @Defined2014 @CbcWestwolf