Skip to content

flashback: support to flashback to tso syntax (#48493) (#48889)#49332

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-7.1from
BornChanger:flashback_tso_7.1
Dec 11, 2023
Merged

flashback: support to flashback to tso syntax (#48493) (#48889)#49332
ti-chi-bot[bot] merged 1 commit intopingcap:release-7.1from
BornChanger:flashback_tso_7.1

Conversation

@BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Dec 11, 2023 •
edited
Loading

This is an automated cherry-pick of #48493

What problem does this PR solve?

Issue Number: close #48372

Problem Summary:

What changed and how does it work?

This PR provide the flashback cluster to tso support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

This feature provides the new syntax of `flashback` of `flashback cluster to tso xxx_int`. An example is `flashback cluster to tso 445494955052105728`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 11, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Dec 11, 2023
@tiprow
Copy link

tiprow bot commented Dec 11, 2023

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

BornChanger commented Dec 11, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 11, 2023
@BornChanger BornChanger mentioned this pull request Dec 11, 2023
Closed
13 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-11 08:30:52.444826586 +0000 UTC m=+258543.482053498: ☑️ agreed by YuJuncen.
  • 2023-12-11 08:40:44.099840674 +0000 UTC m=+259135.137067601: ☑️ agreed by 3pointer.

@codecov
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@3a55235). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.1     #49332   +/-   ##
================================================
  Coverage               ?   73.4122%           
================================================
  Files                  ?       1207           
  Lines                  ?     378636           
  Branches               ?          0           
================================================
  Hits                   ?     277965           
  Misses                 ?      82945           
  Partials               ?      17726

@ti-chi-bot ti-chi-bot bot merged commit 575a4e6 into pingcap:release-7.1 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BornChanger @3pointer @YuJuncen @ti-chi-bot