Skip to content

flashback: support to flashback to tso syntax (#48493)#48889

Merged
ti-chi-bot[bot] merged 9 commits intopingcap:release-6.5from
BornChanger:pr48864
Nov 24, 2023
Merged

flashback: support to flashback to tso syntax (#48493)#48889
ti-chi-bot[bot] merged 9 commits intopingcap:release-6.5from
BornChanger:pr48864

Conversation

@BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Nov 24, 2023 •
edited
Loading

This is a cherry-pick of #48493

What problem does this PR solve?

Issue Number: close #48372

Problem Summary:

What changed and how does it work?

This PR provide the flashback cluster to tso support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

This feature provides the new syntax of `flashback` of `flashback cluster to tso xxx_int`. An example is `flashback cluster to tso 445494955052105728`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2023
@tiprow
Copy link

tiprow bot commented Nov 24, 2023

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
*: fix code format
02d5e31 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: adjust bazel
02fed35 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: clean pkg directory
1cdd54d 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger BornChanger changed the title Pr48864 flashback: support to flashback to tso syntax (#48493) Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. labels Nov 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 24, 2023
@BornChanger BornChanger mentioned this pull request Nov 24, 2023
Closed
13 tasks
@easonn7
Copy link

easonn7 commented Nov 24, 2023

/approve

@codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@85f2038). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #48889   +/-   ##
================================================
  Coverage               ?   73.6187%           
================================================
  Files                  ?       1087           
  Lines                  ?     349365           
  Branches               ?          0           
================================================
  Hits                   ?     257198           
  Misses                 ?      75675           
  Partials               ?      16492

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, easonn7, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 12:33:32.149342187 +0000 UTC m=+580440.814568368: ☑️ agreed by 3pointer.
  • 2023-11-24 12:34:33.814442107 +0000 UTC m=+580502.479668303: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 451638a into pingcap:release-6.5 Nov 24, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Nov 25, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 27, 2023
BornChanger added a commit to BornChanger/tidb that referenced this pull request Dec 11, 2023
@BornChanger
flashback: support to flashback to tso syntax (pingcap#48493) (pingca…
1a6137f 
…p#48889)

close pingcap#48372
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
@BornChanger
flashback: support to flashback to tso syntax (#48493) (#48889) (#49332)
575a4e6 
close #48372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BornChanger @easonn7 @3pointer @YuJuncen @ti-chi-bot