Skip to content

flashback: support to flashback to tso syntax (#48493)#48686

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48493-to-release-7.5
Closed

flashback: support to flashback to tso syntax (#48493)#48686
ti-chi-bot wants to merge 1 commit intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48493-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 17, 2023

This is an automated cherry-pick of #48493

What problem does this PR solve?

Issue Number: close #48372

Problem Summary:

What is changed and how it works?

This PR provide the flashback cluster to tso support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

This feature provides the new syntax of `flashback` of `flashback cluster to tso xxx_int`. An example is `flashback cluster to tso 445494955052105728`.

@BornChanger @ti-chi-bot
This is an automated cherry-pick of pingcap#48493
edeb613 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 17, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign c4pt0r, yudongusa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BornChanger
Copy link
Contributor

BornChanger commented Nov 17, 2023

/cherry-pick-invite @BornChanger

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 17, 2023

@BornChanger you're already a collaborator in repo ti-chi-bot/tidb

@shawn0915
Copy link
Contributor

shawn0915 commented Dec 21, 2023

@BornChanger hi,
looks like this feature doesn't merge into v7.5.0, will it gonna merge into v7.5.1?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 9, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 edeb613 link true /test check-dev2
idc-jenkins-ci-tidb/build edeb613 link true /test build
idc-jenkins-ci-tidb/check_dev edeb613 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test edeb613 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test edeb613 link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BornChanger
Copy link
Contributor

BornChanger commented Feb 18, 2024

replaced by #51125

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 19, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot closed this Feb 19, 2024
@ti-chi-bot ti-chi-bot deleted the cherry-pick-48493-to-release-7.5 branch April 15, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BornChanger BornChanger

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @BornChanger @shawn0915