Skip to content

flashback: support to flashback to tso syntax (#48493)#51125

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-7.5from
BornChanger:flashback_to_tso_7.5
Feb 19, 2024
Merged

flashback: support to flashback to tso syntax (#48493)#51125
ti-chi-bot[bot] merged 1 commit intopingcap:release-7.5from
BornChanger:flashback_to_tso_7.5

Conversation

@BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Feb 18, 2024 •
edited
Loading

This is an automated cherry-pick of #48493

What problem does this PR solve?

Issue Number: close #48372

Problem Summary:

What changed and how does it work?

This PR provide the flashback cluster to tso support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

This feature provides the new syntax of `flashback` of `flashback cluster to tso xxx_int`. An example is `flashback cluster to tso 445494955052105728`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Feb 18, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Feb 18, 2024
@tiprow
Copy link

tiprow bot commented Feb 18, 2024

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 18, 2024
@BornChanger BornChanger mentioned this pull request Feb 18, 2024
Closed
13 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 18, 2024
@BornChanger
Copy link
Contributor Author

BornChanger commented Feb 18, 2024

/retest

@tiprow
Copy link

tiprow bot commented Feb 18, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Feb 18, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@f27e4e0). Click here to learn what that means.
The diff coverage is 76.9230%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #51125   +/-   ##
================================================
  Coverage               ?   72.2668%           
================================================
  Files                  ?       1403           
  Lines                  ?     409575           
  Branches               ?          0           
================================================
  Hits                   ?     295987           
  Misses                 ?      93858           
  Partials               ?      19730
Flag Coverage Δ
unit 72.2668% <76.9230%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3162% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-18 10:56:07.956384384 +0000 UTC m=+181856.704007496: ☑️ agreed by Leavrth.
  • 2024-02-19 02:29:13.858663024 +0000 UTC m=+237842.606286120: ☑️ agreed by YuJuncen.

bb7133
bb7133 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonn7
Copy link

easonn7 commented Feb 19, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, D3Hunter, easonn7, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit dbc2581 into pingcap:release-7.5 Feb 19, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 19, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees

No one assigned

Labels

approved do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BornChanger @easonn7 @bb7133 @D3Hunter @YuJuncen @Leavrth @ti-chi-bot