Skip to content

fix(tsconfig): only attach an auto-discovered tsconfig to a file it owns#1220

Merged
Boshen merged 1 commit into
oxc-project:mainfrom
shulaoda:06-18-fix_tsconfig_only_attach_an_auto-discovered_tsconfig_to_a_file_it_owns
Jun 17, 2026
Merged

fix(tsconfig): only attach an auto-discovered tsconfig to a file it owns#1220
Boshen merged 1 commit into
oxc-project:mainfrom
shulaoda:06-18-fix_tsconfig_only_attach_an_auto-discovered_tsconfig_to_a_file_it_owns

Conversation

@shulaoda

@shulaoda shulaoda commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Related to #1154

Summary

Auto-discovery applied a tsconfig.json to files it did not actually own, leaking that project's paths/baseUrl. This tightens discovery to real ownership, matching tsserver and typescript-go.

What changed

  • find_tsconfig_auto no longer falls back to the topmost ancestor tsconfig.json when nothing owns the file; it returns None.
  • claims_ownership_of no longer claims an extensionless importer by proximity; the path goes through normal ownership (files/include/references).

Why

Studied both reference implementations: a file owned by no project (via files, include, or project references) goes to an inferred project with no paths — neither returns an ancestor's config, and neither has any "config for a directory" notion (both always operate on a concrete file). A files entry is a literal exact-path match, so an extensionless file listed in files is still owned by the config that lists it (even an ancestor), not the nearest one.

Tests

  • extensionless_file_owned_via_files_array (new): an extensionless file is owned by the outer config that lists it in files, not the nearer tsconfig.json — the outer @x/* alias applies, the nearer @y/* does not.
  • tsconfck::part_of_solution: a .ts excluded from the only referenced project (files: ["src/foo.ts"]) is now owned by nobody (None), not the solution root.
  • solution_style_non_ts_extensions / solution_style_nested_non_ts_walks_up: an unowned .css / allowJs-off .js now resolves to no config instead of the outermost ancestor.
  • The shared discovery harness resolves from real owned .ts importer files instead of bare directories.

@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 18 untouched benchmarks
⏩ 5 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
pm/pnpm-hoisted 1 ms 1.1 ms -3.67%
pm/bun-flat 902.3 µs 934.7 µs -3.46%
pm/npm-flat 964.6 µs 920.3 µs +4.81%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing shulaoda:06-18-fix_tsconfig_only_attach_an_auto-discovered_tsconfig_to_a_file_it_owns (27a1b40) with main (f4bd0ee)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen self-assigned this Jun 17, 2026
@Boshen Boshen merged commit 110bb35 into oxc-project:main Jun 17, 2026
15 checks passed
@oxc-guard oxc-guard Bot mentioned this pull request Jun 17, 2026
Boshen pushed a commit that referenced this pull request Jun 18, 2026
## 🤖 New release

* `oxc_resolver`: 11.21.2 -> 11.21.3
* `oxc_resolver_napi`: 11.21.2 -> 11.21.3

<details><summary><i><b>Changelog</b></i></summary><p>

## `oxc_resolver`

<blockquote>

##
[11.21.3](v11.21.2...v11.21.3)
- 2026-06-18

### <!-- 1 -->🐛 Bug Fixes

- *(tsconfig)* only attach an auto-discovered tsconfig to a file it owns
([#1220](#1220)) (by
@shulaoda)

### <!-- 2 -->🚜 Refactor

- outline normalize_with to reduce binary size
([#1222](#1222)) (by
@Boshen)

### Contributors

* @Boshen
* @shulaoda
</blockquote>



</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: oxc-guard[bot] <276638029+oxc-guard[bot]@users.noreply.github.com>
shulaoda added a commit to rolldown/rolldown that referenced this pull request Jun 18, 2026
…9845)

Related to #9841

## What

Updates the `tsconfig` auto-discovery documentation (`packages/rolldown/src/options/docs/tsconfig.md`, injected into the `tsconfig` option's JSDoc) to reflect two oxc-resolver fixes that already ship in the version Rolldown uses (`11.21.3`).

## Why

The docs still described oxc-resolver's previous behavior, which no longer matches what the resolver does.

### 1. Fallback for unowned files (oxc-project/oxc-resolver#1220)

Previously, when no `tsconfig.json` owned a file, the resolver fell back to the outermost (topmost) ancestor `tsconfig.json`, leaking its `paths`/`baseUrl` to unrelated files. It now applies no config in that case (an inferred project with no path mapping), matching TypeScript and typescript-go.

Doc change:

> If no `tsconfig.json` owns the file, no config is applied (no `paths`/`baseUrl`), matching TypeScript.

### 2. Explicit non-TS extensions in `include` (oxc-project/oxc-resolver#1213)

The extension filter used to reject any non-TS/JS file up front, so an explicitly listed extension such as `src/**/*.vue` never matched. The filter now applies only to the default `**/*`-style globs: a bare/omitted `include` still matches only TS/JS, while an entry naming an explicit extension matches verbatim. This lets a `.vue` (or other non-TS) file pick up the project's `paths`/`baseUrl`.

This file-matching rule is general (it applies to both the root tsconfig and referenced projects), so it is now documented as a standalone paragraph instead of being buried in the `references` section:

> Whether a `files`/`include` entry matches a file depends on its extension: by default only TypeScript files (`.ts`/`.tsx`/`.mts`/`.cts`) match, plus `.js`/`.jsx`/`.mjs`/`.cjs` when `allowJs` is enabled. An entry that names an explicit extension (for example `src/**/*.vue`) matches that extension verbatim, so a non-TS file can be owned by the project and pick up its `paths`/`baseUrl`.
shulaoda added a commit to rolldown/rolldown that referenced this pull request Jun 18, 2026
## [1.1.2] - 2026-06-18

### 📝 Notable tsconfig behavior changes

These ship via the `oxc_resolver` 11.21.3 bump (#9841) and affect `resolve.tsconfigPaths` (Vite 8 resolves through oxc-resolver):

- **Honor explicit non-TS extensions in `include`** (oxc-project/oxc-resolver#1213). `compilerOptions.paths` now resolve for importers whose extension is explicitly listed in a tsconfig's `include` (e.g. `src/**/*.vue`, `src/**/*.svelte`). Previously oxc-resolver filtered importers by extension before evaluating the `include` globs, so a `.vue`/`.svelte` file listed in `include` never matched its project and its `paths` were skipped. This unblocks the default create-vite Vue + TS layout (a solution-style root plus a referenced `tsconfig.app.json` that declares `paths` and `include: ["src/**/*.ts", "src/**/*.vue"]`). Matches vue-tsc and svelte-check, which register these extensions via TypeScript's `extraFileExtensions`.
- **No fallback to the outermost tsconfig in auto-discovery** (oxc-project/oxc-resolver#1220). Auto-discovery no longer attaches the topmost ancestor `tsconfig.json` to a file that no project actually owns (via `files` / `include` / project references). Previously such a file inherited the outermost ancestor's `paths` / `baseUrl`, leaking aliases into files that project does not own. oxc-resolver now returns no config in that case, matching tsserver / typescript-go, which route such files to an inferred project with no aliases.

### 🚀 Features

- add option named for invalid return type errors for more places (#9846) by @shulaoda
- add option names for invalid return type errors (#9821) by @sapphi-red
- transform: infer decorator strictNullChecks from tsconfig (#9590) by @kylecannon
- expose React Compiler options for rolldown and Vite users (#9801) by @Boshen
- tracing: gate chrome-json trace layer behind `chrome-tracing` feature (#9773) by @hyf0
- dev: align test-dev-server with Vite dev server (#9668) by @h-a-n-a

### 🐛 Bug Fixes

- plugin_timings: point doc link to existing checks reference page (#9837) by @hyf0
- generator: correct contradictory panic message in cjs cross-chunk symbol lookup (#9836) by @hyf0
- esm: preserve with clause on export * from external (#9796) by @hyf0
- Make external_import_binding_merger deterministic (#9755) by @naruaway
- surface invalid `manualCodeSplitting` group `test` regex as an error (#9792) by @shulaoda
- avoid panic on `output.file` without a file name (#9789) by @shulaoda
- avoid O(N^2) rendering of high-volume diagnostics (#9748) (#9749) by @IWANABETHATGUY
- avoid panic on JSON numbers outside f64 range (#9788) by @shulaoda
- deps: bump mimalloc-safe to 0.1.63 to fix worker_threads segfault (#9785) by @shulaoda
- cache ESM evaluation errors (#9784) by @sapphi-red
- wrap node require helper in pure IIFE (#9783) by @kb019
- lazy-barrel: load locally-used imports on a re-exported record (#9757) by @shulaoda
- avoid dangling wrapped-ESM init call across chunks (#9502) (#9717) by @IWANABETHATGUY
- dev: detect same-second rewrites in CI poll watcher (#9736) by @h-a-n-a
- dev: force rebuild after HMR errors (#9686) by @h-a-n-a
- dev: print build errors on browser refresh after a failed build (#9652) by @h-a-n-a

### 🚜 Refactor

- single-source the chunk $N symbol-naming algorithm (#9831) by @Dunqing
- simplify common_dir helper (#9857) by @IWANABETHATGUY
- drop commondir crate in favor of in-house helper (#9849) by @Boshen
- binding: extract helpers from normalize_binding_options (#9842) by @Boshen
- move rolldown_filter_analyzer to tasks and scope oxc cfg feature (#9839) by @Boshen
- options: merge manualCodeSplitting into codeSplitting object form (#9805) by @IWANABETHATGUY
- options: support codeSplitting object form in CodeSplittingMode (#9804) by @IWANABETHATGUY
- diagnostic: reuse ByteLocator for per-source line lookup (#9762) by @IWANABETHATGUY
- remove redundant Arc around tracing spans (#9778) by @camc314
- remove unnecessary `Arc` around sourcemap sender (#9777) by @camc314
- rolldown_plugin_vite_wasm_fallback: remove the plugin (#9775) by @sapphi-red
- binding: remove infer-able `napi(ts_type)` (#9737) by @sapphi-red
- remove preprocessor span dedup (#9734) by @hyf0
- identify AST nodes by NodeId instead of Span/Address (#9609) by @IWANABETHATGUY

### 📚 Documentation

- tsconfig: align auto-discovery docs with oxc-resolver behavior (#9845) by @shulaoda
- relocate meta/design to internal-docs, split design from implementation (#9826) by @h-a-n-a
- meta: add options normalization design doc (#9818) by @IWANABETHATGUY
- document why the napi tracing feature is enabled (#9766) by @Boshen
- dev: move test-dev-server test guidance into the testing docs (#9809) by @h-a-n-a

### ⚡ Performance

- drop unused regex unicode property tables from the binding (#9848) by @Boshen
- drop urlencoding crate in favor of percent-encoding (#9851) by @Boshen
- drop owo-colors supports-colors feature in vite reporter (#9824) by @Boshen
- skip enum member value extraction for non-TypeScript modules (#9840) by @shulaoda
- rolldown: use unstable sort for itertools sorted_by at unique-key sites (#9827) by @Boshen
- cheaper deterministic ordering in external import binding merger (#9810) by @IWANABETHATGUY
- disable idna's ICU backend by pinning idna_adapter to 1.0.0 (-129 KB) (#9811) by @Boshen
- size: use unstable sort where stability is unneeded (#9803) by @Boshen
- remove num-format dependency from vite reporter (#9795) by @Boshen
- reduce js callback error size (#9776) by @Boshen
- rolldown_error: remove Debug supertrait from BuildEvent (#9798) by @Boshen
- reduce plugin hook order code size (#9761) by @Boshen
- deps: disable `infer` default features to reduce binary size (#9765) by @Boshen
- reduce pluginable monomorphization size (#9771) by @Boshen
- avoid rebuilding replace plugin values (#9764) by @Boshen
- defer link-stage-output drop to rayon workers after output is produced (#9733) by @Brooooooklyn
- tree-shaking: hoist already-included guard to call sites in inclusion DFS (#9738) by @Brooooooklyn
- renamer: dedup before allocating the owned name in add_symbol_in_root_scope (#9740) by @Brooooooklyn

### 🧪 Testing

- allocs: track allocation counts for rolldown_sourcemap (#9835) by @hyf0
- bench: add CodSpeed micro-benchmarks for rolldown_sourcemap (#9834) by @hyf0
- add cjs named export mutation test (#9823) by @sapphi-red
- dev: restore shared-page reliability conventions in AGENTS.md (#9786) by @h-a-n-a
- dev: add `AGENTS.md` test guidance for agents (#9763) by @h-a-n-a
- dev: split out initial-build-error into its own playground (#9772) by @h-a-n-a
- dev: align e2e suite with Vite and parallelize playgrounds (#9759) by @h-a-n-a
- remove unnecessary module namespace object JSON serializations in tests (#9725) by @sapphi-red
- use `assert.deepStrictEqual` instead of `assert.deepEqual` by using `assert/strict` instead of `assert` (#9724) by @sapphi-red
- hmr: add test case for #5301 (#5302) by @sapphi-red
- dev: add tests for dev-engine principles (#9720) by @h-a-n-a
- dev: align dev-engine test harness with Vite (#9684) by @h-a-n-a

### ⚙️ Miscellaneous Tasks

- deps: update napi to 3.9.3 (#9862) by @shulaoda
- deps: update oxc to 0.137.0 (#9856) by @Boshen
- re-enable default lld linker on x86_64-unknown-linux-gnu (#9855) by @Boshen
- deps: bump vite-plus to 0.2.1 (#9850) by @Boshen
- skills: translate _config.json when encoding rolldown REPL links (#9847) by @IWANABETHATGUY
- deps: update oxc_resolver and oxc_resolver_napi to 11.21.3 (#9841) by @Boshen
- pin vite-plus (vp) CLI to 0.1.24 in setup-vp (#9830) by @Boshen
- add crate/package-level CODEOWNERS (#9819) by @IWANABETHATGUY
- drop unused derive_more display feature from rolldown_plugin (#9820) by @Boshen
- remove auto-assign PR workflow (#9807) by @IWANABETHATGUY
- deps: update rollup submodule for tests to v4.62.0 (#9780) by @rolldown-guard[bot]
- deps: update esbuild for tests to 0.28.1 (#9779) by @rolldown-guard[bot]
- deps: update test262 submodule for tests (#9781) by @rolldown-guard[bot]
- deps: update oxc to 0.136.0 (#9770) by @Boshen
- add pull request template (#9756) by @sapphi-red
- clarify `rolldown_plugin_vite_*` is compatible for the same minor (#9774) by @sapphi-red
- deps: update github actions (#9745) by @renovate[bot]
- deps: update rust crates (#9747) by @renovate[bot]
- deps: update napi to v3.9.2 (#9744) by @renovate[bot]
- deps: update npm packages (#9746) by @renovate[bot]
- deps: update @napi-rs/cli and emnapi deps (#9741) by @Brooooooklyn
- generator: fix `vp fmt` on Windows (#9727) by @sapphi-red
- ban importing from `assert` and recommend `assert/strict` (#9726) by @sapphi-red

### ❤️ New Contributors

* @naruaway made their first contribution in [#9755](#9755)
* @kb019 made their first contribution in [#9783](#9783)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants