Skip to content

fix(formatter): fix erroneous formatting inside a template literal with parentheses#22262

Merged
leaysgur merged 2 commits into
oxc-project:mainfrom
JoviDeCroock:fix-erroneous-reformat-in-temp-lit
May 13, 2026
Merged

fix(formatter): fix erroneous formatting inside a template literal with parentheses#22262
leaysgur merged 2 commits into
oxc-project:mainfrom
JoviDeCroock:fix-erroneous-reformat-in-temp-lit

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Contributor

Fixes #21941

Looks like we were mainly breaking this with FormatLeadingComments::Comments(leading_comments).fmt(f); this mainly caused us to print the interpolation at the wrong layer.

  1. FormatTemplateExpression saw the directive as a leading comment for the JSX element
  2. It printed that comment immediately
  3. Then the JSX formatter printed its reconstructed (

I copied the tests verbatim from the issue

@JoviDeCroock JoviDeCroock force-pushed the fix-erroneous-reformat-in-temp-lit branch from f1fbc1c to dd9232f Compare May 8, 2026 19:27
@codspeed-hq

codspeed-hq Bot commented May 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing JoviDeCroock:fix-erroneous-reformat-in-temp-lit (8250ae5) with main (f44b6c8)2

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (f6b22f8) during the generation of this report, so f44b6c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the A-formatter Area - Formatter label May 9, 2026
@JoviDeCroock JoviDeCroock force-pushed the fix-erroneous-reformat-in-temp-lit branch from 138aa43 to eab7214 Compare May 12, 2026 16:11
@JoviDeCroock JoviDeCroock force-pushed the fix-erroneous-reformat-in-temp-lit branch from eab7214 to 8250ae5 Compare May 12, 2026 19:24
@leaysgur

Copy link
Copy Markdown
Member

Thank you!

@leaysgur leaysgur merged commit ac5f120 into oxc-project:main May 13, 2026
35 checks passed
graphite-app Bot pushed a commit that referenced this pull request May 13, 2026
Also follow up on #22262

#22262 fixes JSX and parens for leading comments. However, trailing comments are still printed outside of the parens, which is a diff vs Prettier.

This includes updates to the test fixtures.
overlookmotel added a commit that referenced this pull request May 15, 2026
# Oxlint
### 🚀 Features

- 5478fb5 linter/jsdoc: Implement `require-throws-description` rule
(#22386) (Mikhail Baev)
- b46d4de linter: Add `--debug` options and add per-rule timing info
(#22282) (camchenry)
- c73225e linter/eslint: Implement `prefer-arrow-callback` rule (#22312)
(박천(Cheon Park))
- de82b59 linter: Add support for `eslint-plugin-jsx-a11y-x` (#22356)
(mehm8128)
- b170da3 linter: Implement no-implicit-globals (#22249) (Jovi De
Croock)
- f44b6c8 linter: Fill schemas `DummyRuleMap` with built-in rules
(#22288) (Sysix)
- 5cdb80d linter/jsx-a11y/: Implement
no-interactive-element-to-noninteractive-role (#22332) (anarefolio)
- 2749422 linter/jsx-a11y: Add no-noninteractive-element-interactions
(#22337) (Pablo Tovar)
- ba2a1d3 linter/jsdoc: Implement `require-throws-type` rule (#22358)
(Mikhail Baev)
- d90729d linter/jsx-a11y: Implement control-has-associated-label
(#21985) (mehm8128)
- 1d04903 linter/jsdoc: Implement `require-yields-type` rule (#22331)
(Mikhail Baev)

### 🐛 Bug Fixes

- 04c4609 linter/no-nullable-type-assertion-style: Mark as suggestion
(#22450) (camc314)
- 1c2b7ec linter/no-unused-vars: Handle shadowed self assignments
(#22387) (camc314)
- 9faa1d5 linter/no-noninteractive-tabindex: Check conditional
expressions (#22435) (camc314)
- 0854b3a linter/prefer-arrow-callback: Preserve TSX generic arrows in
fixer (#22434) (camc314)
- 410b814 linter: Supply `source_type` to codegen fixer (#22433)
(camc314)
- 3c1bb6f linter: Skip per-node dispatch for run_once-only rules in
large files (#22398) (Connor Shea)
- 5206cde linter/no-unused-vars: Improve type-only rest parameters
diagnostic (#22385) (camc314)
- c9a22b5 linter/consistent-function-scoping: Allow imported bindings
(#22384) (camc314)
- c1e966d linter: Report type-only unused parameters in no-unused-vars
(#22368) (camchenry)
- 4818d98 linter: Check whether path is under root before ignoring it
(#20101) (Leonabcd123)
- 41fcdcf linter: Fix rule count not including override rules (#19898)
(Daniel Osmond)
- 59b4f0e linter: Fix 'explicit-module-boundary-types' false positive
with 'allowOverloadFunctions' (#22341) (camchenry)

### ⚡ Performance

- 6d42395 linter: Narrow no-unsafe-optional-chaining dispatch (#22437)
(camchenry)
- 08595fb linter: Optimize no-unreachable (#22397) (camchenry)
- 3b46a8d linter: Optimize `no-loss-of-precision` (#22395) (camchenry)
- b3e2dc9 linter: Optimize `oxc/bad-array-method-on-arguments` (#22393)
(camchenry)

### 📚 Documentation

- dcbf62c linter: Remove some duplicate spaces (#22359) (camc314)
# Oxfmt
### 💥 BREAKING CHANGES

- 21bb5d1 oxfmt: [**BREAKING**] Avoid config pre-scan (#22258)
(leaysgur)

### 🐛 Bug Fixes

- 441d724 oxfmt: Fix "race probe" logic with unit tests (#22378)
(leaysgur)
- e49ee26 formatter: Respect `singleQuote` for jsdoc `import()` type
paths (#22353) (Colin Lienard)
- 43b9978 formatter/sort_imports: Treat subpath imports as internal
(#22440) (leaysgur)
- 7c5cfa0 formatter: Handle jsx trailing comment with parens (#22370)
(leaysgur)
- ac5f120 formatter: Fix erroneous formatting inside a template literal
with parentheses (#22262) (Jovi De Croock)
- 3c53a95 formatter/sort_imports: Handle ignore comment as boundary
(#22369) (leaysgur)
- 4dd83dd oxfmt: Send expandedStates variants as shared refs (#22366)
(leaysgur)
- 055cc61 formatter: Expand JSX logical chain with leading line comment
(#22346) (leaysgur)
- 8046222 formatter: Preserve type alias comment break (#22261) (Jovi De
Croock)

### ⚡ Performance

- 123c493 oxfmt: Reduce more syscalls (#22380) (leaysgur)

Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formatter: oxfmt moves eslint-disable-next-line above parenthesized JSX expression in template interpolation

3 participants