fix(linter): check whether path is under root before ignoring it by Leonabcd123 · Pull Request #20101 · oxc-project/oxc

Leonabcd123 · 2026-03-07T10:41:12Z

Bug Description

When ignorePatterns is set in the cwd .oxlintrc.json file, and we try to lint a file outside of the cwd, we get a panic:

thread 'tokio-runtime-worker' (171644) panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ignore-0.4.25/src/gitignore.rs:232:9:
path is expected to be under the root
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This happens because of this line:

oxc/crates/oxc_linter/src/config/ignore_matcher.rs

Line 65 in 4ea8f9a

.is_some_and(|base| base.matched_path_or_any_parents(path, false).is_ignore())

We call matched_path_or_any_parents (which can panic if path is not under root, see https://docs.rs/ignore/latest/ignore/gitignore/struct.Gitignore.html#panics).

Steps to reproduce

mkdir ~/test1
mkdir ~/test2
cd ~/test1 && echo '{ "ignorePatterns": ["node_modules"] }' > .oxlintrc.json
touch ~/test2/test.js
oxlint ~/test2

Solution

To fix this, we check whether path is under the root config's path before deciding whether to ignore it or not. If it isn't, we don't ignore it, otherwise we keep current behavior. This matches oxfmt's is_path_ignored:

oxc/apps/oxfmt/src/core/config.rs

Lines 160 to 166 in fb3067c

    
               pub fn is_path_ignored(&self, path: &Path, is_dir: bool) -> bool { 
        
                   self.ignore_glob.as_ref().is_some_and(|glob| { 
        
                       // `matched_path_or_any_parents()` panics if path is not under the glob's root. 
        
                       path.starts_with(glob.path()) 
        
                           && glob.matched_path_or_any_parents(path, is_dir).is_ignore() 
        
                   }) 
        
               }

Fixes #22269

codspeed-hq · 2026-04-05T20:40:23Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks¹

_{Comparing Leonabcd123:fix-panic-with-ignore-patterns (ccf66a8) with main (41fcdcf)}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314

Hi @Leonabcd123,

Thanks for this PR.

Could you write a failing test for this first so we can assert that the behaviour never regresses in future?

Thanks

riadafridishibly · 2026-05-06T19:20:07Z

I was about to file an issue, then I saw this PR. I hope this one gets resolved soon. Thanks.

camc314

thank yoU!

# Oxlint ### 🚀 Features - 5478fb5 linter/jsdoc: Implement `require-throws-description` rule (#22386) (Mikhail Baev) - b46d4de linter: Add `--debug` options and add per-rule timing info (#22282) (camchenry) - c73225e linter/eslint: Implement `prefer-arrow-callback` rule (#22312) (박천(Cheon Park)) - de82b59 linter: Add support for `eslint-plugin-jsx-a11y-x` (#22356) (mehm8128) - b170da3 linter: Implement no-implicit-globals (#22249) (Jovi De Croock) - f44b6c8 linter: Fill schemas `DummyRuleMap` with built-in rules (#22288) (Sysix) - 5cdb80d linter/jsx-a11y/: Implement no-interactive-element-to-noninteractive-role (#22332) (anarefolio) - 2749422 linter/jsx-a11y: Add no-noninteractive-element-interactions (#22337) (Pablo Tovar) - ba2a1d3 linter/jsdoc: Implement `require-throws-type` rule (#22358) (Mikhail Baev) - d90729d linter/jsx-a11y: Implement control-has-associated-label (#21985) (mehm8128) - 1d04903 linter/jsdoc: Implement `require-yields-type` rule (#22331) (Mikhail Baev) ### 🐛 Bug Fixes - 04c4609 linter/no-nullable-type-assertion-style: Mark as suggestion (#22450) (camc314) - 1c2b7ec linter/no-unused-vars: Handle shadowed self assignments (#22387) (camc314) - 9faa1d5 linter/no-noninteractive-tabindex: Check conditional expressions (#22435) (camc314) - 0854b3a linter/prefer-arrow-callback: Preserve TSX generic arrows in fixer (#22434) (camc314) - 410b814 linter: Supply `source_type` to codegen fixer (#22433) (camc314) - 3c1bb6f linter: Skip per-node dispatch for run_once-only rules in large files (#22398) (Connor Shea) - 5206cde linter/no-unused-vars: Improve type-only rest parameters diagnostic (#22385) (camc314) - c9a22b5 linter/consistent-function-scoping: Allow imported bindings (#22384) (camc314) - c1e966d linter: Report type-only unused parameters in no-unused-vars (#22368) (camchenry) - 4818d98 linter: Check whether path is under root before ignoring it (#20101) (Leonabcd123) - 41fcdcf linter: Fix rule count not including override rules (#19898) (Daniel Osmond) - 59b4f0e linter: Fix 'explicit-module-boundary-types' false positive with 'allowOverloadFunctions' (#22341) (camchenry) ### ⚡ Performance - 6d42395 linter: Narrow no-unsafe-optional-chaining dispatch (#22437) (camchenry) - 08595fb linter: Optimize no-unreachable (#22397) (camchenry) - 3b46a8d linter: Optimize `no-loss-of-precision` (#22395) (camchenry) - b3e2dc9 linter: Optimize `oxc/bad-array-method-on-arguments` (#22393) (camchenry) ### 📚 Documentation - dcbf62c linter: Remove some duplicate spaces (#22359) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 21bb5d1 oxfmt: [**BREAKING**] Avoid config pre-scan (#22258) (leaysgur) ### 🐛 Bug Fixes - 441d724 oxfmt: Fix "race probe" logic with unit tests (#22378) (leaysgur) - e49ee26 formatter: Respect `singleQuote` for jsdoc `import()` type paths (#22353) (Colin Lienard) - 43b9978 formatter/sort_imports: Treat subpath imports as internal (#22440) (leaysgur) - 7c5cfa0 formatter: Handle jsx trailing comment with parens (#22370) (leaysgur) - ac5f120 formatter: Fix erroneous formatting inside a template literal with parentheses (#22262) (Jovi De Croock) - 3c53a95 formatter/sort_imports: Handle ignore comment as boundary (#22369) (leaysgur) - 4dd83dd oxfmt: Send expandedStates variants as shared refs (#22366) (leaysgur) - 055cc61 formatter: Expand JSX logical chain with leading line comment (#22346) (leaysgur) - 8046222 formatter: Preserve type alias comment break (#22261) (Jovi De Croock) ### ⚡ Performance - 123c493 oxfmt: Reduce more syscalls (#22380) (leaysgur) Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>

Check whether path is under root

86da30c

Leonabcd123 requested a review from camc314 as a code owner March 7, 2026 10:41

github-actions Bot added A-linter Area - Linter C-bug Category - Bug labels Mar 7, 2026

camc314 self-assigned this Mar 9, 2026

Leonabcd123 and others added 3 commits March 12, 2026 09:12

Merge branch 'main' into fix-panic-with-ignore-patterns

789a9f2

Merge branch 'main' into fix-panic-with-ignore-patterns

122de89

[autofix.ci] apply automated fixes

2e97aa8

camc314 and others added 2 commits April 5, 2026 22:22

Merge branch 'main' into fix-panic-with-ignore-patterns

7ac5a19

Merge branch 'main' into fix-panic-with-ignore-patterns

69f36b9

camc314 requested changes Apr 9, 2026

View reviewed changes

Leonabcd123 and others added 5 commits April 9, 2026 18:44

Add test

4ed00bb

[autofix.ci] apply automated fixes

cfc8b4d

Clarify

d4a20b2

Improve test

df80a91

Merge branch 'main' into fix-panic-with-ignore-patterns

7a02181

Leonabcd123 requested a review from camc314 April 9, 2026 16:07

Leonabcd123 added 4 commits April 10, 2026 09:35

Change comment

2a6bb57

Rename test

8f6fa8f

Merge branch 'main' into fix-panic-with-ignore-patterns

8639b5d

Improve test

962ccd8

camchenry self-assigned this May 12, 2026

camc314 approved these changes May 12, 2026

View reviewed changes

Merge branch 'main' into fix-panic-with-ignore-patterns

ccf66a8

camc314 merged commit 4818d98 into oxc-project:main May 12, 2026
28 checks passed

Leonabcd123 deleted the fix-panic-with-ignore-patterns branch May 12, 2026 18:03

oxc-guard Bot mentioned this pull request May 15, 2026

release(apps): oxlint v1.65.0 && oxfmt v0.50.0 #22458

Merged

Dunqing mentioned this pull request May 17, 2026

fix(transformer/typescript): inline const enum members through type-cast wrappers #22500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter): check whether path is under root before ignoring it#20101

fix(linter): check whether path is under root before ignoring it#20101
camc314 merged 16 commits into
oxc-project:mainfrom
Leonabcd123:fix-panic-with-ignore-patterns

Leonabcd123 commented Mar 7, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

camc314 left a comment

Uh oh!

riadafridishibly commented May 6, 2026

Uh oh!

camc314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	pub fn is_path_ignored(&self, path: &Path, is_dir: bool) -> bool {
	self.ignore_glob.as_ref().is_some_and(\|glob\| {
	// `matched_path_or_any_parents()` panics if path is not under the glob's root.
	path.starts_with(glob.path())
	&& glob.matched_path_or_any_parents(path, is_dir).is_ignore()
	})
	}

Uh oh!

Conversation

Leonabcd123 commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug Description

Steps to reproduce

Solution

Uh oh!

codspeed-hq Bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

riadafridishibly commented May 6, 2026

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Leonabcd123 commented Mar 7, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 5, 2026 •

edited

Loading