refactor(allocator): combine Arena::new_chunk_memory_details into Arena::new_chunk#21795
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 26, 2026
Conversation
This was referenced Apr 26, 2026
Merged
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the allocator’s chunk-allocation path by merging the “compute new chunk sizing” step into the actual Arena::new_chunk allocation routine, reducing indirection at call sites while keeping the same sizing logic.
Changes:
- Removed
NewChunkMemoryDetailsand folded its computation intoArena::new_chunk. - Updated call sites (
try_with_min_align_and_capacity, slow allocation path) to call the unifiednew_chunkdirectly. - Updated comments/tests to reference
Arena::new_chunkas the source of the chunk-sizing formula.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_allocator/src/arena/tests.rs | Updates test commentary to point at the unified Arena::new_chunk sizing logic. |
| crates/oxc_allocator/src/arena/create.rs | Removes NewChunkMemoryDetails and merges sizing + allocation into new_chunk; updates constructor to call the unified API. |
| crates/oxc_allocator/src/arena/alloc_impl.rs | Simplifies the slow-path growth loop to call unified new_chunk directly. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
b56ad4b to
0423be8
Compare
e689974 to
75bb873
Compare
Contributor
Merge activity
|
…Arena::new_chunk` (#21795) Refactor of `Arena`. `Arena::new_chunk_memory_details` and `Arena::new_chunk` are always called together. Combine them into a single function. This makes the call sites shorter and clearer.
75bb873 to
5e7dbac
Compare
0423be8 to
481b75f
Compare
Base automatically changed from
om/04-26-refactor_allocator_improve_safety_of_dealloc_chunk_list_
to
main
April 26, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of
Arena.Arena::new_chunk_memory_detailsandArena::new_chunkare always called together. Combine them into a single function. This makes the call sites shorter and clearer.