Skip to content

test(allocator): reformat comments#21747

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-25-test_allocator_reformat_comments
Apr 26, 2026
Merged

test(allocator): reformat comments#21747
graphite-app[bot] merged 1 commit intomainfrom
om/04-25-test_allocator_reformat_comments

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 25, 2026 •
edited
Loading

Just reformat some comments to make them take up less lines.

@overlookmotel overlookmotel mentioned this pull request Apr 25, 2026
Merged
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 25, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 25, 2026
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 25, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-25-test_allocator_reformat_comments (82aad73) with om/04-25-refactor_allocator_remove_pointless_option_in_arena_new_chunk_memory_details_ (7f7df2b)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel overlookmotel self-assigned this Apr 25, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 25, 2026 13:42
Copilot AI review requested due to automatic review settings April 25, 2026 13:42
@overlookmotel overlookmotel added C-docs Category - Documentation. Related to user-facing or internal documentation A-allocator Area - Allocator labels Apr 25, 2026
Copilot AI reviewed Apr 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reformats comments in the allocator arena quickcheck test helper to reduce line count while preserving meaning.

Changes:

  • Reflowed module-level doc comment about MIRI behavior into fewer lines.
  • Condensed inline comments describing QUICKCHECK_TESTS handling and MIRI iteration limiting.

@overlookmotel overlookmotel force-pushed the om/04-25-test_allocator_reformat_comments branch from ddff848 to fb496b9 Compare April 25, 2026 14:00
@overlookmotel overlookmotel force-pushed the om/04-25-refactor_allocator_remove_pointless_option_in_arena_new_chunk_memory_details_ branch from 2b2a93a to 1a1387a Compare April 25, 2026 14:00
@overlookmotel overlookmotel mentioned this pull request Apr 25, 2026
Merged
@overlookmotel overlookmotel force-pushed the om/04-25-refactor_allocator_remove_pointless_option_in_arena_new_chunk_memory_details_ branch from 1a1387a to 6453ad5 Compare April 25, 2026 15:48
@overlookmotel overlookmotel force-pushed the om/04-25-test_allocator_reformat_comments branch 2 times, most recently from e97808e to ab5c180 Compare April 26, 2026 11:45
@overlookmotel overlookmotel force-pushed the om/04-25-refactor_allocator_remove_pointless_option_in_arena_new_chunk_memory_details_ branch from 6453ad5 to dfeb5e2 Compare April 26, 2026 11:45
This was referenced Apr 26, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel overlookmotel mentioned this pull request Apr 26, 2026
Merged
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 26, 2026 •
edited
Loading

Merge activity

@overlookmotel
test(allocator): reformat comments (#21747)
82aad73 
Just reformat some comments to make them take up less lines.
@graphite-app graphite-app Bot force-pushed the om/04-25-refactor_allocator_remove_pointless_option_in_arena_new_chunk_memory_details_ branch from dfeb5e2 to 7f7df2b Compare April 26, 2026 21:46
@graphite-app graphite-app Bot force-pushed the om/04-25-test_allocator_reformat_comments branch from ab5c180 to 82aad73 Compare April 26, 2026 21:47
Base automatically changed from om/04-25-refactor_allocator_remove_pointless_option_in_arena_new_chunk_memory_details_ to main April 26, 2026 21:59
@graphite-app graphite-app Bot merged commit 82aad73 into main Apr 26, 2026
38 checks passed
@graphite-app graphite-app Bot deleted the om/04-25-test_allocator_reformat_comments branch April 26, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-allocator Area - Allocator C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel