fix(agents): move session write lock into owned session runtime by steipete · Pull Request #87409 · openclaw/openclaw

steipete · 2026-05-27T20:52:59Z

Summary

Follow-up to fix(agents): avoid session event queue self-wait #86123: move the session write-lock seam out of obsolete private session fields and into owned createAgentSession / AgentSession runtime code.
Pass the embedded attempt session write lock into session creation, then fence message persistence, write-capable extension/provider hooks, compaction, and pre-tool execution.
Delete the _handleAgentEvent / _agentEventQueue wrapper path and its tests; current agent-core awaits listeners directly.

Verification

pnpm exec oxfmt --write src/agents/sessions/agent-session.ts src/agents/sessions/sdk.test.ts
git diff --check
node scripts/run-oxlint.mjs --tsconfig config/tsconfig/oxlint.core.json src/agents/sessions/agent-session.ts src/agents/sessions/sdk.ts src/agents/sessions/sdk.test.ts src/agents/embedded-agent-runner/run/attempt.ts src/agents/embedded-agent-runner/run/attempt-session.ts src/agents/embedded-agent-runner/run/attempt.session-lock.ts src/agents/embedded-agent-runner/run/attempt.session-lock.test.ts --threads=8
OPENCLAW_VITEST_INCLUDE_FILE=<tmpfile> node scripts/run-vitest.mjs run --config test/vitest/vitest.unit-fast.config.ts --reporter verbose
node scripts/run-vitest.mjs run --config test/vitest/vitest.agents-embedded-agent.config.ts src/agents/embedded-agent-runner/run/attempt.session-lock.test.ts --reporter verbose
.agents/skills/autoreview/scripts/autoreview --mode local --prompt 'Review rerun after fixing accepted finding: beforeToolCall now always enters the embedded session write-lock fence, even with no tool_call extension handler, before tools may execute. Check for remaining concrete session persistence/concurrency issues in the owned-session write-lock seam.'

Behavior addressed: Embedded attempts release the coarse session lock during provider streaming; stale attempts must reacquire/fence before session-file writes or before side-effectful tools execute.
Real environment tested: Local OpenClaw checkout on current origin/main (4ff944c0e8).
Exact steps or command run after this patch: Focused unit-fast session SDK tests, embedded attempt session lock tests, oxlint, diff check, and autoreview rerun listed above.
Evidence after fix: sdk.test.ts now covers message persistence under the write lock, write-capable tool hooks under the write lock, and the no-handler beforeToolCall fence; attempt.session-lock.test.ts still passes the embedded lock lifecycle suite.
Observed result after fix: Focused tests passed (sdk.test.ts: 4 tests; attempt.session-lock.test.ts: 31 tests), oxlint passed, diff check passed, autoreview clean with no accepted/actionable findings.
What was not tested: Full repository pnpm check / broad CI was not run locally.

clawsweeper · 2026-05-27T20:54:39Z

Codex review: needs real behavior proof before merge. Reviewed May 27, 2026, 5:06 PM ET / 21:06 UTC.

Summary
The branch threads an embedded session write-lock callback into createAgentSession/AgentSession, fences session writes and hooks, removes private session event/hook wrappers, and updates focused session lock tests.

PR surface: Source -224, Tests -258. Total -482 across 7 files.

Reproducibility: yes. at source level: embedded attempts release the session lock during provider streaming, then session writes and side-effectful tool paths need to reacquire/fence before mutating the transcript or executing tools. I did not run the PR tests in this read-only review.

Review metrics: 1 noteworthy metric.

Public SDK option: 1 optional CreateAgentSessionOptions field added. The type is re-exported through openclaw/plugin-sdk/agent-sessions, so the new field can become a plugin-facing compatibility contract.

Merge readiness
Overall: 🦪 silver shellfish
Proof: 🦪 silver shellfish
Patch quality: 🦐 gold shrimp
Result: blocked until real behavior proof from a real setup is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

Keep withSessionWriteLock internal or document and approve it as a public SDK contract with compatibility coverage.
Add redacted terminal/live embedded-attempt proof showing the changed lock path after provider streaming.

Proof guidance:
Needs real behavior proof before merge: The PR body lists focused tests, oxlint, diff check, and autoreview, but no after-fix real embedded attempt or live session output; add redacted terminal/live logs or a recording and update the PR body for re-review.

Risk before merge

Adding withSessionWriteLock to CreateAgentSessionOptions exposes an embedded-runner lock callback through openclaw/plugin-sdk/agent-sessions unless maintainers intentionally approve that public SDK contract.
The patch changes ownership of transcript persistence, compaction, provider hooks, and tool-hook write fencing while deleting the older queue-drain wrappers; mistakes in this path can corrupt session ordering or stall embedded attempts.
The PR body currently provides focused tests and autoreview output, but no redacted terminal/live embedded-attempt proof showing the changed runtime path after provider streaming.

Maintainer options:

Keep The Lock Runner Internal (recommended)
Move the write-lock runner out of the public CreateAgentSessionOptions surface and keep it on an internal embedded-session factory/config path.
Approve The SDK Contract
Maintainers can accept the new public option if they want plugin SDK callers to rely on this lock-runner contract and add docs/compatibility coverage for it.
Require Runtime Proof
Ask for redacted terminal/live output from an actual embedded attempt showing stale session writes and pre-tool fencing after provider streaming.

Next step before merge
Human review should decide whether the new SDK surface is intentional and require real behavior proof; the remaining blocker is not a safe automated repair contract.

Security
Cleared: No concrete security or supply-chain issue was found; the diff is limited to TypeScript runtime/tests and does not touch dependencies, workflows, package metadata, credentials, or install scripts.

Review findings

[P2] Keep the lock runner off the public session SDK — src/agents/sessions/sdk.ts:88

Review details

Best possible solution:

Keep the owned-session lock seam, but route the lock runner through an internal embedded-session creation path or explicitly approve and document it as a public SDK contract, then add real embedded-run proof before merge.

Do we have a high-confidence way to reproduce the issue?

Yes, at source level: embedded attempts release the session lock during provider streaming, then session writes and side-effectful tool paths need to reacquire/fence before mutating the transcript or executing tools. I did not run the PR tests in this read-only review.

Is this the best way to solve the issue?

Mostly, but not as submitted. Moving the lock seam into AgentSession is the right ownership direction; exposing that runner through the public session SDK needs maintainer approval or an internal-only shape.

Full review comments:

[P2] Keep the lock runner off the public session SDK — src/agents/sessions/sdk.ts:88
CreateAgentSessionOptions is re-exported through src/agents/sessions/index.ts and src/plugin-sdk/agent-sessions.ts, and package.json publishes that subpath, so adding withSessionWriteLock here makes the embedded-runner lock callback a public plugin SDK option. Keep this on an internal embedded-session factory/config path, or add explicit maintainer approval, docs, and compatibility tests for the new SDK contract before merge.
Confidence: 0.84

Overall correctness: patch is incorrect
Overall confidence: 0.82

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 09d2682cd8c3.

Label changes

Label changes:

add P2: This is a bounded agent runtime bug fix with a concrete public SDK surface concern and session-state-sensitive concurrency behavior.
add merge-risk: 🚨 compatibility: Adding withSessionWriteLock to an exported session creation options type may create a new public plugin SDK contract.
add merge-risk: 🚨 session-state: The patch changes which code owns the write lock around transcript persistence, compaction, provider hooks, and tool hooks.
add merge-risk: 🚨 availability: The patch removes old queue-drain wrappers in embedded run concurrency code where lock mistakes can hang or stall attempts.

Label justifications:

P2: This is a bounded agent runtime bug fix with a concrete public SDK surface concern and session-state-sensitive concurrency behavior.
merge-risk: 🚨 compatibility: Adding withSessionWriteLock to an exported session creation options type may create a new public plugin SDK contract.
merge-risk: 🚨 session-state: The patch changes which code owns the write lock around transcript persistence, compaction, provider hooks, and tool hooks.
merge-risk: 🚨 availability: The patch removes old queue-drain wrappers in embedded run concurrency code where lock mistakes can hang or stall attempts.
rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body lists focused tests, oxlint, diff check, and autoreview, but no after-fix real embedded attempt or live session output; add redacted terminal/live logs or a recording and update the PR body for re-review.

Evidence reviewed

PR surface:

Source -224, Tests -258. Total -482 across 7 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	5	82	306	-224
Tests	2	167	425	-258
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	7	249	731	-482

What I checked:

Repository policy applied: Root AGENTS.md was read fully; its review policy treats plugin API changes and session state as compatibility-sensitive merge risks, which applies to this PR's public SDK option and session write-lock changes. (AGENTS.md:24, 09d2682cd8c3)
Scoped agents policy applied: The agents scoped guide and embedded-runner guide were read; the embedded guide favors focused helper coverage for runner behavior while preserving production composition when slimming tests. (src/agents/embedded-agent-runner/run/AGENTS.md:1, 09d2682cd8c3)
PR adds a public session creation option: At PR head, withSessionWriteLock is added to CreateAgentSessionOptions, which is an exported session SDK type. (src/agents/sessions/sdk.ts:88, d03d521dab0f)
Session SDK is plugin-facing: Current main exports src/agents/sessions/index.ts through src/plugin-sdk/agent-sessions.ts, and package.json publishes ./plugin-sdk/agent-sessions, so CreateAgentSessionOptions is part of the plugin SDK surface. (src/plugin-sdk/agent-sessions.ts:1, 09d2682cd8c3)
PR centralizes write fencing in AgentSession: At PR head, AgentSession stores the external lock runner, wraps message-end/extension-handler events, fences tool-call hooks, and wraps manual compaction under the configured write lock. (src/agents/sessions/agent-session.ts:447, d03d521dab0f)
Current agent-core supports removing the private event queue bridge: Current main documents and implements awaited listener settlement in Agent.subscribe/processEvents, supporting the PR's stated removal of the obsolete private _agentEventQueue wrapper path. (packages/agent-core/src/agent.ts:246, 09d2682cd8c3)

Likely related people:

steipete: git blame and git log tie the current AgentSession/CreateAgentSession SDK surface, plugin SDK re-export, and much of the embedded session-lock wrapper history to the recent internal agent runtime refactor and adjacent lock work. (role: recent area contributor; confidence: high; commits: bb46b79d3c14, b01c6d4eaa0b; files: src/agents/sessions/agent-session.ts, src/agents/sessions/sdk.ts, src/plugin-sdk/agent-sessions.ts)
luoyanglang: The related merged self-wait fix changed the same embedded attempt session-lock wrapper path and is directly referenced by this PR as the follow-up context. (role: recent adjacent contributor; confidence: medium; commits: b789e71e57d9; files: src/agents/embedded-agent-runner/run/attempt.session-lock.ts, src/agents/embedded-agent-runner/run/attempt.session-lock.test.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

clawsweeper · 2026-05-27T20:59:16Z

ClawSweeper PR egg

🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat.

Where did the egg go?

The egg game starts only after the PR passes the real-behavior proof check.
Before that, no creature or rarity is rolled. The treat waits for real proof.
This is still just collectible flavor: proof affects review readiness, not creature quality.

…claw#87409) * fix(agents): move session write lock into owned session runtime * test(agents): use typed tool-call fixtures

…026.5.28) (#759) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.5.27` → `2026.5.28` | --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.5.28`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#2026528) [Compare Source](openclaw/openclaw@v2026.5.27...v2026.5.28) ##### Highlights - Agent and Codex runtime recovery is steadier: subagents keep cwd/workspace separation, hook context stays prompt-local, session locks release on timeout abort while live OpenClaw locks survive cleanup, stale restart continuations are avoided, and Codex app-server/helper failures no longer tear down shared runtime state. ([#87218](openclaw/openclaw#87218), [#86875](openclaw/openclaw#86875), [#87409](openclaw/openclaw#87409), [#87399](openclaw/openclaw#87399), [#87375](openclaw/openclaw#87375), [#88129](openclaw/openclaw#88129)) - Channel delivery and session identity got safer across outbound plugin hooks, Matrix room ids, iMessage reactions/approvals, Slack final replies, Discord recovered tool warnings, runtime-config message actions, WhatsApp profile auth roots, Telegram polling, and Microsoft Teams service URL trust checks. ([#73706](openclaw/openclaw#73706), [#75670](openclaw/openclaw#75670), [#87366](openclaw/openclaw#87366), [#87451](openclaw/openclaw#87451), [#87334](openclaw/openclaw#87334), [#84535](openclaw/openclaw#84535), [#82492](openclaw/openclaw#82492), [#83304](openclaw/openclaw#83304), [#87160](openclaw/openclaw#87160)) - Mobile and chat surfaces got a broader refresh: the iOS Pro UI, hosted push relay default, realtime Talk tab playback, Gateway chat transport, onboarding, Talk permissions, WebChat reconnect delivery, and session picker behavior now preserve more state across reconnects and empty searches. ([#87367](openclaw/openclaw#87367), [#87531](openclaw/openclaw#87531), [#87682](openclaw/openclaw#87682), [#88096](openclaw/openclaw#88096), [#88105](openclaw/openclaw#88105)) Thanks [@ngutman](https://github.com/ngutman) and [@BunsDev](https://github.com/BunsDev). - Browser, channel, and automation inputs are stricter: Browser tool timeouts, viewport/tab indices, Gateway ports, cron retry handling, Discord component ids, schema array refs, Telegram callback pages, and channel progress callbacks now reject malformed values earlier and preserve the intended delivery context. ([#82887](openclaw/openclaw#82887)) - Provider, media, and document coverage expands with Claude Opus 4.8, Fal Krea image schemas, NVIDIA featured models, MiniMax streaming music responses, encrypted PDF extraction, voice model catalogs, GitHub Copilot agent runtime support, and a Codex Supervisor plugin path for delegated Codex workflows. ([#87845](openclaw/openclaw#87845), [#87890](openclaw/openclaw#87890), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764), [#87751](openclaw/openclaw#87751), [#87794](openclaw/openclaw#87794)) - CLI, auth, doctor, and provider paths fail faster and recover more clearly: malformed numeric/version options are rejected, workspace dotenv provider credentials are ignored, heartbeat defaults, OAuth/token lifetimes, and local service startup requests are bounded, agent auth health labels are clearer, legacy `api_key` auth profiles migrate to canonical form, and restart guidance is actionable. ([#87398](openclaw/openclaw#87398), [#86281](openclaw/openclaw#86281), [#87361](openclaw/openclaw#87361), [#88133](openclaw/openclaw#88133), [#83655](openclaw/openclaw#83655), [#87559](openclaw/openclaw#87559), [#88088](openclaw/openclaw#88088), [#85924](openclaw/openclaw#85924)) Thanks [@vincentkoc](https://github.com/vincentkoc) and [@giodl73-repo](https://github.com/giodl73-repo). - Plugin and Gateway hot paths do less repeated work while preserving cache correctness for install records, config JSON parsing, tool search catalogs, session stores, manifest model rows, auto-enabled plugin config, browser tokens, viewer assets, and release-split external plugin packages. ([#86699](openclaw/openclaw#86699)) - Release, QA, and E2E validation now bound more log, artifact, harness, and cross-OS waits so failing lanes produce proof instead of hanging or false-greening. ##### Changes - Status: show active subagent details in status output. - Diffs: split the default language pack and expand default Diffs language coverage while keeping the host floor aligned. ([#87370](openclaw/openclaw#87370), [#87372](openclaw/openclaw#87372)) Thanks [@RomneyDa](https://github.com/RomneyDa). - ClawHub: add plugin display names plus skill verification and trust surfaces. ([#87354](openclaw/openclaw#87354), [#86699](openclaw/openclaw#86699)) Thanks [@thewilloftheshadow](https://github.com/thewilloftheshadow) and [@Patrick-Erichsen](https://github.com/Patrick-Erichsen). - iOS: refresh the dev app with Pro Command, Chat, Agents, Settings, hosted push relay defaults, and realtime Talk playback wired to gateway sessions, diagnostics, chat, and realtime Talk. ([#87367](openclaw/openclaw#87367), [#88096](openclaw/openclaw#88096), [#88105](openclaw/openclaw#88105)) Thanks [@Solvely-Colin](https://github.com/Solvely-Colin) and [@ngutman](https://github.com/ngutman). - Docs: clarify Codex computer-use setup, paste-token stdin auth setup, macOS gateway sleep troubleshooting, native Codex hook relay recovery, container model auth, install deployment cards, device-token admin gating, CLI setup flow compatibility, Notte cloud browser CDP setup, and backport targets. ([#87313](openclaw/openclaw#87313), [#63050](openclaw/openclaw#63050), [#87685](openclaw/openclaw#87685)) Thanks [@bdjben](https://github.com/bdjben), [@liaoandi](https://github.com/liaoandi), and [@thewilloftheshadow](https://github.com/thewilloftheshadow). - PDF/tools: use ClawPDF for PDF extraction, support encrypted PDF extraction, and surface MCP structured content in agent tool results. ([#87670](openclaw/openclaw#87670), [#87751](openclaw/openclaw#87751)) - Providers: add Claude Opus 4.8 support, Fal Krea image model schemas, NVIDIA featured model catalogs, MiniMax streaming music responses, and provider-backed voice model catalogs. ([#87845](openclaw/openclaw#87845), [#87890](openclaw/openclaw#87890), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764), [#87794](openclaw/openclaw#87794)) Thanks [@eleqtrizit](https://github.com/eleqtrizit) and [@vincentkoc](https://github.com/vincentkoc). - Codex/GitHub: add the GitHub Copilot agent runtime and the Codex Supervisor plugin package. - Plugins: externalize GitHub Copilot and Tokenjuice as official install-on-demand plugins with npm and ClawHub publish metadata. - Workboard: add agent coordination tools for tracking and handing off active agent work. - Discord: show commentary in progress drafts so live Discord runs expose useful in-progress context. ([#85200](openclaw/openclaw#85200)) - Plugin SDK: add a reply payload sending hook for plugins that need to deliver channel-owned replies and flatten package types for SDK declarations. ([#82823](openclaw/openclaw#82823), [#87165](openclaw/openclaw#87165)) Thanks [@piersonr](https://github.com/piersonr) and [@RomneyDa](https://github.com/RomneyDa). - Policy: add policy comparison, ingress-channel conformance, and sandbox-posture conformance checks. ([#85572](openclaw/openclaw#85572), [#85744](openclaw/openclaw#85744), [#86768](openclaw/openclaw#86768)) ##### Fixes - Agents: fall back to local config pruning when the optional `agents delete` Gateway probe cannot authenticate, so offline installs can still delete agents without removing shared workspaces. - Tighten phone-control mutation authorization \[AI]. ([#87150](openclaw/openclaw#87150)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Clarify directive persistence authorization policy \[AI]. ([#86369](openclaw/openclaw#86369)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Agents/Codex: keep spawned agent cwd/workspace state separated, forward ACP spawn attachments, keep hook context prompt-local, release session locks on timeout abort and runtime teardown without deleting live OpenClaw-owned locks during cleanup, avoid session event queue self-wait, clean up exec abort listeners, stream assistant deltas incrementally, recover raw missing-thread compaction failures, preserve rotated compaction session identity, keep compaction-timeout snapshots continuable, preserve shared app-server state across startup or helper failures, keep native hook relay alive across restarts and prune stale bridge files, close native hook relay replacement races, keep Claude live tool progress visible for watchdog recovery, suppress abandoned requester completion handoff, route workspace memory through tools, resolve Codex runtime models first, report quarantined dynamic tools, format `skills` command output, bind node auto-review to prepared plans, retry Claude CLI transcript probes, and bound compaction/steering retries. ([#87218](openclaw/openclaw#87218), [#86875](openclaw/openclaw#86875), [#86123](openclaw/openclaw#86123), [#88129](openclaw/openclaw#88129), [#87399](openclaw/openclaw#87399), [#87375](openclaw/openclaw#87375), [#72574](openclaw/openclaw#72574), [#87383](openclaw/openclaw#87383), [#87400](openclaw/openclaw#87400), [#83022](openclaw/openclaw#83022), [#87671](openclaw/openclaw#87671), [#87738](openclaw/openclaw#87738), [#87747](openclaw/openclaw#87747), [#87706](openclaw/openclaw#87706), [#87546](openclaw/openclaw#87546), [#87541](openclaw/openclaw#87541), [#81048](openclaw/openclaw#81048)) Thanks [@mbelinky](https://github.com/mbelinky), [@Alix-007](https://github.com/Alix-007), [@luoyanglang](https://github.com/luoyanglang), [@yetval](https://github.com/yetval), [@sjf](https://github.com/sjf), [@joshavant](https://github.com/joshavant), [@benjamin1492](https://github.com/benjamin1492), [@c19354837](https://github.com/c19354837), [@fuller-stack-dev](https://github.com/fuller-stack-dev), [@pfrederiksen](https://github.com/pfrederiksen), and [@dodge1218](https://github.com/dodge1218). - Codex Supervisor: keep real-home app-server MCP session listing on the loaded state path, bound stored history scans, and close WebSocket probes cleanly. - Channels: thread canonical session keys into outbound hooks, preserve Matrix room-id case, keep fallback tool warnings mention-inert, retain delivered Slack final replies during late cleanup, continue iMessage polling after denied reactions, suppress duplicate native exec approvals, resolve Gateway message actions against the active runtime config, preserve Telegram SecretRef prompt config and polling keepalives, preserve WhatsApp profile auth roots, QR display, document filenames, and plugin hook config, suppress Discord recovered tool warnings, preserve the Discord voice outbound helper, cap Discord/Signal/Zalo channel request and container timeouts, and block untrusted Teams service URLs while keeping TeamsSDK patterns aligned. ([#73706](openclaw/openclaw#73706), [#75670](openclaw/openclaw#75670), [#87366](openclaw/openclaw#87366), [#87451](openclaw/openclaw#87451), [#87465](openclaw/openclaw#87465), [#87334](openclaw/openclaw#87334), [#84535](openclaw/openclaw#84535), [#76262](openclaw/openclaw#76262), [#83304](openclaw/openclaw#83304), [#82492](openclaw/openclaw#82492), [#87581](openclaw/openclaw#87581), [#77114](openclaw/openclaw#77114), [#86426](openclaw/openclaw#86426), [#85529](openclaw/openclaw#85529), [#87160](openclaw/openclaw#87160)) Thanks [@zeroaltitude](https://github.com/zeroaltitude), [@lukeboyett](https://github.com/lukeboyett), [@jarvis-mns1](https://github.com/jarvis-mns1), [@xiaotian](https://github.com/xiaotian), [@funmerlin](https://github.com/funmerlin), [@joshavant](https://github.com/joshavant), [@eleqtrizit](https://github.com/eleqtrizit), [@heyitsaamir](https://github.com/heyitsaamir), [@amittell](https://github.com/amittell), [@lidge-jun](https://github.com/lidge-jun), [@liorb-mountapps](https://github.com/liorb-mountapps), [@masatohoshino](https://github.com/masatohoshino), [@bladin](https://github.com/bladin), and [@giodl73-repo](https://github.com/giodl73-repo). - CLI/auth/doctor/providers: reject malformed numeric/timeout/subcommand-version inputs, ignore workspace dotenv provider credentials, wait for respawn child shutdown, bound heartbeat defaults plus Codex, GitHub Copilot, OpenAI, Anthropic, Google, Feishu, LM Studio, MiniMax, Xiaomi TTS, and local-provider OAuth/token/model requests, harden Codex auth probes, label auth health by agent, preserve explicit agentRuntime pins during Codex model migration, warm provider auth off the main thread, honor Codex response timeouts, stop migrating current Claude Haiku 4.5 profiles to Sonnet, bound local service startup, resolve GPT-5.5 without cached catalog, migrate legacy memory auto-provider config, rewrite non-canonical `api_key` auth profiles, and make doctor restart follow-ups actionable. ([#87398](openclaw/openclaw#87398), [#86281](openclaw/openclaw#86281), [#87361](openclaw/openclaw#87361), [#88133](openclaw/openclaw#88133), [#83655](openclaw/openclaw#83655), [#87559](openclaw/openclaw#87559), [#87719](openclaw/openclaw#87719), [#88088](openclaw/openclaw#88088), [#85924](openclaw/openclaw#85924), [#84362](openclaw/openclaw#84362)) Thanks [@Patrick-Erichsen](https://github.com/Patrick-Erichsen), [@samzong](https://github.com/samzong), [@giodl73-repo](https://github.com/giodl73-repo), [@alkor2000](https://github.com/alkor2000), [@mmaps](https://github.com/mmaps), [@nxmxbbd](https://github.com/nxmxbbd), and [@vincentkoc](https://github.com/vincentkoc). - Gateway/security/session state: expire browser tokens after auth rotation, scope assistant idempotency dedupe, drain probe client closes, avoid stale restart continuation reuse, preserve retry-after fallbacks and stale rate-limit cooldown probes, bound webchat image and artifact transcript scans, include seconds in inbound metadata timestamps, clear completed session active runs, clear stale chat stream buffers, and evict current plugin-state namespaces at row caps. ([#87810](openclaw/openclaw#87810), [#87833](openclaw/openclaw#87833), [#75089](openclaw/openclaw#75089)) Thanks [@joshavant](https://github.com/joshavant) and [@litang9](https://github.com/litang9). - Config/parsing/network: reject partial numeric parsing, parse provider/Discord retry headers and dates strictly, honor IPv6 and bare IPv6 `no_proxy` entries, preserve empty plugin allowlists, canonicalize secret target array indexes, and reject malformed media content lengths, inspected TCP ports, marketplace content lengths, cron epochs, sandbox stat fields, unsafe duration values, empty config path segments, noncanonical schema array refs, unsafe Telegram callback pages, and invalid Teams attachment-fetch DNS targets. ([#87883](openclaw/openclaw#87883)) Thanks [@zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Browser/input hardening: reject invalid tab indexes, excessive viewport resizes, explicit zero CDP ports, malformed geolocation options, unsafe screenshot or permission-grant timeouts, loose response-body limits, invalid cookie expiries, and non-finite Browser tool delays/timeouts. - Cron/automation: retry recurring jobs after transient model rate limits before waiting for the next scheduled slot, and preflight model fallbacks before skipping scheduled work. ([#82887](openclaw/openclaw#82887)) Thanks [@chen-zhang-cs-code](https://github.com/chen-zhang-cs-code). - Auto-reply/directives: respect provider and relayed channel metadata during directive persistence so channel-originated decisions keep their intended context. ([#87683](openclaw/openclaw#87683)) - WhatsApp: resolve the auth directory from the active profile so profile-scoped WhatsApp installs do not drift to the wrong credential root. ([#82492](openclaw/openclaw#82492)) Thanks [@lidge-jun](https://github.com/lidge-jun). - Gateway/session state: clear completed session active runs, avoid cold-loading providers for MCP inventory, cache single-session child indexes, cap handshake timers, and bound preauth, auth-guard, media, transcript, readiness, and port options. - Channels/replies: preserve channel-owned progress callbacks when verbose output is off, keep group-room progress suppression intact, prefer external session delivery context, escape Discord component id delimiters, force final TUI chat repaints, show Slack reasoning previews, and normalize Discord/Matrix/Mattermost channel numeric options. ([#87476](openclaw/openclaw#87476), [#87423](openclaw/openclaw#87423)) - Agents/tool args: harden smart-quoted argument repair for edit arrays and exact escaped arguments so model-produced tool calls recover without corrupting valid input. ([#86611](openclaw/openclaw#86611)) Thanks [@ferminquant](https://github.com/ferminquant). - Providers/agents: preserve seeded Anthropic signatures, preserve signed thinking payloads, concatenate signature-delta chunks, preserve DeepSeek `reasoning_content` replay across tier suffixes, apply OpenRouter strict9 ids to Mistral routes, promote Ollama plain-text tool calls, load NVIDIA featured model catalogs, stream MiniMax music generation responses, and recover empty preflight compaction. ([#87593](openclaw/openclaw#87593), [#87493](openclaw/openclaw#87493), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764)) Thanks [@Pluviobyte](https://github.com/Pluviobyte) and [@eleqtrizit](https://github.com/eleqtrizit). - Media/images: skip CLI image cache refs when resolving generated images, allow trusted generated HTML attachments, and bound generated video downloads so stale refs and slow providers fail cleanly. ([#87523](openclaw/openclaw#87523), [#87982](openclaw/openclaw#87982)) - File transfer: handle late tar stdin pipe errors after archive validation or unpacking has already settled. - Performance: trust install-record caches between reloads, prefer native JSON parsing, reuse unchanged tool-search catalogs, reuse gateway session and plugin metadata paths, skip unchanged store serialization, patch single-entry session writes, add precomputed session patch writers, reduce store clone allocations, cache manifest model catalog rows and auto-enabled plugin config, avoid full session snapshots for entry reads, defer configured Slack full startup, prefer bundled plugin dist entries, and slim current metadata identity caches. ([#87760](openclaw/openclaw#87760)) - Docker/release/QA: package runtime workspace templates, stream cross-OS served artifacts, preserve sparse Crabbox run artifacts, isolate npm plugin installs per package, reject incompatible package plugin API installs, drop the leftover root Sharp dependency from package manifests after the Rastermill migration, bound OpenClaw instance logs, plugin gauntlet relay logs, MCP channel buffers, kitchen-sink scans, agent-turn assertions, QA-Lab credential broker calls, QA Matrix substrate requests, and release scenario logs, and keep release/google live guards current. ([#87647](openclaw/openclaw#87647), [#87477](openclaw/openclaw#87477)) Thanks [@rohitjavvadi](https://github.com/rohitjavvadi) and [@vincentkoc](https://github.com/vincentkoc). - Release/CI: bound manual git fetches, ClawHub verifier responses, ClawHub owner metadata, dependency-guard error bodies, Parallels limits, startup/test/memory budget parsing, and diffs viewer build warnings so release lanes fail with useful proof instead of hanging. ([#87839](openclaw/openclaw#87839)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/759

…claw#87409) * fix(agents): move session write lock into owned session runtime * test(agents): use typed tool-call fixtures

fix(agents): move session write lock into owned session runtime

50049d2

openclaw-barnacle Bot added agents Agent runtime and tooling size: L maintainer Maintainer-authored PR labels May 27, 2026

test(agents): use typed tool-call fixtures

d03d521

clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels May 27, 2026

steipete merged commit 5f68291 into main May 27, 2026
222 of 232 checks passed

steipete deleted the fix/session-write-lock-owned-agent branch May 27, 2026 21:17

github-actions Bot mentioned this pull request May 27, 2026

📡 Upstream Digest — 2026-05-27 21:46 UTC curtismercier/openclaw-mods#959

Open

ubehera mentioned this pull request May 29, 2026

fix(agents): gate owned-write publish on pre-append fingerprint (#86572) #86584

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(agents): move session write lock into owned session runtime#87409

fix(agents): move session write lock into owned session runtime#87409
steipete merged 2 commits into
mainfrom
fix/session-write-lock-owned-agent

steipete commented May 27, 2026

Uh oh!

clawsweeper Bot commented May 27, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

steipete commented May 27, 2026

Summary

Verification

Uh oh!

clawsweeper Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 27, 2026 •

edited

Loading