fix(agents): clean up exec abort listener after completion by c19354837 · Pull Request #83022 · openclaw/openclaw

c19354837 · 2026-05-17T09:06:40Z

Summary

Problem: completed exec tool calls register an abort listener but do not remove it when the command exits normally or yields to a background session.
Why it matters: Node can retain the composite AbortSignal listener through gcPersistentSignals; the retained onAbortSignal closure keeps the exec run/session context reachable after the tool call has completed.
What changed: track the registered abort signal and clean up the listener plus yield timer when foreground exec finishes, fails, or returns a background/running result.
What did NOT change (scope boundary): this does not change exec command semantics, background session behavior, timeout behavior, or active abort handling.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related #
This PR fixes a bug or regression

Real behavior proof (required for external PRs)

Behavior or issue addressed: exec retained onAbortSignal listeners after successful completion/backgrounding, which kept the corresponding run/session context reachable.
Real environment tested:
- macOS 15.7.4
- Node.js v22.21.0
- pnpm 11.1.0
- Source-built OpenClaw Gateway with --inspect and --expose-gc
- Isolated OpenClaw state directories under /tmp
- Local model/provider config was used but redacted from evidence.
Exact steps or command run after this patch:
1. Started the Gateway from source with an isolated OPENCLAW_STATE_DIR, --inspect=127.0.0.1:<port>, and --expose-gc.
2. Installed a runtime probe through CDP that records AbortSignal/EventTarget addEventListener and removeEventListener calls without retaining target or listener objects.
3. Created and ran 10 isolated cron jobs using --agent main --tools exec --no-deliver --light-context; each job executed a simple command that exits normally.
4. Forced GC through CDP and captured a heap snapshot.
5. Scanned the snapshot for onAbortSignal closures, gcPersistentSignals retainer paths, and paths from those closures to the run/session strings generated by the 10 cron jobs.
Evidence after fix (copied live output):

fixed runtime probe:
onAbortAdds=20
onAbortRemoves=20

fixed heap scan:
abortSignalObjectCount=4
onAbortSignal.closureCount=0
onAbortSignal.abortSignalRetainedClosureCount=0
gcPersistentPathCount=0
closureToSessionStringCount=0
closureToSessionObjectCount=0

onAbortAdds=20 / onAbortRemoves=20 is expected because the probe hooks both AbortSignal.prototype and EventTarget.prototype; this corresponds to 10 exec listener registrations and 10 removals.

Observed result after fix: all exec abort listeners registered by the 10 cron-triggered exec calls were removed, and no onAbortSignal closure remained retained by AbortSignal/gcPersistentSignals.
What was not tested: I did not verify every channel integration. Full pnpm test was attempted, but the current upstream test suite failed with unrelated existing failures outside this change.
Before evidence:

unfixed upstream runtime probe:
onAbortAdds=20
onAbortRemoves=0

unfixed upstream heap scan:
abortSignalObjectCount=44
onAbortSignal.closureCount=10
onAbortSignal.abortSignalRetainedClosureCount=10
gcPersistentPathCount=10
closureToSessionStringCount=10
closureToSessionObjectCount=10

The unfixed heap contained paths of the form:

gcPersistentSignals -> Set -> AbortSignal -> <symbol kEvents> -> Listener -> onAbortSignal
onAbortSignal closure -> internal context -> run / notifySessionKey -> agent:main:cron:<job-id>:run:<run-id>

Root Cause (if applicable)

Root cause: exec registers onAbortSignal with the tool-call AbortSignal, but successful completion and background/yield completion only cleared the yield timer. They did not remove the abort listener.
Missing detection / guardrail: existing exec tests covered abort behavior and update suppression, but did not assert listener cleanup after normal foreground completion or after returning a background running result.
Contributing context (if known): Node composite abort signals can remain reachable through internal persistent signal structures, so a listener closure can retain the run/session context even after the tool call has completed.

Regression Test Plan (if applicable)

Coverage level that should have caught this:
- Unit test
- Seam / integration test
- End-to-end test
- Existing coverage already sufficient
Target test or file: src/agents/bash-tools.test.ts
Scenario the test should lock in:
- foreground exec removes its abort listener after the process exits.
- backgrounded exec removes its abort listener when the tool returns a running result.
Why this is the smallest reliable guardrail: the leak is caused by missing cleanup at the exec tool boundary, so spying on the exact signal passed into execute() verifies the contract without requiring a full Gateway heap test.
Existing test that already covers this (if any): none.
If no new test is added, why not: N/A.

User-visible / Behavior Changes

None.

Diagram (if applicable)

Before:
exec starts -> add abort listener -> command completes -> listener remains -> run/session context can stay retained

After:
exec starts -> add abort listener -> command completes/backgrounds/fails -> remove abort listener -> run/session context can be released

Security Impact (required)

New permissions/capabilities? (Yes/No): No
Secrets/tokens handling changed? (Yes/No): No
New/changed network calls? (Yes/No): No
Command/tool execution surface changed? (Yes/No): No
Data access scope changed? (Yes/No): No
If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

OS: macOS 15.7.4
Runtime/container: local source-built Gateway, Node.js v22.21.0
Model/provider: local configured provider, redacted
Integration/channel (if any): Gateway cron tasks using the exec tool
Relevant config (redacted): isolated OPENCLAW_STATE_DIR, redacted provider config path, OPENCLAW_SKIP_CHANNELS=1

Steps

On unmodified upstream main, start the source Gateway with inspector and --expose-gc.
Install the CDP runtime listener probe.
Add and run 10 isolated cron jobs that invoke a successful exec command.
Force GC, capture a heap snapshot, and scan for onAbortSignal retainers and session paths.
Repeat the same steps after this patch.

Expected

Completed/backgrounded exec tool calls remove the abort listener they registered.
No completed exec onAbortSignal closure remains retained by AbortSignal/gcPersistentSignals.
No retained onAbortSignal closure reaches the cron run/session keys from the completed tasks.

Actual

Before this patch, 10 onAbortSignal closures remained retained and each could reach the corresponding cron run/session context.
After this patch, the runtime probe showed matching add/remove counts and heap scans found zero retained onAbortSignal closures.

Evidence

Attach at least one:

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Focused test:

node scripts/run-vitest.mjs src/agents/bash-tools.test.ts -t "removes the abort listener"

2 passed

Build and checks:

pnpm build
passed

pnpm check
passed

Full test suite:

pnpm test
failed with unrelated current upstream failures outside the touched exec cleanup tests

Human Verification (required)

What I personally verified (not just CI), and how:

Verified scenarios:
- foreground exec normal completion removes the abort listener.
- backgrounded exec returning a running result removes the abort listener.
- source-built Gateway with 10 real cron-triggered exec calls removes all registered exec abort listeners after the patch.
- forced-GC heap snapshot after the patch contains no retained onAbortSignal closures and no closure-to-session paths for those cron runs.
Edge cases checked:
- cleanup also runs on the rejected run.promise path.
- active abort handling still uses the same onAbortSignal function and kill behavior.
- background sessions still return PROCESS_STATUS_RUNNING.
What you did not verify:
- every channel integration.
- a clean full pnpm test run, because current upstream/local environment produced unrelated failures.

Review Conversations

I replied to or resolved every bot review conversation I addressed in this PR.
I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

Backward compatible? (Yes/No): Yes
Config/env changes? (Yes/No): No
Migration needed? (Yes/No): No
If yes, exact upgrade steps: N/A

Risks and Mitigations

Risk: removing the listener too early could change abort behavior for still-active foreground exec calls.
- Mitigation: cleanup only runs when the exec promise resolves/rejects or when the tool returns a background/running result; the active abort path before completion is unchanged.
Risk: background exec sessions should not be killed by the tool-call abort signal after they have been yielded.
- Mitigation: this is the intended existing behavior; the cleanup removes the tool-call abort listener when returning the running background result, while timeout behavior remains unchanged.

AI-assisted disclosure

This PR was prepared with AI assistance. I reviewed the code changes and personally ran the real behavior verification described above.

clawsweeper · 2026-05-17T09:07:49Z

Codex review: needs maintainer review before merge. Reviewed May 29, 2026, 2:40 AM ET / 06:40 UTC.

Summary
The PR tracks the exec tool-call AbortSignal listener, removes it with the yield timer when foreground exec settles or a background running result is returned, and adds foreground/background listener-cleanup tests.

PR surface: Source +8, Tests +36. Total +44 across 2 files.

Reproducibility: yes. Current main has a clear source-level reproduction path: exec registers the abort listener and lacks non-abort cleanup, and the PR body supplies before/after live listener and heap output for the same path.

Review metrics: none identified.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Next step before merge

No automated repair is needed; the remaining action is maintainer review and required-check gating on the current head.

Security
Cleared: The diff only removes an AbortSignal listener/timer and adds focused tests; it does not add dependencies, permissions, secrets handling, network calls, or new command capabilities.

Review details

Best possible solution:

Land the narrow exec cleanup after maintainer review and required checks, preserving existing abort/background semantics and keeping the new listener-cleanup tests.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main has a clear source-level reproduction path: exec registers the abort listener and lacks non-abort cleanup, and the PR body supplies before/after live listener and heap output for the same path.

Is this the best way to solve the issue?

Yes. The cleanup belongs at the exec tool boundary where the listener is registered, and the patch avoids changing process execution, active abort handling, timeout behavior, or background session polling.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 70230f4235f5.

Label changes

Label changes:

add proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes copied live output from a source-built Gateway with CDP listener counts and heap scans showing the after-fix listener removal and no retained onAbortSignal closure paths.
add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body includes copied live output from a source-built Gateway with CDP listener counts and heap scans showing the after-fix listener removal and no retained onAbortSignal closure paths.
remove impact:session-state: Current review selected no impact labels.

Label justifications:

P2: This is a focused exec/session retention bug fix with limited blast radius and normal maintainer priority.
rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body includes copied live output from a source-built Gateway with CDP listener counts and heap scans showing the after-fix listener removal and no retained onAbortSignal closure paths.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes copied live output from a source-built Gateway with CDP listener counts and heap scans showing the after-fix listener removal and no retained onAbortSignal closure paths.

Evidence reviewed

PR surface:

Source +8, Tests +36. Total +44 across 2 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	1	18	10	+8
Tests	1	36	0	+36
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	2	54	10	+44

What I checked:

Current main leak path: Current main registers onAbortSignal with { once: true }, but the normal foreground settlement and background-yield paths only clear the yield timer and do not remove the abort listener. (src/agents/bash-tools.exec.ts:1659, 70230f4235f5)
PR diff adds scoped cleanup: The PR head adds registeredAbortSignal, a local cleanup helper, records the registered signal, and calls cleanup before returning a running background result and when run.promise settles or rejects. (src/agents/bash-tools.exec.ts:1654, fe86528ecb20)
Regression tests cover both paths: The PR adds tests that spy on the passed AbortSignal and assert removeEventListener after a foreground exec exits and after an exec returns PROCESS_STATUS_RUNNING. (src/agents/bash-tools.test.ts:984, fe86528ecb20)
Runtime semantics remain separated: runExecProcess already suppresses onUpdate for backgrounded, exited, or disabled sessions, and disableUpdates() only flips that suppression flag; process lifetime, timeout, and cancel handling remain in the supervisor path. (src/agents/bash-tools.exec-runtime.ts:714, 70230f4235f5)
Node listener contract checked: Node v22.21.0 EventTarget.removeEventListener matches listener plus capture, and AbortSignal internals remove timeout/composite signals from gcPersistentSignals when the abort listener count reaches zero.
Real behavior proof supplied: The PR body includes before/after copied live output from a source-built Gateway with CDP listener counts and heap scans showing matching listener removals and no retained onAbortSignal closure paths after the fix. (fe86528ecb20)

Likely related people:

openperf: Authored the merged exec update-suppression work that added run.disableUpdates() to the abort path this PR now cleans up after completion/backgrounding. (role: introduced adjacent behavior; confidence: high; commits: 574bab80e565; files: src/agents/bash-tools.exec.ts, src/agents/bash-tools.exec-runtime.ts, src/agents/bash-tools.test.ts)
steipete: Current blame and recent path history show heavy maintenance of the exec source/tests and broader agent runtime around this code path. (role: recent area contributor; confidence: high; commits: 70230f4235f5, bb46b79d3c14, 864899d1b0c9; files: src/agents/bash-tools.exec.ts, src/agents/bash-tools.exec-runtime.ts, src/agents/bash-tools.test.ts)
shakkernerd: Recent public commit history for the same exec source and test files includes focused exec validation and agent test maintenance by this contributor. (role: adjacent exec contributor; confidence: medium; commits: a8a34c92f397, 0517b5494262; files: src/agents/bash-tools.exec.ts, src/agents/bash-tools.test.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

RomneyDa · 2026-05-29T06:27:58Z

Heads up: this PR needs to be updated against current main before the new required Dependency Guard check can pass.

c19354837 · 2026-05-29T06:49:54Z

@RomneyDa done, please re-review

steipete

Approved. I re-read the exec lifecycle around this, including the tool-call abort handoff, process supervisor, process registry, background polling path, and existing background abort tests.

Verification:

Exact head checked: fe86528
Current-main merge-tree: clean against origin/main
Checks: gh pr checks 83022 is green for required/current rows
Diff sanity: git diff --check origin/main...refs/remotes/pr/83022 passed
Contract probe: Node removeEventListener removes an abort listener added with once true

No known proof gaps for this scope. The cleanup is at the same boundary that registers the listener and does not change process timeout, background polling, or active abort semantics.

@c19354837

…83022) Clean up completed exec tool-call abort listeners so normal foreground completion and background-yield no longer retain the exec run/session context through AbortSignal listener state. The listener cleanup now lives beside the exec listener registration and runs when the foreground process settles, rejects, or the tool returns a background running result. Existing abort/timeout/background behavior remains owned by the process supervisor and process registry. Verification: - gh pr checks 83022 - gh api repos/openclaw/openclaw/commits/fe86528ecb2043b6febef5c2eec53f9124be5543/check-runs - git merge-tree --write-tree origin/main refs/remotes/pr/83022 - git diff --check origin/main...refs/remotes/pr/83022 - node AbortSignal add/remove listener probe Thanks @c19354837. Co-authored-by: Ninty <c19354837@hotmail.com>

…026.5.28) (#759) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.5.27` → `2026.5.28` | --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.5.28`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#2026528) [Compare Source](openclaw/openclaw@v2026.5.27...v2026.5.28) ##### Highlights - Agent and Codex runtime recovery is steadier: subagents keep cwd/workspace separation, hook context stays prompt-local, session locks release on timeout abort while live OpenClaw locks survive cleanup, stale restart continuations are avoided, and Codex app-server/helper failures no longer tear down shared runtime state. ([#87218](openclaw/openclaw#87218), [#86875](openclaw/openclaw#86875), [#87409](openclaw/openclaw#87409), [#87399](openclaw/openclaw#87399), [#87375](openclaw/openclaw#87375), [#88129](openclaw/openclaw#88129)) - Channel delivery and session identity got safer across outbound plugin hooks, Matrix room ids, iMessage reactions/approvals, Slack final replies, Discord recovered tool warnings, runtime-config message actions, WhatsApp profile auth roots, Telegram polling, and Microsoft Teams service URL trust checks. ([#73706](openclaw/openclaw#73706), [#75670](openclaw/openclaw#75670), [#87366](openclaw/openclaw#87366), [#87451](openclaw/openclaw#87451), [#87334](openclaw/openclaw#87334), [#84535](openclaw/openclaw#84535), [#82492](openclaw/openclaw#82492), [#83304](openclaw/openclaw#83304), [#87160](openclaw/openclaw#87160)) - Mobile and chat surfaces got a broader refresh: the iOS Pro UI, hosted push relay default, realtime Talk tab playback, Gateway chat transport, onboarding, Talk permissions, WebChat reconnect delivery, and session picker behavior now preserve more state across reconnects and empty searches. ([#87367](openclaw/openclaw#87367), [#87531](openclaw/openclaw#87531), [#87682](openclaw/openclaw#87682), [#88096](openclaw/openclaw#88096), [#88105](openclaw/openclaw#88105)) Thanks [@ngutman](https://github.com/ngutman) and [@BunsDev](https://github.com/BunsDev). - Browser, channel, and automation inputs are stricter: Browser tool timeouts, viewport/tab indices, Gateway ports, cron retry handling, Discord component ids, schema array refs, Telegram callback pages, and channel progress callbacks now reject malformed values earlier and preserve the intended delivery context. ([#82887](openclaw/openclaw#82887)) - Provider, media, and document coverage expands with Claude Opus 4.8, Fal Krea image schemas, NVIDIA featured models, MiniMax streaming music responses, encrypted PDF extraction, voice model catalogs, GitHub Copilot agent runtime support, and a Codex Supervisor plugin path for delegated Codex workflows. ([#87845](openclaw/openclaw#87845), [#87890](openclaw/openclaw#87890), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764), [#87751](openclaw/openclaw#87751), [#87794](openclaw/openclaw#87794)) - CLI, auth, doctor, and provider paths fail faster and recover more clearly: malformed numeric/version options are rejected, workspace dotenv provider credentials are ignored, heartbeat defaults, OAuth/token lifetimes, and local service startup requests are bounded, agent auth health labels are clearer, legacy `api_key` auth profiles migrate to canonical form, and restart guidance is actionable. ([#87398](openclaw/openclaw#87398), [#86281](openclaw/openclaw#86281), [#87361](openclaw/openclaw#87361), [#88133](openclaw/openclaw#88133), [#83655](openclaw/openclaw#83655), [#87559](openclaw/openclaw#87559), [#88088](openclaw/openclaw#88088), [#85924](openclaw/openclaw#85924)) Thanks [@vincentkoc](https://github.com/vincentkoc) and [@giodl73-repo](https://github.com/giodl73-repo). - Plugin and Gateway hot paths do less repeated work while preserving cache correctness for install records, config JSON parsing, tool search catalogs, session stores, manifest model rows, auto-enabled plugin config, browser tokens, viewer assets, and release-split external plugin packages. ([#86699](openclaw/openclaw#86699)) - Release, QA, and E2E validation now bound more log, artifact, harness, and cross-OS waits so failing lanes produce proof instead of hanging or false-greening. ##### Changes - Status: show active subagent details in status output. - Diffs: split the default language pack and expand default Diffs language coverage while keeping the host floor aligned. ([#87370](openclaw/openclaw#87370), [#87372](openclaw/openclaw#87372)) Thanks [@RomneyDa](https://github.com/RomneyDa). - ClawHub: add plugin display names plus skill verification and trust surfaces. ([#87354](openclaw/openclaw#87354), [#86699](openclaw/openclaw#86699)) Thanks [@thewilloftheshadow](https://github.com/thewilloftheshadow) and [@Patrick-Erichsen](https://github.com/Patrick-Erichsen). - iOS: refresh the dev app with Pro Command, Chat, Agents, Settings, hosted push relay defaults, and realtime Talk playback wired to gateway sessions, diagnostics, chat, and realtime Talk. ([#87367](openclaw/openclaw#87367), [#88096](openclaw/openclaw#88096), [#88105](openclaw/openclaw#88105)) Thanks [@Solvely-Colin](https://github.com/Solvely-Colin) and [@ngutman](https://github.com/ngutman). - Docs: clarify Codex computer-use setup, paste-token stdin auth setup, macOS gateway sleep troubleshooting, native Codex hook relay recovery, container model auth, install deployment cards, device-token admin gating, CLI setup flow compatibility, Notte cloud browser CDP setup, and backport targets. ([#87313](openclaw/openclaw#87313), [#63050](openclaw/openclaw#63050), [#87685](openclaw/openclaw#87685)) Thanks [@bdjben](https://github.com/bdjben), [@liaoandi](https://github.com/liaoandi), and [@thewilloftheshadow](https://github.com/thewilloftheshadow). - PDF/tools: use ClawPDF for PDF extraction, support encrypted PDF extraction, and surface MCP structured content in agent tool results. ([#87670](openclaw/openclaw#87670), [#87751](openclaw/openclaw#87751)) - Providers: add Claude Opus 4.8 support, Fal Krea image model schemas, NVIDIA featured model catalogs, MiniMax streaming music responses, and provider-backed voice model catalogs. ([#87845](openclaw/openclaw#87845), [#87890](openclaw/openclaw#87890), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764), [#87794](openclaw/openclaw#87794)) Thanks [@eleqtrizit](https://github.com/eleqtrizit) and [@vincentkoc](https://github.com/vincentkoc). - Codex/GitHub: add the GitHub Copilot agent runtime and the Codex Supervisor plugin package. - Plugins: externalize GitHub Copilot and Tokenjuice as official install-on-demand plugins with npm and ClawHub publish metadata. - Workboard: add agent coordination tools for tracking and handing off active agent work. - Discord: show commentary in progress drafts so live Discord runs expose useful in-progress context. ([#85200](openclaw/openclaw#85200)) - Plugin SDK: add a reply payload sending hook for plugins that need to deliver channel-owned replies and flatten package types for SDK declarations. ([#82823](openclaw/openclaw#82823), [#87165](openclaw/openclaw#87165)) Thanks [@piersonr](https://github.com/piersonr) and [@RomneyDa](https://github.com/RomneyDa). - Policy: add policy comparison, ingress-channel conformance, and sandbox-posture conformance checks. ([#85572](openclaw/openclaw#85572), [#85744](openclaw/openclaw#85744), [#86768](openclaw/openclaw#86768)) ##### Fixes - Agents: fall back to local config pruning when the optional `agents delete` Gateway probe cannot authenticate, so offline installs can still delete agents without removing shared workspaces. - Tighten phone-control mutation authorization \[AI]. ([#87150](openclaw/openclaw#87150)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Clarify directive persistence authorization policy \[AI]. ([#86369](openclaw/openclaw#86369)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Agents/Codex: keep spawned agent cwd/workspace state separated, forward ACP spawn attachments, keep hook context prompt-local, release session locks on timeout abort and runtime teardown without deleting live OpenClaw-owned locks during cleanup, avoid session event queue self-wait, clean up exec abort listeners, stream assistant deltas incrementally, recover raw missing-thread compaction failures, preserve rotated compaction session identity, keep compaction-timeout snapshots continuable, preserve shared app-server state across startup or helper failures, keep native hook relay alive across restarts and prune stale bridge files, close native hook relay replacement races, keep Claude live tool progress visible for watchdog recovery, suppress abandoned requester completion handoff, route workspace memory through tools, resolve Codex runtime models first, report quarantined dynamic tools, format `skills` command output, bind node auto-review to prepared plans, retry Claude CLI transcript probes, and bound compaction/steering retries. ([#87218](openclaw/openclaw#87218), [#86875](openclaw/openclaw#86875), [#86123](openclaw/openclaw#86123), [#88129](openclaw/openclaw#88129), [#87399](openclaw/openclaw#87399), [#87375](openclaw/openclaw#87375), [#72574](openclaw/openclaw#72574), [#87383](openclaw/openclaw#87383), [#87400](openclaw/openclaw#87400), [#83022](openclaw/openclaw#83022), [#87671](openclaw/openclaw#87671), [#87738](openclaw/openclaw#87738), [#87747](openclaw/openclaw#87747), [#87706](openclaw/openclaw#87706), [#87546](openclaw/openclaw#87546), [#87541](openclaw/openclaw#87541), [#81048](openclaw/openclaw#81048)) Thanks [@mbelinky](https://github.com/mbelinky), [@Alix-007](https://github.com/Alix-007), [@luoyanglang](https://github.com/luoyanglang), [@yetval](https://github.com/yetval), [@sjf](https://github.com/sjf), [@joshavant](https://github.com/joshavant), [@benjamin1492](https://github.com/benjamin1492), [@c19354837](https://github.com/c19354837), [@fuller-stack-dev](https://github.com/fuller-stack-dev), [@pfrederiksen](https://github.com/pfrederiksen), and [@dodge1218](https://github.com/dodge1218). - Codex Supervisor: keep real-home app-server MCP session listing on the loaded state path, bound stored history scans, and close WebSocket probes cleanly. - Channels: thread canonical session keys into outbound hooks, preserve Matrix room-id case, keep fallback tool warnings mention-inert, retain delivered Slack final replies during late cleanup, continue iMessage polling after denied reactions, suppress duplicate native exec approvals, resolve Gateway message actions against the active runtime config, preserve Telegram SecretRef prompt config and polling keepalives, preserve WhatsApp profile auth roots, QR display, document filenames, and plugin hook config, suppress Discord recovered tool warnings, preserve the Discord voice outbound helper, cap Discord/Signal/Zalo channel request and container timeouts, and block untrusted Teams service URLs while keeping TeamsSDK patterns aligned. ([#73706](openclaw/openclaw#73706), [#75670](openclaw/openclaw#75670), [#87366](openclaw/openclaw#87366), [#87451](openclaw/openclaw#87451), [#87465](openclaw/openclaw#87465), [#87334](openclaw/openclaw#87334), [#84535](openclaw/openclaw#84535), [#76262](openclaw/openclaw#76262), [#83304](openclaw/openclaw#83304), [#82492](openclaw/openclaw#82492), [#87581](openclaw/openclaw#87581), [#77114](openclaw/openclaw#77114), [#86426](openclaw/openclaw#86426), [#85529](openclaw/openclaw#85529), [#87160](openclaw/openclaw#87160)) Thanks [@zeroaltitude](https://github.com/zeroaltitude), [@lukeboyett](https://github.com/lukeboyett), [@jarvis-mns1](https://github.com/jarvis-mns1), [@xiaotian](https://github.com/xiaotian), [@funmerlin](https://github.com/funmerlin), [@joshavant](https://github.com/joshavant), [@eleqtrizit](https://github.com/eleqtrizit), [@heyitsaamir](https://github.com/heyitsaamir), [@amittell](https://github.com/amittell), [@lidge-jun](https://github.com/lidge-jun), [@liorb-mountapps](https://github.com/liorb-mountapps), [@masatohoshino](https://github.com/masatohoshino), [@bladin](https://github.com/bladin), and [@giodl73-repo](https://github.com/giodl73-repo). - CLI/auth/doctor/providers: reject malformed numeric/timeout/subcommand-version inputs, ignore workspace dotenv provider credentials, wait for respawn child shutdown, bound heartbeat defaults plus Codex, GitHub Copilot, OpenAI, Anthropic, Google, Feishu, LM Studio, MiniMax, Xiaomi TTS, and local-provider OAuth/token/model requests, harden Codex auth probes, label auth health by agent, preserve explicit agentRuntime pins during Codex model migration, warm provider auth off the main thread, honor Codex response timeouts, stop migrating current Claude Haiku 4.5 profiles to Sonnet, bound local service startup, resolve GPT-5.5 without cached catalog, migrate legacy memory auto-provider config, rewrite non-canonical `api_key` auth profiles, and make doctor restart follow-ups actionable. ([#87398](openclaw/openclaw#87398), [#86281](openclaw/openclaw#86281), [#87361](openclaw/openclaw#87361), [#88133](openclaw/openclaw#88133), [#83655](openclaw/openclaw#83655), [#87559](openclaw/openclaw#87559), [#87719](openclaw/openclaw#87719), [#88088](openclaw/openclaw#88088), [#85924](openclaw/openclaw#85924), [#84362](openclaw/openclaw#84362)) Thanks [@Patrick-Erichsen](https://github.com/Patrick-Erichsen), [@samzong](https://github.com/samzong), [@giodl73-repo](https://github.com/giodl73-repo), [@alkor2000](https://github.com/alkor2000), [@mmaps](https://github.com/mmaps), [@nxmxbbd](https://github.com/nxmxbbd), and [@vincentkoc](https://github.com/vincentkoc). - Gateway/security/session state: expire browser tokens after auth rotation, scope assistant idempotency dedupe, drain probe client closes, avoid stale restart continuation reuse, preserve retry-after fallbacks and stale rate-limit cooldown probes, bound webchat image and artifact transcript scans, include seconds in inbound metadata timestamps, clear completed session active runs, clear stale chat stream buffers, and evict current plugin-state namespaces at row caps. ([#87810](openclaw/openclaw#87810), [#87833](openclaw/openclaw#87833), [#75089](openclaw/openclaw#75089)) Thanks [@joshavant](https://github.com/joshavant) and [@litang9](https://github.com/litang9). - Config/parsing/network: reject partial numeric parsing, parse provider/Discord retry headers and dates strictly, honor IPv6 and bare IPv6 `no_proxy` entries, preserve empty plugin allowlists, canonicalize secret target array indexes, and reject malformed media content lengths, inspected TCP ports, marketplace content lengths, cron epochs, sandbox stat fields, unsafe duration values, empty config path segments, noncanonical schema array refs, unsafe Telegram callback pages, and invalid Teams attachment-fetch DNS targets. ([#87883](openclaw/openclaw#87883)) Thanks [@zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Browser/input hardening: reject invalid tab indexes, excessive viewport resizes, explicit zero CDP ports, malformed geolocation options, unsafe screenshot or permission-grant timeouts, loose response-body limits, invalid cookie expiries, and non-finite Browser tool delays/timeouts. - Cron/automation: retry recurring jobs after transient model rate limits before waiting for the next scheduled slot, and preflight model fallbacks before skipping scheduled work. ([#82887](openclaw/openclaw#82887)) Thanks [@chen-zhang-cs-code](https://github.com/chen-zhang-cs-code). - Auto-reply/directives: respect provider and relayed channel metadata during directive persistence so channel-originated decisions keep their intended context. ([#87683](openclaw/openclaw#87683)) - WhatsApp: resolve the auth directory from the active profile so profile-scoped WhatsApp installs do not drift to the wrong credential root. ([#82492](openclaw/openclaw#82492)) Thanks [@lidge-jun](https://github.com/lidge-jun). - Gateway/session state: clear completed session active runs, avoid cold-loading providers for MCP inventory, cache single-session child indexes, cap handshake timers, and bound preauth, auth-guard, media, transcript, readiness, and port options. - Channels/replies: preserve channel-owned progress callbacks when verbose output is off, keep group-room progress suppression intact, prefer external session delivery context, escape Discord component id delimiters, force final TUI chat repaints, show Slack reasoning previews, and normalize Discord/Matrix/Mattermost channel numeric options. ([#87476](openclaw/openclaw#87476), [#87423](openclaw/openclaw#87423)) - Agents/tool args: harden smart-quoted argument repair for edit arrays and exact escaped arguments so model-produced tool calls recover without corrupting valid input. ([#86611](openclaw/openclaw#86611)) Thanks [@ferminquant](https://github.com/ferminquant). - Providers/agents: preserve seeded Anthropic signatures, preserve signed thinking payloads, concatenate signature-delta chunks, preserve DeepSeek `reasoning_content` replay across tier suffixes, apply OpenRouter strict9 ids to Mistral routes, promote Ollama plain-text tool calls, load NVIDIA featured model catalogs, stream MiniMax music generation responses, and recover empty preflight compaction. ([#87593](openclaw/openclaw#87593), [#87493](openclaw/openclaw#87493), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764)) Thanks [@Pluviobyte](https://github.com/Pluviobyte) and [@eleqtrizit](https://github.com/eleqtrizit). - Media/images: skip CLI image cache refs when resolving generated images, allow trusted generated HTML attachments, and bound generated video downloads so stale refs and slow providers fail cleanly. ([#87523](openclaw/openclaw#87523), [#87982](openclaw/openclaw#87982)) - File transfer: handle late tar stdin pipe errors after archive validation or unpacking has already settled. - Performance: trust install-record caches between reloads, prefer native JSON parsing, reuse unchanged tool-search catalogs, reuse gateway session and plugin metadata paths, skip unchanged store serialization, patch single-entry session writes, add precomputed session patch writers, reduce store clone allocations, cache manifest model catalog rows and auto-enabled plugin config, avoid full session snapshots for entry reads, defer configured Slack full startup, prefer bundled plugin dist entries, and slim current metadata identity caches. ([#87760](openclaw/openclaw#87760)) - Docker/release/QA: package runtime workspace templates, stream cross-OS served artifacts, preserve sparse Crabbox run artifacts, isolate npm plugin installs per package, reject incompatible package plugin API installs, drop the leftover root Sharp dependency from package manifests after the Rastermill migration, bound OpenClaw instance logs, plugin gauntlet relay logs, MCP channel buffers, kitchen-sink scans, agent-turn assertions, QA-Lab credential broker calls, QA Matrix substrate requests, and release scenario logs, and keep release/google live guards current. ([#87647](openclaw/openclaw#87647), [#87477](openclaw/openclaw#87477)) Thanks [@rohitjavvadi](https://github.com/rohitjavvadi) and [@vincentkoc](https://github.com/vincentkoc). - Release/CI: bound manual git fetches, ClawHub verifier responses, ClawHub owner metadata, dependency-guard error bodies, Parallels limits, startup/test/memory budget parsing, and diffs viewer build warnings so release lanes fail with useful proof instead of hanging. ([#87839](openclaw/openclaw#87839)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/759

@c19354837

…83022) Clean up completed exec tool-call abort listeners so normal foreground completion and background-yield no longer retain the exec run/session context through AbortSignal listener state. The listener cleanup now lives beside the exec listener registration and runs when the foreground process settles, rejects, or the tool returns a background running result. Existing abort/timeout/background behavior remains owned by the process supervisor and process registry. Verification: - gh pr checks 83022 - gh api repos/openclaw/openclaw/commits/fe86528ecb2043b6febef5c2eec53f9124be5543/check-runs - git merge-tree --write-tree origin/main refs/remotes/pr/83022 - git diff --check origin/main...refs/remotes/pr/83022 - node AbortSignal add/remove listener probe Thanks @c19354837. Co-authored-by: Ninty <c19354837@hotmail.com>

@c19354837

…83022) Clean up completed exec tool-call abort listeners so normal foreground completion and background-yield no longer retain the exec run/session context through AbortSignal listener state. The listener cleanup now lives beside the exec listener registration and runs when the foreground process settles, rejects, or the tool returns a background running result. Existing abort/timeout/background behavior remains owned by the process supervisor and process registry. Verification: - gh pr checks 83022 - gh api repos/openclaw/openclaw/commits/fe86528ecb2043b6febef5c2eec53f9124be5543/check-runs - git merge-tree --write-tree origin/main refs/remotes/pr/83022 - git diff --check origin/main...refs/remotes/pr/83022 - node AbortSignal add/remove listener probe Thanks @c19354837. Co-authored-by: Ninty <c19354837@hotmail.com>

openclaw-barnacle Bot added agents Agent runtime and tooling size: S proof: supplied External PR includes structured after-fix real behavior proof. labels May 17, 2026

clawsweeper Bot added proof: sufficient ClawSweeper judged the real behavior proof convincing. P2 Normal backlog priority with limited blast radius. impact:session-state Session, memory, transcript, context, or agent state can drift or corrupt. labels May 17, 2026

fix(agents): clean up exec abort listener

123885f

c19354837 force-pushed the fix/exec-abort-listener-cleanup branch from f679318 to 123885f Compare May 17, 2026 09:55

openclaw-barnacle Bot removed the proof: sufficient ClawSweeper judged the real behavior proof convincing. label May 17, 2026

clawsweeper Bot added the proof: sufficient ClawSweeper judged the real behavior proof convincing. label May 17, 2026

Merge branch 'main' into fix/exec-abort-listener-cleanup

fe86528

openclaw-barnacle Bot removed the proof: sufficient ClawSweeper judged the real behavior proof convincing. label May 29, 2026

steipete self-assigned this May 29, 2026

steipete approved these changes May 29, 2026

View reviewed changes

steipete merged commit ee6eab8 into openclaw:main May 29, 2026
127 of 133 checks passed

clawsweeper Bot mentioned this pull request May 29, 2026

[Bug]: exec tool silently corrupts 2>&1 / 2>/dev/null shell redirect arguments #87980

Open

This was referenced May 29, 2026

[Bug]: image_generate completion wake can send the same Discord attachment multiple times #87989

Closed

[Bug]: image_generate still duplicate-sends Discord attachments after terminal guard #87995

Open

c19354837 deleted the fix/exec-abort-listener-cleanup branch May 29, 2026 11:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(agents): clean up exec abort listener after completion#83022

fix(agents): clean up exec abort listener after completion#83022
steipete merged 2 commits into
openclaw:mainfrom
c19354837:fix/exec-abort-listener-cleanup

c19354837 commented May 17, 2026

Uh oh!

clawsweeper Bot commented May 17, 2026 •

edited

Loading

Uh oh!

RomneyDa commented May 29, 2026

Uh oh!

c19354837 commented May 29, 2026

Uh oh!

steipete left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

c19354837 commented May 17, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Real behavior proof (required for external PRs)

Root Cause (if applicable)

Regression Test Plan (if applicable)

User-visible / Behavior Changes

Diagram (if applicable)

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Review Conversations

Compatibility / Migration

Risks and Mitigations

AI-assisted disclosure

Uh oh!

clawsweeper Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RomneyDa commented May 29, 2026

Uh oh!

c19354837 commented May 29, 2026

Uh oh!

steipete left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

clawsweeper Bot commented May 17, 2026 •

edited

Loading