fix(msteams): bind bot framework service urls by eleqtrizit · Pull Request #87160 · openclaw/openclaw

eleqtrizit · 2026-05-27T04:42:46Z

Summary

Fix Microsoft Teams Bot Framework authentication so inbound tokens are bound to the activity serviceUrl, and keep media bearer tokens scoped to explicitly auth-allowlisted hosts.

Changes

Validate the Bot Framework JWT serviceurl/serviceUrl claim against the inbound Activity body serviceUrl.
Parse the bounded webhook JSON body before full JWT validation while keeping the cheap Bearer pre-gate and payload-size handling.
Strip media Authorization on initial and redirect fetches unless the target host is auth-allowlisted.
Apply the auth-allowlist header helper to Bot Framework attachment metadata and view downloads.
Extend Microsoft Teams monitor, SDK, and attachment tests for the new service URL and authorization behavior.
Rebase onto current upstream/main (e339586750) so the merged outbound serviceUrl allowlist from fix(msteams): block untrusted Teams service URLs #87334 and latest CI fixes remain in the final branch.

Validation

node scripts/run-vitest.mjs extensions/msteams/src/attachments/bot-framework.test.ts extensions/msteams/src/attachments/shared.test.ts extensions/msteams/src/monitor.lifecycle.test.ts extensions/msteams/src/sdk.test.ts extensions/msteams/src/send-context.test.ts extensions/msteams/src/monitor-handler/message-handler.authz.test.ts - 6 files passed, 151 tests passed.
node scripts/run-vitest.mjs extensions/msteams - 66 files passed, 940 tests passed.
git diff --check upstream/main...HEAD - passed.
git merge-base --is-ancestor 62550710bfec2b16e2b0049df6efd0e05efe0c1a HEAD - passed; fix(msteams): block untrusted Teams service URLs #87334 is included in the rebased branch ancestry.

Behavior addressed: Microsoft Teams Bot Framework requests are accepted only when the JWT service URL claim matches the Activity body, outbound/proactive Bot Framework service URLs remain restricted to the Microsoft Teams allowlist from #87334, and media bearer tokens are sent only to auth-allowlisted hosts.
Real environment tested: Local Codex worktree rebased onto upstream/main e339586750 with the repo Vitest wrapper. Live Microsoft Teams tenant proof was not available in this container.
Exact steps or command run after this patch: node scripts/run-vitest.mjs extensions/msteams/src/attachments/bot-framework.test.ts extensions/msteams/src/attachments/shared.test.ts extensions/msteams/src/monitor.lifecycle.test.ts extensions/msteams/src/sdk.test.ts extensions/msteams/src/send-context.test.ts extensions/msteams/src/monitor-handler/message-handler.authz.test.ts; node scripts/run-vitest.mjs extensions/msteams; git diff --check upstream/main...HEAD; git merge-base --is-ancestor 62550710bfec2b16e2b0049df6efd0e05efe0c1a HEAD.
Evidence after fix: Targeted Teams auth/media/outbound tests passed with 6 files / 151 tests; the full Microsoft Teams extension Vitest lane passed with 66 files / 940 tests; diff check passed; #87334's merge commit is present in HEAD ancestry.
Observed result after fix: Mocked valid serviceurl and Activity serviceUrl matches are accepted, mismatches/missing/malformed service URLs reject, untrusted media hosts do not receive Authorization, and the rebased SDK/send-context/monitor-handler tests keep the outbound serviceUrl allowlist behavior from #87334 intact.
What was not tested: Redacted live Microsoft Teams/Bot Framework webhook or media-download traffic. This environment has no MSTEAMS/Azure/Bot Framework credentials or Teams channel config, and the local Crabbox wrapper fails its basic binary sanity check, so tenant-level proof must be run from a credentialed maintainer environment.

Notes

Maintainer approval for the intentional fail-closed compatibility change is recorded in fix(msteams): bind bot framework service urls #87160 (comment).
No production credentials, tenant IDs, tokens, or live message contents are included.
No CHANGELOG.md update.

clawsweeper · 2026-05-27T04:45:03Z

Codex review: needs real behavior proof before merge. Reviewed May 27, 2026, 3:46 PM ET / 19:46 UTC.

Summary
The PR binds inbound Bot Framework JWT serviceurl/serviceUrl claims to Activity serviceUrl and scopes Bot Framework attachment bearer tokens to auth-allowlisted hosts.

PR surface: Source +93, Tests +248. Total +341 across 8 files.

Reproducibility: no. live repro was established. Source inspection shows current main validates the bearer token before parsing Activity.serviceUrl, while PR head binds the verified serviceurl/serviceUrl claim to the parsed body value.

Review metrics: 1 noteworthy metric.

Auth paths tightened: 2 tightened. Inbound JWT serviceUrl binding and Bot Framework attachment bearer-host scoping can reject traffic current main accepts, so maintainers should review compatibility and proof before merge.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof from a real setup is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

Add redacted live Teams/Bot Framework webhook or media-download proof showing a valid request succeeds and a mismatched serviceUrl fails.
Get explicit maintainer confirmation for the fail-closed compatibility behavior before merge.

Proof guidance:
Needs real behavior proof before merge: Needs real behavior proof before merge: the PR body shows local Vitest/diff-check proof but no redacted live Teams/Bot Framework webhook or media-download logs, terminal output, recording, or linked artifact; contributors should redact IPs, API keys, phone numbers, tenant details, and non-public endpoints, then update the PR body to trigger re-review or ask a maintainer to comment @clawsweeper re-review.

Risk before merge

This intentionally tightens inbound Microsoft Teams Bot Framework auth, so existing tenant traffic with missing, malformed, query/fragment-bearing, or claim-mismatched serviceUrl will now fail with 401.
Bot Framework attachment bearer tokens are withheld unless the initial and redirect hosts are auth-allowlisted; valid but undocumented Microsoft media hosts would stop downloading until maintainers update the allowlist with redacted evidence.
The PR body contains local Vitest and diff-check proof only; the external PR still needs credentialed, redacted Teams webhook or media-download evidence before merge.

Maintainer options:

Require credentialed Teams proof (recommended)
Before merge, require redacted live Teams/Bot Framework webhook or media-download logs, terminal output, or a recording that shows valid traffic still succeeds and mismatched serviceUrl traffic fails closed.
Confirm the fail-closed decision
A maintainer should explicitly confirm that rejecting missing, malformed, or claim-mismatched serviceUrl values is the intended upgrade behavior for existing Teams users.
Accept allowlist fallout
Maintainers may accept that undocumented serviceUrl or media hosts will require follow-up allowlist updates backed by redacted live evidence.

Next step before merge
Human review is needed for live Teams proof and the compatibility decision; there is no narrow automated code repair identified.

Security
Cleared: Dedicated security pass found no new dependency, workflow, secret, or supply-chain concern; the diff hardens Teams token binding and bearer forwarding, with upgrade proof risk tracked separately.

Review details

Best possible solution:

Land the scoped hardening only after maintainer confirmation of the fail-closed compatibility choice and redacted real Teams/Bot Framework proof that valid webhook and media flows still work.

Do we have a high-confidence way to reproduce the issue?

No live repro was established. Source inspection shows current main validates the bearer token before parsing Activity.serviceUrl, while PR head binds the verified serviceurl/serviceUrl claim to the parsed body value.

Is this the best way to solve the issue?

Yes, the patch is a narrow Microsoft Teams plugin hardening path and matches the upstream Bot Framework serviceUrl claim contract. It still needs real tenant proof and maintainer sign-off because the fail-closed behavior is upgrade-sensitive.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against b789e71e57d9.

Label changes

Label justifications:

P1: This touches Microsoft Teams Bot Framework authentication and token forwarding for a real channel workflow with security and compatibility impact.
merge-risk: 🚨 compatibility: The PR intentionally changes which inbound serviceUrl shapes and media hosts are accepted, which can break existing tenant traffic on upgrade.
merge-risk: 🚨 auth-provider: The PR changes Bot Framework JWT validation and bearer-token forwarding rules, directly affecting Teams auth and credential use.
rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: Needs real behavior proof before merge: the PR body shows local Vitest/diff-check proof but no redacted live Teams/Bot Framework webhook or media-download logs, terminal output, recording, or linked artifact; contributors should redact IPs, API keys, phone numbers, tenant details, and non-public endpoints, then update the PR body to trigger re-review or ask a maintainer to comment @clawsweeper re-review.

Evidence reviewed

PR surface:

Source +93, Tests +248. Total +341 across 8 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	4	114	21	+93
Tests	4	274	26	+248
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	8	388	47	+341

What I checked:

Repository policy applied: Root AGENTS.md and extensions/AGENTS.md were read; the relevant guidance treats plugin auth, fail-closed behavior, and channel proof as compatibility-sensitive review surfaces. (AGENTS.md:14, b789e71e57d9)
Current main accepts without serviceUrl binding: Current main creates the Bot Framework JWT validator before JSON parsing and calls validate(authHeader) without passing Activity serviceUrl, so the signed service URL is not bound to the body. (extensions/msteams/src/monitor.ts:302, b789e71e57d9)
PR adds body-backed serviceUrl validation: PR head parses bounded JSON after the cheap Bearer gate and passes getActivityServiceUrl(req.body) into JWT validation. (extensions/msteams/src/monitor.ts:311, a67b7284b9d8)
PR enforces JWT claim matching: PR head normalizes HTTPS service URLs and rejects tokens when the verified serviceurl/serviceUrl claim does not match the Activity serviceUrl. (extensions/msteams/src/sdk.ts:738, a67b7284b9d8)
PR scopes media Authorization on first hop: PR head strips Authorization from the initial safeFetch request when the URL is outside authorizationAllowHosts, matching the existing redirect-hop rule. (extensions/msteams/src/attachments/shared.ts:574, a67b7284b9d8)
Dependency contract checked: Microsoft BotBuilder's authenticateChannelTokenWithServiceUrl validates that the identity's serviceurl claim matches the supplied service URL, and AuthenticationConstants.ServiceUrlClaim is serviceurl.

Likely related people:

eleqtrizit: Authored the merged current-main Teams serviceUrl allowlist in fix(msteams): block untrusted Teams service URLs #87334, which this PR builds on directly. (role: recent area contributor; confidence: high; commits: 62550710bfec; files: extensions/msteams/src/bot-framework-service-url.ts, extensions/msteams/src/sdk.ts, extensions/msteams/src/send-context.ts)
Beandon13: Recent history for sdk.ts includes Teams Bot Framework JWT/network error handling in the same validator and monitor path. (role: adjacent feature contributor; confidence: medium; commits: eecda912ee75; files: extensions/msteams/src/sdk.ts, extensions/msteams/src/monitor.ts)
vincentkoc: Recent history for attachments/shared.ts shows Microsoft Teams attachment helper work near the safeFetch and media handling surface this PR changes. (role: recent adjacent contributor; confidence: medium; commits: f3f6a866cae1; files: extensions/msteams/src/attachments/shared.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

clawsweeper · 2026-05-27T04:50:04Z

ClawSweeper PR egg

🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat.

Where did the egg go?

The egg game starts only after the PR passes the real-behavior proof check.
Before that, no creature or rarity is rolled. The treat waits for real proof.
This is still just collectible flavor: proof affects review readiness, not creature quality.

eleqtrizit · 2026-05-27T19:36:00Z

Maintainer approval for the intentional compatibility change:

I approve this PR's fail-closed Microsoft Teams behavior as an intentional auth hardening change. Specifically, inbound Bot Framework activities with missing, malformed, query/fragment-bearing, or JWT-claim-mismatched serviceUrl values should return 401, and Bot Framework attachment bearer tokens should only be sent to explicitly auth-allowlisted hosts.

Compatibility note: if a valid Microsoft Teams tenant exposes a previously undocumented Bot Framework service URL or media host, we should treat that as an allowlist update with redacted live evidence rather than reopening broad token forwarding.

This approval does not replace the separate live Teams/Bot Framework proof request; that still needs credentialed, redacted webhook or media-download evidence before merge.

* fix(msteams): bind bot framework service urls * fix(msteams): harden service url validation

…026.5.28) (#759) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.5.27` → `2026.5.28` | --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.5.28`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#2026528) [Compare Source](openclaw/openclaw@v2026.5.27...v2026.5.28) ##### Highlights - Agent and Codex runtime recovery is steadier: subagents keep cwd/workspace separation, hook context stays prompt-local, session locks release on timeout abort while live OpenClaw locks survive cleanup, stale restart continuations are avoided, and Codex app-server/helper failures no longer tear down shared runtime state. ([#87218](openclaw/openclaw#87218), [#86875](openclaw/openclaw#86875), [#87409](openclaw/openclaw#87409), [#87399](openclaw/openclaw#87399), [#87375](openclaw/openclaw#87375), [#88129](openclaw/openclaw#88129)) - Channel delivery and session identity got safer across outbound plugin hooks, Matrix room ids, iMessage reactions/approvals, Slack final replies, Discord recovered tool warnings, runtime-config message actions, WhatsApp profile auth roots, Telegram polling, and Microsoft Teams service URL trust checks. ([#73706](openclaw/openclaw#73706), [#75670](openclaw/openclaw#75670), [#87366](openclaw/openclaw#87366), [#87451](openclaw/openclaw#87451), [#87334](openclaw/openclaw#87334), [#84535](openclaw/openclaw#84535), [#82492](openclaw/openclaw#82492), [#83304](openclaw/openclaw#83304), [#87160](openclaw/openclaw#87160)) - Mobile and chat surfaces got a broader refresh: the iOS Pro UI, hosted push relay default, realtime Talk tab playback, Gateway chat transport, onboarding, Talk permissions, WebChat reconnect delivery, and session picker behavior now preserve more state across reconnects and empty searches. ([#87367](openclaw/openclaw#87367), [#87531](openclaw/openclaw#87531), [#87682](openclaw/openclaw#87682), [#88096](openclaw/openclaw#88096), [#88105](openclaw/openclaw#88105)) Thanks [@ngutman](https://github.com/ngutman) and [@BunsDev](https://github.com/BunsDev). - Browser, channel, and automation inputs are stricter: Browser tool timeouts, viewport/tab indices, Gateway ports, cron retry handling, Discord component ids, schema array refs, Telegram callback pages, and channel progress callbacks now reject malformed values earlier and preserve the intended delivery context. ([#82887](openclaw/openclaw#82887)) - Provider, media, and document coverage expands with Claude Opus 4.8, Fal Krea image schemas, NVIDIA featured models, MiniMax streaming music responses, encrypted PDF extraction, voice model catalogs, GitHub Copilot agent runtime support, and a Codex Supervisor plugin path for delegated Codex workflows. ([#87845](openclaw/openclaw#87845), [#87890](openclaw/openclaw#87890), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764), [#87751](openclaw/openclaw#87751), [#87794](openclaw/openclaw#87794)) - CLI, auth, doctor, and provider paths fail faster and recover more clearly: malformed numeric/version options are rejected, workspace dotenv provider credentials are ignored, heartbeat defaults, OAuth/token lifetimes, and local service startup requests are bounded, agent auth health labels are clearer, legacy `api_key` auth profiles migrate to canonical form, and restart guidance is actionable. ([#87398](openclaw/openclaw#87398), [#86281](openclaw/openclaw#86281), [#87361](openclaw/openclaw#87361), [#88133](openclaw/openclaw#88133), [#83655](openclaw/openclaw#83655), [#87559](openclaw/openclaw#87559), [#88088](openclaw/openclaw#88088), [#85924](openclaw/openclaw#85924)) Thanks [@vincentkoc](https://github.com/vincentkoc) and [@giodl73-repo](https://github.com/giodl73-repo). - Plugin and Gateway hot paths do less repeated work while preserving cache correctness for install records, config JSON parsing, tool search catalogs, session stores, manifest model rows, auto-enabled plugin config, browser tokens, viewer assets, and release-split external plugin packages. ([#86699](openclaw/openclaw#86699)) - Release, QA, and E2E validation now bound more log, artifact, harness, and cross-OS waits so failing lanes produce proof instead of hanging or false-greening. ##### Changes - Status: show active subagent details in status output. - Diffs: split the default language pack and expand default Diffs language coverage while keeping the host floor aligned. ([#87370](openclaw/openclaw#87370), [#87372](openclaw/openclaw#87372)) Thanks [@RomneyDa](https://github.com/RomneyDa). - ClawHub: add plugin display names plus skill verification and trust surfaces. ([#87354](openclaw/openclaw#87354), [#86699](openclaw/openclaw#86699)) Thanks [@thewilloftheshadow](https://github.com/thewilloftheshadow) and [@Patrick-Erichsen](https://github.com/Patrick-Erichsen). - iOS: refresh the dev app with Pro Command, Chat, Agents, Settings, hosted push relay defaults, and realtime Talk playback wired to gateway sessions, diagnostics, chat, and realtime Talk. ([#87367](openclaw/openclaw#87367), [#88096](openclaw/openclaw#88096), [#88105](openclaw/openclaw#88105)) Thanks [@Solvely-Colin](https://github.com/Solvely-Colin) and [@ngutman](https://github.com/ngutman). - Docs: clarify Codex computer-use setup, paste-token stdin auth setup, macOS gateway sleep troubleshooting, native Codex hook relay recovery, container model auth, install deployment cards, device-token admin gating, CLI setup flow compatibility, Notte cloud browser CDP setup, and backport targets. ([#87313](openclaw/openclaw#87313), [#63050](openclaw/openclaw#63050), [#87685](openclaw/openclaw#87685)) Thanks [@bdjben](https://github.com/bdjben), [@liaoandi](https://github.com/liaoandi), and [@thewilloftheshadow](https://github.com/thewilloftheshadow). - PDF/tools: use ClawPDF for PDF extraction, support encrypted PDF extraction, and surface MCP structured content in agent tool results. ([#87670](openclaw/openclaw#87670), [#87751](openclaw/openclaw#87751)) - Providers: add Claude Opus 4.8 support, Fal Krea image model schemas, NVIDIA featured model catalogs, MiniMax streaming music responses, and provider-backed voice model catalogs. ([#87845](openclaw/openclaw#87845), [#87890](openclaw/openclaw#87890), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764), [#87794](openclaw/openclaw#87794)) Thanks [@eleqtrizit](https://github.com/eleqtrizit) and [@vincentkoc](https://github.com/vincentkoc). - Codex/GitHub: add the GitHub Copilot agent runtime and the Codex Supervisor plugin package. - Plugins: externalize GitHub Copilot and Tokenjuice as official install-on-demand plugins with npm and ClawHub publish metadata. - Workboard: add agent coordination tools for tracking and handing off active agent work. - Discord: show commentary in progress drafts so live Discord runs expose useful in-progress context. ([#85200](openclaw/openclaw#85200)) - Plugin SDK: add a reply payload sending hook for plugins that need to deliver channel-owned replies and flatten package types for SDK declarations. ([#82823](openclaw/openclaw#82823), [#87165](openclaw/openclaw#87165)) Thanks [@piersonr](https://github.com/piersonr) and [@RomneyDa](https://github.com/RomneyDa). - Policy: add policy comparison, ingress-channel conformance, and sandbox-posture conformance checks. ([#85572](openclaw/openclaw#85572), [#85744](openclaw/openclaw#85744), [#86768](openclaw/openclaw#86768)) ##### Fixes - Agents: fall back to local config pruning when the optional `agents delete` Gateway probe cannot authenticate, so offline installs can still delete agents without removing shared workspaces. - Tighten phone-control mutation authorization \[AI]. ([#87150](openclaw/openclaw#87150)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Clarify directive persistence authorization policy \[AI]. ([#86369](openclaw/openclaw#86369)) Thanks [@pgondhi987](https://github.com/pgondhi987). - Agents/Codex: keep spawned agent cwd/workspace state separated, forward ACP spawn attachments, keep hook context prompt-local, release session locks on timeout abort and runtime teardown without deleting live OpenClaw-owned locks during cleanup, avoid session event queue self-wait, clean up exec abort listeners, stream assistant deltas incrementally, recover raw missing-thread compaction failures, preserve rotated compaction session identity, keep compaction-timeout snapshots continuable, preserve shared app-server state across startup or helper failures, keep native hook relay alive across restarts and prune stale bridge files, close native hook relay replacement races, keep Claude live tool progress visible for watchdog recovery, suppress abandoned requester completion handoff, route workspace memory through tools, resolve Codex runtime models first, report quarantined dynamic tools, format `skills` command output, bind node auto-review to prepared plans, retry Claude CLI transcript probes, and bound compaction/steering retries. ([#87218](openclaw/openclaw#87218), [#86875](openclaw/openclaw#86875), [#86123](openclaw/openclaw#86123), [#88129](openclaw/openclaw#88129), [#87399](openclaw/openclaw#87399), [#87375](openclaw/openclaw#87375), [#72574](openclaw/openclaw#72574), [#87383](openclaw/openclaw#87383), [#87400](openclaw/openclaw#87400), [#83022](openclaw/openclaw#83022), [#87671](openclaw/openclaw#87671), [#87738](openclaw/openclaw#87738), [#87747](openclaw/openclaw#87747), [#87706](openclaw/openclaw#87706), [#87546](openclaw/openclaw#87546), [#87541](openclaw/openclaw#87541), [#81048](openclaw/openclaw#81048)) Thanks [@mbelinky](https://github.com/mbelinky), [@Alix-007](https://github.com/Alix-007), [@luoyanglang](https://github.com/luoyanglang), [@yetval](https://github.com/yetval), [@sjf](https://github.com/sjf), [@joshavant](https://github.com/joshavant), [@benjamin1492](https://github.com/benjamin1492), [@c19354837](https://github.com/c19354837), [@fuller-stack-dev](https://github.com/fuller-stack-dev), [@pfrederiksen](https://github.com/pfrederiksen), and [@dodge1218](https://github.com/dodge1218). - Codex Supervisor: keep real-home app-server MCP session listing on the loaded state path, bound stored history scans, and close WebSocket probes cleanly. - Channels: thread canonical session keys into outbound hooks, preserve Matrix room-id case, keep fallback tool warnings mention-inert, retain delivered Slack final replies during late cleanup, continue iMessage polling after denied reactions, suppress duplicate native exec approvals, resolve Gateway message actions against the active runtime config, preserve Telegram SecretRef prompt config and polling keepalives, preserve WhatsApp profile auth roots, QR display, document filenames, and plugin hook config, suppress Discord recovered tool warnings, preserve the Discord voice outbound helper, cap Discord/Signal/Zalo channel request and container timeouts, and block untrusted Teams service URLs while keeping TeamsSDK patterns aligned. ([#73706](openclaw/openclaw#73706), [#75670](openclaw/openclaw#75670), [#87366](openclaw/openclaw#87366), [#87451](openclaw/openclaw#87451), [#87465](openclaw/openclaw#87465), [#87334](openclaw/openclaw#87334), [#84535](openclaw/openclaw#84535), [#76262](openclaw/openclaw#76262), [#83304](openclaw/openclaw#83304), [#82492](openclaw/openclaw#82492), [#87581](openclaw/openclaw#87581), [#77114](openclaw/openclaw#77114), [#86426](openclaw/openclaw#86426), [#85529](openclaw/openclaw#85529), [#87160](openclaw/openclaw#87160)) Thanks [@zeroaltitude](https://github.com/zeroaltitude), [@lukeboyett](https://github.com/lukeboyett), [@jarvis-mns1](https://github.com/jarvis-mns1), [@xiaotian](https://github.com/xiaotian), [@funmerlin](https://github.com/funmerlin), [@joshavant](https://github.com/joshavant), [@eleqtrizit](https://github.com/eleqtrizit), [@heyitsaamir](https://github.com/heyitsaamir), [@amittell](https://github.com/amittell), [@lidge-jun](https://github.com/lidge-jun), [@liorb-mountapps](https://github.com/liorb-mountapps), [@masatohoshino](https://github.com/masatohoshino), [@bladin](https://github.com/bladin), and [@giodl73-repo](https://github.com/giodl73-repo). - CLI/auth/doctor/providers: reject malformed numeric/timeout/subcommand-version inputs, ignore workspace dotenv provider credentials, wait for respawn child shutdown, bound heartbeat defaults plus Codex, GitHub Copilot, OpenAI, Anthropic, Google, Feishu, LM Studio, MiniMax, Xiaomi TTS, and local-provider OAuth/token/model requests, harden Codex auth probes, label auth health by agent, preserve explicit agentRuntime pins during Codex model migration, warm provider auth off the main thread, honor Codex response timeouts, stop migrating current Claude Haiku 4.5 profiles to Sonnet, bound local service startup, resolve GPT-5.5 without cached catalog, migrate legacy memory auto-provider config, rewrite non-canonical `api_key` auth profiles, and make doctor restart follow-ups actionable. ([#87398](openclaw/openclaw#87398), [#86281](openclaw/openclaw#86281), [#87361](openclaw/openclaw#87361), [#88133](openclaw/openclaw#88133), [#83655](openclaw/openclaw#83655), [#87559](openclaw/openclaw#87559), [#87719](openclaw/openclaw#87719), [#88088](openclaw/openclaw#88088), [#85924](openclaw/openclaw#85924), [#84362](openclaw/openclaw#84362)) Thanks [@Patrick-Erichsen](https://github.com/Patrick-Erichsen), [@samzong](https://github.com/samzong), [@giodl73-repo](https://github.com/giodl73-repo), [@alkor2000](https://github.com/alkor2000), [@mmaps](https://github.com/mmaps), [@nxmxbbd](https://github.com/nxmxbbd), and [@vincentkoc](https://github.com/vincentkoc). - Gateway/security/session state: expire browser tokens after auth rotation, scope assistant idempotency dedupe, drain probe client closes, avoid stale restart continuation reuse, preserve retry-after fallbacks and stale rate-limit cooldown probes, bound webchat image and artifact transcript scans, include seconds in inbound metadata timestamps, clear completed session active runs, clear stale chat stream buffers, and evict current plugin-state namespaces at row caps. ([#87810](openclaw/openclaw#87810), [#87833](openclaw/openclaw#87833), [#75089](openclaw/openclaw#75089)) Thanks [@joshavant](https://github.com/joshavant) and [@litang9](https://github.com/litang9). - Config/parsing/network: reject partial numeric parsing, parse provider/Discord retry headers and dates strictly, honor IPv6 and bare IPv6 `no_proxy` entries, preserve empty plugin allowlists, canonicalize secret target array indexes, and reject malformed media content lengths, inspected TCP ports, marketplace content lengths, cron epochs, sandbox stat fields, unsafe duration values, empty config path segments, noncanonical schema array refs, unsafe Telegram callback pages, and invalid Teams attachment-fetch DNS targets. ([#87883](openclaw/openclaw#87883)) Thanks [@zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Browser/input hardening: reject invalid tab indexes, excessive viewport resizes, explicit zero CDP ports, malformed geolocation options, unsafe screenshot or permission-grant timeouts, loose response-body limits, invalid cookie expiries, and non-finite Browser tool delays/timeouts. - Cron/automation: retry recurring jobs after transient model rate limits before waiting for the next scheduled slot, and preflight model fallbacks before skipping scheduled work. ([#82887](openclaw/openclaw#82887)) Thanks [@chen-zhang-cs-code](https://github.com/chen-zhang-cs-code). - Auto-reply/directives: respect provider and relayed channel metadata during directive persistence so channel-originated decisions keep their intended context. ([#87683](openclaw/openclaw#87683)) - WhatsApp: resolve the auth directory from the active profile so profile-scoped WhatsApp installs do not drift to the wrong credential root. ([#82492](openclaw/openclaw#82492)) Thanks [@lidge-jun](https://github.com/lidge-jun). - Gateway/session state: clear completed session active runs, avoid cold-loading providers for MCP inventory, cache single-session child indexes, cap handshake timers, and bound preauth, auth-guard, media, transcript, readiness, and port options. - Channels/replies: preserve channel-owned progress callbacks when verbose output is off, keep group-room progress suppression intact, prefer external session delivery context, escape Discord component id delimiters, force final TUI chat repaints, show Slack reasoning previews, and normalize Discord/Matrix/Mattermost channel numeric options. ([#87476](openclaw/openclaw#87476), [#87423](openclaw/openclaw#87423)) - Agents/tool args: harden smart-quoted argument repair for edit arrays and exact escaped arguments so model-produced tool calls recover without corrupting valid input. ([#86611](openclaw/openclaw#86611)) Thanks [@ferminquant](https://github.com/ferminquant). - Providers/agents: preserve seeded Anthropic signatures, preserve signed thinking payloads, concatenate signature-delta chunks, preserve DeepSeek `reasoning_content` replay across tier suffixes, apply OpenRouter strict9 ids to Mistral routes, promote Ollama plain-text tool calls, load NVIDIA featured model catalogs, stream MiniMax music generation responses, and recover empty preflight compaction. ([#87593](openclaw/openclaw#87593), [#87493](openclaw/openclaw#87493), [#80775](openclaw/openclaw#80775), [#84764](openclaw/openclaw#84764)) Thanks [@Pluviobyte](https://github.com/Pluviobyte) and [@eleqtrizit](https://github.com/eleqtrizit). - Media/images: skip CLI image cache refs when resolving generated images, allow trusted generated HTML attachments, and bound generated video downloads so stale refs and slow providers fail cleanly. ([#87523](openclaw/openclaw#87523), [#87982](openclaw/openclaw#87982)) - File transfer: handle late tar stdin pipe errors after archive validation or unpacking has already settled. - Performance: trust install-record caches between reloads, prefer native JSON parsing, reuse unchanged tool-search catalogs, reuse gateway session and plugin metadata paths, skip unchanged store serialization, patch single-entry session writes, add precomputed session patch writers, reduce store clone allocations, cache manifest model catalog rows and auto-enabled plugin config, avoid full session snapshots for entry reads, defer configured Slack full startup, prefer bundled plugin dist entries, and slim current metadata identity caches. ([#87760](openclaw/openclaw#87760)) - Docker/release/QA: package runtime workspace templates, stream cross-OS served artifacts, preserve sparse Crabbox run artifacts, isolate npm plugin installs per package, reject incompatible package plugin API installs, drop the leftover root Sharp dependency from package manifests after the Rastermill migration, bound OpenClaw instance logs, plugin gauntlet relay logs, MCP channel buffers, kitchen-sink scans, agent-turn assertions, QA-Lab credential broker calls, QA Matrix substrate requests, and release scenario logs, and keep release/google live guards current. ([#87647](openclaw/openclaw#87647), [#87477](openclaw/openclaw#87477)) Thanks [@rohitjavvadi](https://github.com/rohitjavvadi) and [@vincentkoc](https://github.com/vincentkoc). - Release/CI: bound manual git fetches, ClawHub verifier responses, ClawHub owner metadata, dependency-guard error bodies, Parallels limits, startup/test/memory budget parsing, and diffs viewer build warnings so release lanes fail with useful proof instead of hanging. ([#87839](openclaw/openclaw#87839)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/759

* fix(msteams): bind bot framework service urls * fix(msteams): harden service url validation

openclaw-barnacle Bot added channel: msteams Channel integration: msteams size: M maintainer Maintainer-authored PR labels May 27, 2026

eleqtrizit self-assigned this May 27, 2026

BradGroux mentioned this pull request May 27, 2026

WORKING: All Microsoft Issues and PRs (refresh) #74163

Draft

clawsweeper Bot mentioned this pull request May 27, 2026

fix(msteams): block untrusted Teams service URLs #87334

Merged

clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels May 27, 2026

eleqtrizit force-pushed the 694 branch from 375aa12 to 997a630 Compare May 27, 2026 19:05

eleqtrizit added 2 commits May 27, 2026 19:37

fix(msteams): bind bot framework service urls

47baffc

fix(msteams): harden service url validation

a67b728

eleqtrizit force-pushed the 694 branch from 997a630 to a67b728 Compare May 27, 2026 19:40

This comment was marked as spam.

Sign in to view

eleqtrizit merged commit 2c3d7f5 into openclaw:main May 28, 2026
96 of 99 checks passed

github-actions Bot mentioned this pull request May 28, 2026

📡 Upstream Digest — 2026-05-28 15:32 UTC curtismercier/openclaw-mods#964

Open

eleqtrizit deleted the 694 branch May 28, 2026 20:20

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 29, 2026

fix(msteams): bind bot framework service urls (openclaw#87160)

986e35e

* fix(msteams): bind bot framework service urls * fix(msteams): harden service url validation

SYU8384 pushed a commit to SYU8384/openclaw that referenced this pull request Jun 3, 2026

fix(msteams): bind bot framework service urls (openclaw#87160)

30e003b

* fix(msteams): bind bot framework service urls * fix(msteams): harden service url validation

sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026

fix(msteams): bind bot framework service urls (openclaw#87160)

46c93bb

* fix(msteams): bind bot framework service urls * fix(msteams): harden service url validation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(msteams): bind bot framework service urls#87160

fix(msteams): bind bot framework service urls#87160
eleqtrizit merged 2 commits into
openclaw:mainfrom
eleqtrizit:694

eleqtrizit commented May 27, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 27, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 27, 2026

Uh oh!

eleqtrizit commented May 27, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

eleqtrizit commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Validation

Notes

Uh oh!

clawsweeper Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 27, 2026

Uh oh!

eleqtrizit commented May 27, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eleqtrizit commented May 27, 2026 •

edited

Loading

clawsweeper Bot commented May 27, 2026 •

edited

Loading